All of lore.kernel.org
 help / color / mirror / Atom feed
* typo in inode.c
@ 2012-09-26 11:48 ching
  2012-09-26 15:23 ` David Sterba
  0 siblings, 1 reply; 4+ messages in thread
From: ching @ 2012-09-26 11:48 UTC (permalink / raw)
  To: linux-btrfs@vger.kernel.org

There is a typo (?) in inode.c (git)

i guess the "int limit = 10 * 1024 * 1042;" should be "int limit = 10 * 1024 * 1024;" instead

Could developer fix this typo?


static int cow_file_range_async(struct inode *inode, struct page *locked_page,
				u64 start, u64 end, int *page_started,
				unsigned long *nr_written)
{
	struct async_cow *async_cow;
	struct btrfs_root *root = BTRFS_I(inode)->root;
	unsigned long nr_pages;
	u64 cur_end;
	int limit = 10 * 1024 * 1042;

	clear_extent_bit(&BTRFS_I(inode)->io_tree, start, end, EXTENT_LOCKED,
			 1, 0, NULL, GFP_NOFS);
	while (start < end) {
		async_cow = kmalloc(sizeof(*async_cow), GFP_NOFS);
		BUG_ON(!async_cow);
		async_cow->inode = inode;
		async_cow->root = root;
		async_cow->locked_page = locked_page;
		async_cow->start = start;



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: typo in inode.c
  2012-09-26 11:48 typo in inode.c ching
@ 2012-09-26 15:23 ` David Sterba
  2012-09-26 21:04   ` ching
  0 siblings, 1 reply; 4+ messages in thread
From: David Sterba @ 2012-09-26 15:23 UTC (permalink / raw)
  To: ching; +Cc: linux-btrfs@vger.kernel.org

On Wed, Sep 26, 2012 at 07:48:47PM +0800, ching wrote:
> There is a typo (?) in inode.c (git)

What's the top commit and what git tree?

This has been fixed in 3.6-rc4 via
287082b0bd10060e9c6b32ed9605174ddf2f672a

david

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: typo in inode.c
  2012-09-26 15:23 ` David Sterba
@ 2012-09-26 21:04   ` ching
  2012-09-27  7:55     ` David Sterba
  0 siblings, 1 reply; 4+ messages in thread
From: ching @ 2012-09-26 21:04 UTC (permalink / raw)
  To: linux-btrfs@vger.kernel.org

On 09/26/2012 11:23 PM, David Sterba wrote:
> On Wed, Sep 26, 2012 at 07:48:47PM +0800, ching wrote:
>> There is a typo (?) in inode.c (git)
> What's the top commit and what git tree?
>
> This has been fixed in 3.6-rc4 via
> 287082b0bd10060e9c6b32ed9605174ddf2f672a
>
> david
>
This mistake is in

http://git.kernel.org/?p=linux/kernel/git/mason/linux-btrfs.git;a=summary

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: typo in inode.c
  2012-09-26 21:04   ` ching
@ 2012-09-27  7:55     ` David Sterba
  0 siblings, 0 replies; 4+ messages in thread
From: David Sterba @ 2012-09-27  7:55 UTC (permalink / raw)
  To: ching; +Cc: linux-btrfs@vger.kernel.org

On Thu, Sep 27, 2012 at 05:04:02AM +0800, ching wrote:
> On 09/26/2012 11:23 PM, David Sterba wrote:
> > On Wed, Sep 26, 2012 at 07:48:47PM +0800, ching wrote:
> >> There is a typo (?) in inode.c (git)
> > What's the top commit and what git tree?
> >
> > This has been fixed in 3.6-rc4 via
> > 287082b0bd10060e9c6b32ed9605174ddf2f672a
> >
> This mistake is in
> 
> http://git.kernel.org/?p=linux/kernel/git/mason/linux-btrfs.git;a=summary

I see, this is because the fix was merged into linus' tree via the
trivial tree. If unsure, you may want to check btrfs-next first.

david

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-09-27  7:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-26 11:48 typo in inode.c ching
2012-09-26 15:23 ` David Sterba
2012-09-26 21:04   ` ching
2012-09-27  7:55     ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.