From: Rob Herring <robherring2@gmail.com>
To: Jon Hunter <jon-hunter@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>, Benoit Cousson <b-cousson@ti.com>,
Tony Lindgren <tony@atomide.com>,
device-tree <devicetree-discuss@lists.ozlabs.org>,
Grant Likely <grant.likely@secretlab.ca>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 7/7] ARM: OMAP: Add DT support for timer driver
Date: Wed, 26 Sep 2012 11:11:40 -0500 [thread overview]
Message-ID: <5063293C.1080404@gmail.com> (raw)
In-Reply-To: <50632497.2070103@ti.com>
On 09/26/2012 10:51 AM, Jon Hunter wrote:
> Hi Rob,
>> #define OMAP3_32K_SOURCE "omap_32k_fck"
>> #define OMAP4_32K_SOURCE "sys_32k_ck"
>>
>> +#define TIMER_PROP_ALWON "ti,timer-alwon"
>> +
>
> I see you made the following comment [1] here ...
>
> "It would be easier to follow the code if you use the strings directly
> (and you do in some places)."
>
> I could avoid the above definition.
>
>> #ifdef CONFIG_OMAP_32K_TIMER
>> #define OMAP2_CLKEV_SOURCE OMAP2_32K_SOURCE
>> #define OMAP3_CLKEV_SOURCE OMAP3_32K_SOURCE
>> #define OMAP4_CLKEV_SOURCE OMAP4_32K_SOURCE
>> #define OMAP3_SECURE_TIMER 12
>> +#define TIMER_PROP_SECURE "ti,timer-secure"
>> #else
>> #define OMAP2_CLKEV_SOURCE OMAP2_MPU_SOURCE
>> #define OMAP3_CLKEV_SOURCE OMAP3_MPU_SOURCE
>> #define OMAP4_CLKEV_SOURCE OMAP4_MPU_SOURCE
>> #define OMAP3_SECURE_TIMER 1
>> +#define TIMER_PROP_SECURE TIMER_PROP_ALWON
>> #endif
>
> Are you ok, with having the TIMER_PROP_SECURE definition or would you
> prefer I handle this differently? This is dependent on the kernel config.\
Yes, that's fine.
Rob
>
> Cheers
> Jon
>
> [1] http://thread.gmane.org/gmane.linux.ports.arm.omap/84458/focus=84982
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 7/7] ARM: OMAP: Add DT support for timer driver
Date: Wed, 26 Sep 2012 11:11:40 -0500 [thread overview]
Message-ID: <5063293C.1080404@gmail.com> (raw)
In-Reply-To: <50632497.2070103@ti.com>
On 09/26/2012 10:51 AM, Jon Hunter wrote:
> Hi Rob,
>> #define OMAP3_32K_SOURCE "omap_32k_fck"
>> #define OMAP4_32K_SOURCE "sys_32k_ck"
>>
>> +#define TIMER_PROP_ALWON "ti,timer-alwon"
>> +
>
> I see you made the following comment [1] here ...
>
> "It would be easier to follow the code if you use the strings directly
> (and you do in some places)."
>
> I could avoid the above definition.
>
>> #ifdef CONFIG_OMAP_32K_TIMER
>> #define OMAP2_CLKEV_SOURCE OMAP2_32K_SOURCE
>> #define OMAP3_CLKEV_SOURCE OMAP3_32K_SOURCE
>> #define OMAP4_CLKEV_SOURCE OMAP4_32K_SOURCE
>> #define OMAP3_SECURE_TIMER 12
>> +#define TIMER_PROP_SECURE "ti,timer-secure"
>> #else
>> #define OMAP2_CLKEV_SOURCE OMAP2_MPU_SOURCE
>> #define OMAP3_CLKEV_SOURCE OMAP3_MPU_SOURCE
>> #define OMAP4_CLKEV_SOURCE OMAP4_MPU_SOURCE
>> #define OMAP3_SECURE_TIMER 1
>> +#define TIMER_PROP_SECURE TIMER_PROP_ALWON
>> #endif
>
> Are you ok, with having the TIMER_PROP_SECURE definition or would you
> prefer I handle this differently? This is dependent on the kernel config.\
Yes, that's fine.
Rob
>
> Cheers
> Jon
>
> [1] http://thread.gmane.org/gmane.linux.ports.arm.omap/84458/focus=84982
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2012-09-26 16:11 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 23:31 [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers Jon Hunter
2012-09-13 23:31 ` Jon Hunter
2012-09-13 23:31 ` [PATCH V2 1/7] ARM: dts: OMAP: Add timer nodes Jon Hunter
2012-09-13 23:31 ` Jon Hunter
2012-09-13 23:31 ` [PATCH V2 2/7] ARM: OMAP3: Dynamically disable secure timer nodes for secure devices Jon Hunter
2012-09-13 23:31 ` Jon Hunter
2012-09-13 23:31 ` [PATCH V2 3/7] ARM: OMAP4: Add timer clock aliases for device-tree Jon Hunter
2012-09-13 23:31 ` Jon Hunter
[not found] ` <1347579091-3794-4-git-send-email-jon-hunter-l0cyMroinI0@public.gmane.org>
2012-09-19 23:55 ` Paul Walmsley
2012-09-19 23:55 ` Paul Walmsley
2012-09-13 23:31 ` [PATCH V2 4/7] ARM: OMAP: Add a timer attribute for timers that can interrupt the DSP Jon Hunter
2012-09-13 23:31 ` Jon Hunter
2012-09-20 0:07 ` Paul Walmsley
2012-09-20 0:07 ` Paul Walmsley
2012-09-13 23:31 ` [PATCH V2 5/7] ARM: OMAP: Add function to request a timer by capability Jon Hunter
2012-09-13 23:31 ` Jon Hunter
2012-09-13 23:31 ` [PATCH V2 6/7] ARM: OMAP3: Add generic machine descriptor for boards with OMAP3 GP devices Jon Hunter
2012-09-13 23:31 ` Jon Hunter
2012-09-13 23:31 ` [PATCH V2 7/7] ARM: OMAP: Add DT support for timer driver Jon Hunter
2012-09-13 23:31 ` Jon Hunter
2012-09-20 0:19 ` Rob Herring
2012-09-20 0:19 ` Rob Herring
2012-09-26 15:51 ` Jon Hunter
2012-09-26 15:51 ` Jon Hunter
2012-09-26 16:11 ` Rob Herring [this message]
2012-09-26 16:11 ` Rob Herring
2012-09-13 23:39 ` [PATCH V2 0/7] ARM: OMAP2+: Add device-tree support for timers Jon Hunter
2012-09-13 23:39 ` Jon Hunter
2012-09-20 2:23 ` Benoit Cousson
2012-09-20 2:23 ` Benoit Cousson
2012-09-20 23:53 ` Tony Lindgren
2012-09-20 23:53 ` Tony Lindgren
2012-09-26 16:53 ` Jon Hunter
2012-09-26 16:53 ` Jon Hunter
2012-09-28 18:51 ` Vaibhav Hiremath
2012-09-28 18:51 ` Vaibhav Hiremath
2012-09-28 21:30 ` Jon Hunter
2012-09-28 21:30 ` Jon Hunter
[not found] ` <5065F19E.5020708-l0cyMroinI0@public.gmane.org>
2012-09-28 21:47 ` Jon Hunter
2012-09-28 21:47 ` Jon Hunter
2012-09-29 9:33 ` Hiremath, Vaibhav
2012-09-29 9:33 ` Hiremath, Vaibhav
2012-10-08 21:10 ` Tony Lindgren
2012-10-08 21:10 ` Tony Lindgren
2012-09-28 22:17 ` Jon Hunter
2012-09-28 22:17 ` Jon Hunter
2012-09-26 15:40 ` Jon Hunter
2012-09-26 15:40 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5063293C.1080404@gmail.com \
--to=robherring2@gmail.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.