From: Stephen Boyd <sboyd@codeaurora.org>
To: Pankaj Jangra <jangra.pankaj9@gmail.com>
Cc: David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 08/10] ARM: msm: Prepare clk_get() users in mach-msm for clock-pcom driver
Date: Wed, 26 Sep 2012 11:14:21 -0700 [thread overview]
Message-ID: <506345FD.8010609@codeaurora.org> (raw)
In-Reply-To: <CADTbHxrQQ9GQKm1Xd3gn4eLu=uKvkdHRvBYDq0iRLiJwy+1amw@mail.gmail.com>
On 09/26/12 10:35, Pankaj Jangra wrote:
> Hi,
>
> On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> In the near future we'll be moving clock-pcom to a platform
>> driver, in which case these two users of clk_get() in mach-msm
>> need to be updated. Have board-trout-panel.c make the proc_comm
>> call directly so that we don't have to port this board specific
>> code to the driver right now and reorder the initcall order of
>> dma.c so that it initializes after the clock driver probes but
>> before any drivers use dma APIs.
>>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>> arch/arm/mach-msm/Makefile | 9 ++++++---
>> arch/arm/mach-msm/board-trout-panel.c | 19 +++++++------------
>> arch/arm/mach-msm/dma.c | 5 ++---
>> 3 files changed, 15 insertions(+), 18 deletions(-)
>>
>> diff --git a/arch/arm/mach-msm/Makefile b/arch/arm/mach-msm/Makefile
>> index 17519fa..3dbae74 100644
>> --- a/arch/arm/mach-msm/Makefile
>> +++ b/arch/arm/mach-msm/Makefile
>> @@ -5,12 +5,15 @@ obj-$(CONFIG_DEBUG_FS) += clock-debug.o
>> obj-$(CONFIG_MSM_VIC) += irq-vic.o
>> obj-$(CONFIG_MSM_IOMMU) += devices-iommu.o
>>
>> -obj-$(CONFIG_ARCH_MSM7X00A) += dma.o irq.o
>> -obj-$(CONFIG_ARCH_MSM7X30) += dma.o
>> -obj-$(CONFIG_ARCH_QSD8X50) += dma.o sirc.o
>> +obj-$(CONFIG_ARCH_MSM7X00A) += irq.o
>> +obj-$(CONFIG_ARCH_QSD8X50) += sirc.o
>>
>> obj-$(CONFIG_MSM_PROC_COMM) += proc_comm.o clock-pcom.o vreg.o
>>
>> +obj-$(CONFIG_ARCH_MSM7X00A) += dma.o
>> +obj-$(CONFIG_ARCH_MSM7X30) += dma.o
>> +obj-$(CONFIG_ARCH_QSD8X50) += dma.o
>> +
> I did not understand what is the need of this change in Makefile?
Quoted from commit text:
reorder the initcall order of
dma.c so that it initializes after the clock driver probes but
before any drivers use dma APIs.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] ARM: msm: Prepare clk_get() users in mach-msm for clock-pcom driver
Date: Wed, 26 Sep 2012 11:14:21 -0700 [thread overview]
Message-ID: <506345FD.8010609@codeaurora.org> (raw)
In-Reply-To: <CADTbHxrQQ9GQKm1Xd3gn4eLu=uKvkdHRvBYDq0iRLiJwy+1amw@mail.gmail.com>
On 09/26/12 10:35, Pankaj Jangra wrote:
> Hi,
>
> On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> In the near future we'll be moving clock-pcom to a platform
>> driver, in which case these two users of clk_get() in mach-msm
>> need to be updated. Have board-trout-panel.c make the proc_comm
>> call directly so that we don't have to port this board specific
>> code to the driver right now and reorder the initcall order of
>> dma.c so that it initializes after the clock driver probes but
>> before any drivers use dma APIs.
>>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>> arch/arm/mach-msm/Makefile | 9 ++++++---
>> arch/arm/mach-msm/board-trout-panel.c | 19 +++++++------------
>> arch/arm/mach-msm/dma.c | 5 ++---
>> 3 files changed, 15 insertions(+), 18 deletions(-)
>>
>> diff --git a/arch/arm/mach-msm/Makefile b/arch/arm/mach-msm/Makefile
>> index 17519fa..3dbae74 100644
>> --- a/arch/arm/mach-msm/Makefile
>> +++ b/arch/arm/mach-msm/Makefile
>> @@ -5,12 +5,15 @@ obj-$(CONFIG_DEBUG_FS) += clock-debug.o
>> obj-$(CONFIG_MSM_VIC) += irq-vic.o
>> obj-$(CONFIG_MSM_IOMMU) += devices-iommu.o
>>
>> -obj-$(CONFIG_ARCH_MSM7X00A) += dma.o irq.o
>> -obj-$(CONFIG_ARCH_MSM7X30) += dma.o
>> -obj-$(CONFIG_ARCH_QSD8X50) += dma.o sirc.o
>> +obj-$(CONFIG_ARCH_MSM7X00A) += irq.o
>> +obj-$(CONFIG_ARCH_QSD8X50) += sirc.o
>>
>> obj-$(CONFIG_MSM_PROC_COMM) += proc_comm.o clock-pcom.o vreg.o
>>
>> +obj-$(CONFIG_ARCH_MSM7X00A) += dma.o
>> +obj-$(CONFIG_ARCH_MSM7X30) += dma.o
>> +obj-$(CONFIG_ARCH_QSD8X50) += dma.o
>> +
> I did not understand what is the need of this change in Makefile?
Quoted from commit text:
reorder the initcall order of
dma.c so that it initializes after the clock driver probes but
before any drivers use dma APIs.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2012-09-26 18:14 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 2:26 [PATCH 00/10] Convert MSM to common clock framework Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 01/10] usb: otg: msm: Convert to clk_prepare/unprepare Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
[not found] ` <1348194419-11486-2-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-09-26 16:58 ` Pankaj Jangra
2012-09-26 16:58 ` Pankaj Jangra
2012-09-26 16:58 ` Pankaj Jangra
2012-09-26 18:48 ` Stephen Boyd
2012-09-26 18:48 ` Stephen Boyd
[not found] ` <50634DF9.5010608-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-09-26 18:52 ` Pankaj Jangra
2012-09-26 18:52 ` Pankaj Jangra
2012-09-26 18:52 ` Pankaj Jangra
2012-09-21 2:26 ` [PATCH 02/10] msm_sdcc: " Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 03/10] msm: iommu: " Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-24 22:32 ` Saravana Kannan
2012-09-24 22:32 ` Saravana Kannan
2012-09-25 20:16 ` Stephen Boyd
2012-09-25 20:16 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 04/10] msm: iommu: Use clk_set_rate() instead of clk_set_min_rate() Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 05/10] ARM: msm: Remove custom clk_set_flags() API Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-24 22:33 ` Saravana Kannan
2012-09-24 22:33 ` Saravana Kannan
2012-09-21 2:26 ` [PATCH 06/10] ARM: msm: Remove custom clk_set_{max,min}_rate() API Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-24 22:37 ` Saravana Kannan
2012-09-24 22:37 ` Saravana Kannan
2012-09-21 2:26 ` [PATCH 07/10] ARM: msm: Remove clock-7x30.h include file Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-26 17:51 ` Pankaj Jangra
2012-09-26 17:51 ` Pankaj Jangra
2012-09-26 18:18 ` Stephen Boyd
2012-09-26 18:18 ` Stephen Boyd
2012-09-26 18:54 ` Pankaj Jangra
2012-09-26 18:54 ` Pankaj Jangra
2012-09-21 2:26 ` [PATCH 08/10] ARM: msm: Prepare clk_get() users in mach-msm for clock-pcom driver Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-26 17:35 ` Pankaj Jangra
2012-09-26 17:35 ` Pankaj Jangra
2012-09-26 18:14 ` Stephen Boyd [this message]
2012-09-26 18:14 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 09/10] ARM: msm: Make proc_comm clock control into a platform driver Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-26 18:03 ` Pankaj Jangra
2012-09-26 18:03 ` Pankaj Jangra
2012-09-26 18:36 ` Stephen Boyd
2012-09-26 18:36 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 10/10] ARM: msm: Migrate to common clock framework Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-21 2:26 ` Stephen Boyd
2012-09-26 18:47 ` Pankaj Jangra
2012-09-26 18:47 ` Pankaj Jangra
2012-09-26 18:50 ` Stephen Boyd
2012-09-26 18:50 ` Stephen Boyd
2012-09-26 18:57 ` Pankaj Jangra
2012-09-26 18:57 ` Pankaj Jangra
2012-09-22 1:10 ` [PATCH 00/10] Convert MSM " Mike Turquette
2012-09-22 1:10 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506345FD.8010609@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=jangra.pankaj9@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.