All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Yuanhan Liu <yuanhan.liu@intel.com>,
	kernel-janitors@vger.kernel.org, kvm@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH] s390/kvm: Fix vcpu_load handling in interrupt code
Date: Thu, 27 Sep 2012 16:20:01 +0000	[thread overview]
Message-ID: <50647CB1.9080507@redhat.com> (raw)
In-Reply-To: <1348759785-15394-1-git-send-email-borntraeger@de.ibm.com>

On 09/27/2012 05:29 PM, Christian Borntraeger wrote:
> Recent changes (KVM: make processes waiting on vcpu mutex killable)
> now requires to check the return value of vcpu_load. This triggered
> a warning in s390 specific kvm code. Turns out that we can actually
> remove the put/load, since schedule will do the right thing via
> the preempt notifiers.

Thanks, applied.


-- 
error compiling committee.c: too many arguments to function

WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Yuanhan Liu <yuanhan.liu@intel.com>,
	kernel-janitors@vger.kernel.org, kvm@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH] s390/kvm: Fix vcpu_load handling in interrupt code
Date: Thu, 27 Sep 2012 18:20:01 +0200	[thread overview]
Message-ID: <50647CB1.9080507@redhat.com> (raw)
In-Reply-To: <1348759785-15394-1-git-send-email-borntraeger@de.ibm.com>

On 09/27/2012 05:29 PM, Christian Borntraeger wrote:
> Recent changes (KVM: make processes waiting on vcpu mutex killable)
> now requires to check the return value of vcpu_load. This triggered
> a warning in s390 specific kvm code. Turns out that we can actually
> remove the put/load, since schedule will do the right thing via
> the preempt notifiers.

Thanks, applied.


-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2012-09-27 16:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20  0:16 [kvm:queue 41/42] arch/s390/kvm/interrupt.c:428:12: warning: ignoring return value of 'vcpu_load', d Fengguang Wu
2012-09-20  0:16 ` [kvm:queue 41/42] arch/s390/kvm/interrupt.c:428:12: warning: ignoring return value of 'vcpu_load', declared with attribute warn_unused_result Fengguang Wu
2012-09-20  5:22 ` [kvm:queue 41/42] arch/s390/kvm/interrupt.c:428:12: warning: ignoring return value of 'vcpu_load Michael S. Tsirkin
2012-09-20  5:22   ` [kvm:queue 41/42] arch/s390/kvm/interrupt.c:428:12: warning: ignoring return value of 'vcpu_load', declared with attribute warn_unused_result Michael S. Tsirkin
2012-09-27 15:02   ` [kvm:queue 41/42] arch/s390/kvm/interrupt.c:428:12: warning: ignoring return value of 'vcpu_load Christian Borntraeger
2012-09-27 15:02     ` [kvm:queue 41/42] arch/s390/kvm/interrupt.c:428:12: warning: ignoring return value of 'vcpu_load', declared with attribute warn_unused_result Christian Borntraeger
2012-09-27 15:12     ` [kvm:queue 41/42] arch/s390/kvm/interrupt.c:428:12: warning: ignoring return value of 'vcpu_load Avi Kivity
2012-09-27 15:12       ` [kvm:queue 41/42] arch/s390/kvm/interrupt.c:428:12: warning: ignoring return value of 'vcpu_load', declared with attribute warn_unused_result Avi Kivity
2012-09-27 15:29       ` [PATCH] s390/kvm: Fix vcpu_load handling in interrupt code Christian Borntraeger
2012-09-27 15:29         ` Christian Borntraeger
2012-09-27 16:20         ` Avi Kivity [this message]
2012-09-27 16:20           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50647CB1.9080507@redhat.com \
    --to=avi@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=fengguang.wu@intel.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=yuanhan.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.