* [PATCH 0/1] Fix imx258 variant on pinephone pro
@ 2026-01-18 21:46 ` Luis Garcia
0 siblings, 0 replies; 14+ messages in thread
From: Luis Garcia @ 2026-01-18 21:46 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree, linux-rockchip, linux-arm-kernel, Olivier Benjamin,
megi, Luis Garcia
imx258 had the driver updated a while back and it introduced
two variants, the imx258 and imx258-pdaf. The pinephone pro
is using the pdaf variant so this switches it to the correct
variant and eliminates the pdaf pixels from the sensor output
resulting in a much cleaner image.
Luis Garcia (1):
arm64: dts: rockchip: Fix imx258 variant on pinephone pro
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.50.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro
2026-01-18 21:46 ` Luis Garcia
@ 2026-01-18 21:46 ` Luis Garcia
-1 siblings, 0 replies; 14+ messages in thread
From: Luis Garcia @ 2026-01-18 21:46 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree, linux-rockchip, linux-arm-kernel, Olivier Benjamin,
megi, Luis Garcia
Fix the variant of the imx258 camera sensor on the pinephone pro
Signed-off-by: Luis Garcia <git@luigi311.com>
---
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 2dca1dca20b8..fd6facf1da2b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -451,7 +451,7 @@ &i2c1 {
status = "okay";
wcam: camera@1a {
- compatible = "sony,imx258";
+ compatible = "sony,imx258-pdaf";
reg = <0x1a>;
clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK0, derived from CIF_CLKO */
lens-focus = <&wcam_lens>;
--
2.50.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro
@ 2026-01-18 21:46 ` Luis Garcia
0 siblings, 0 replies; 14+ messages in thread
From: Luis Garcia @ 2026-01-18 21:46 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree, linux-rockchip, linux-arm-kernel, Olivier Benjamin,
megi, Luis Garcia
Fix the variant of the imx258 camera sensor on the pinephone pro
Signed-off-by: Luis Garcia <git@luigi311.com>
---
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 2dca1dca20b8..fd6facf1da2b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -451,7 +451,7 @@ &i2c1 {
status = "okay";
wcam: camera@1a {
- compatible = "sony,imx258";
+ compatible = "sony,imx258-pdaf";
reg = <0x1a>;
clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK0, derived from CIF_CLKO */
lens-focus = <&wcam_lens>;
--
2.50.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 0/1] Fix imx258 variant on pinephone pro
2026-01-18 21:46 ` Luis Garcia
@ 2026-01-18 22:19 ` Ondřej Jirman
-1 siblings, 0 replies; 14+ messages in thread
From: Ondřej Jirman @ 2026-01-18 22:19 UTC (permalink / raw)
To: Luis Garcia
Cc: Heiko Stuebner, devicetree, linux-rockchip, linux-arm-kernel,
Olivier Benjamin
Hi Luis,
On Sun, Jan 18, 2026 at 02:46:19PM -0700, Luis Garcia wrote:
> imx258 had the driver updated a while back and it introduced
> two variants, the imx258 and imx258-pdaf. The pinephone pro
> is using the pdaf variant so this switches it to the correct
> variant and eliminates the pdaf pixels from the sensor output
> resulting in a much cleaner image.
You don't need a cover letter for a single patch. Also this
description should be in the patch itself.
Thank you,
o.
> Luis Garcia (1):
> arm64: dts: rockchip: Fix imx258 variant on pinephone pro
>
> arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/1] Fix imx258 variant on pinephone pro
@ 2026-01-18 22:19 ` Ondřej Jirman
0 siblings, 0 replies; 14+ messages in thread
From: Ondřej Jirman @ 2026-01-18 22:19 UTC (permalink / raw)
To: Luis Garcia
Cc: Heiko Stuebner, devicetree, linux-rockchip, linux-arm-kernel,
Olivier Benjamin
Hi Luis,
On Sun, Jan 18, 2026 at 02:46:19PM -0700, Luis Garcia wrote:
> imx258 had the driver updated a while back and it introduced
> two variants, the imx258 and imx258-pdaf. The pinephone pro
> is using the pdaf variant so this switches it to the correct
> variant and eliminates the pdaf pixels from the sensor output
> resulting in a much cleaner image.
You don't need a cover letter for a single patch. Also this
description should be in the patch itself.
Thank you,
o.
> Luis Garcia (1):
> arm64: dts: rockchip: Fix imx258 variant on pinephone pro
>
> arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.50.1
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2] arm64: dts: rockchip: Fix imx258 variant on pinephone pro
2026-01-18 21:46 ` Luis Garcia
@ 2026-01-19 1:06 ` Luis Garcia
-1 siblings, 0 replies; 14+ messages in thread
From: Luis Garcia @ 2026-01-19 1:06 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree, linux-rockchip, linux-arm-kernel, Olivier Benjamin,
megi, Luis Garcia
imx258 had the driver updated a while back and it introduced
two variants, the imx258 and imx258-pdaf. The pinephone pro
is using the pdaf variant so this switches it to the correct
variant and eliminates the pdaf pixels from the sensor output
resulting in a much cleaner image.
Signed-off-by: Luis Garcia <git@luigi311.com>
---
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 2dca1dca20b8..fd6facf1da2b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -451,7 +451,7 @@ &i2c1 {
status = "okay";
wcam: camera@1a {
- compatible = "sony,imx258";
+ compatible = "sony,imx258-pdaf";
reg = <0x1a>;
clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK0, derived from CIF_CLKO */
lens-focus = <&wcam_lens>;
--
2.50.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2] arm64: dts: rockchip: Fix imx258 variant on pinephone pro
@ 2026-01-19 1:06 ` Luis Garcia
0 siblings, 0 replies; 14+ messages in thread
From: Luis Garcia @ 2026-01-19 1:06 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree, linux-rockchip, linux-arm-kernel, Olivier Benjamin,
megi, Luis Garcia
imx258 had the driver updated a while back and it introduced
two variants, the imx258 and imx258-pdaf. The pinephone pro
is using the pdaf variant so this switches it to the correct
variant and eliminates the pdaf pixels from the sensor output
resulting in a much cleaner image.
Signed-off-by: Luis Garcia <git@luigi311.com>
---
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 2dca1dca20b8..fd6facf1da2b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -451,7 +451,7 @@ &i2c1 {
status = "okay";
wcam: camera@1a {
- compatible = "sony,imx258";
+ compatible = "sony,imx258-pdaf";
reg = <0x1a>;
clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK0, derived from CIF_CLKO */
lens-focus = <&wcam_lens>;
--
2.50.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 0/1] Fix imx258 variant on pinephone pro
2026-01-18 21:46 ` Luis Garcia
@ 2026-01-20 9:39 ` Heiko Stuebner
-1 siblings, 0 replies; 14+ messages in thread
From: Heiko Stuebner @ 2026-01-20 9:39 UTC (permalink / raw)
To: Luis Garcia
Cc: Heiko Stuebner, devicetree, linux-rockchip, linux-arm-kernel,
Olivier Benjamin, megi
On Sun, 18 Jan 2026 14:46:19 -0700, Luis Garcia wrote:
> imx258 had the driver updated a while back and it introduced
> two variants, the imx258 and imx258-pdaf. The pinephone pro
> is using the pdaf variant so this switches it to the correct
> variant and eliminates the pdaf pixels from the sensor output
> resulting in a much cleaner image.
>
> Luis Garcia (1):
> arm64: dts: rockchip: Fix imx258 variant on pinephone pro
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro
commit: 6742b998166485558ccb0e89b5d5fd93c1aae3ca
In the future, please don't send v2 patches as replies to the
previous version and instead start a new thread.
Next versions as replies, does sometimes confusing tooling.
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 0/1] Fix imx258 variant on pinephone pro
@ 2026-01-20 9:39 ` Heiko Stuebner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stuebner @ 2026-01-20 9:39 UTC (permalink / raw)
To: Luis Garcia
Cc: Heiko Stuebner, devicetree, linux-rockchip, linux-arm-kernel,
Olivier Benjamin, megi
On Sun, 18 Jan 2026 14:46:19 -0700, Luis Garcia wrote:
> imx258 had the driver updated a while back and it introduced
> two variants, the imx258 and imx258-pdaf. The pinephone pro
> is using the pdaf variant so this switches it to the correct
> variant and eliminates the pdaf pixels from the sensor output
> resulting in a much cleaner image.
>
> Luis Garcia (1):
> arm64: dts: rockchip: Fix imx258 variant on pinephone pro
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro
commit: 6742b998166485558ccb0e89b5d5fd93c1aae3ca
In the future, please don't send v2 patches as replies to the
previous version and instead start a new thread.
Next versions as replies, does sometimes confusing tooling.
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 0/1] Fix imx258 variant on pinephone pro
2026-01-20 9:39 ` Heiko Stuebner
@ 2026-01-20 16:33 ` Luis Garcia
-1 siblings, 0 replies; 14+ messages in thread
From: Luis Garcia @ 2026-01-20 16:33 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree, linux-rockchip, linux-arm-kernel, Olivier Benjamin,
megi
Thank you very much for the speedy turn around. Ohh
interesting, here i was thinking i did the right thing with
the reply to with the V2. Ill keep that in mind for the
future but considering how far and few my contributions
upstream are i hope i dont forget by then lol.
On 1/20/26 02:39, Heiko Stuebner wrote:
> On Sun, 18 Jan 2026 14:46:19 -0700, Luis Garcia wrote:
>> imx258 had the driver updated a while back and it introduced
>> two variants, the imx258 and imx258-pdaf. The pinephone pro
>> is using the pdaf variant so this switches it to the correct
>> variant and eliminates the pdaf pixels from the sensor output
>> resulting in a much cleaner image.
>>
>> Luis Garcia (1):
>> arm64: dts: rockchip: Fix imx258 variant on pinephone pro
>>
>> [...]
> Applied, thanks!
>
> [1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro
> commit: 6742b998166485558ccb0e89b5d5fd93c1aae3ca
>
> In the future, please don't send v2 patches as replies to the
> previous version and instead start a new thread.
>
> Next versions as replies, does sometimes confusing tooling.
>
>
> Best regards,
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/1] Fix imx258 variant on pinephone pro
@ 2026-01-20 16:33 ` Luis Garcia
0 siblings, 0 replies; 14+ messages in thread
From: Luis Garcia @ 2026-01-20 16:33 UTC (permalink / raw)
To: Heiko Stuebner
Cc: devicetree, linux-rockchip, linux-arm-kernel, Olivier Benjamin,
megi
Thank you very much for the speedy turn around. Ohh
interesting, here i was thinking i did the right thing with
the reply to with the V2. Ill keep that in mind for the
future but considering how far and few my contributions
upstream are i hope i dont forget by then lol.
On 1/20/26 02:39, Heiko Stuebner wrote:
> On Sun, 18 Jan 2026 14:46:19 -0700, Luis Garcia wrote:
>> imx258 had the driver updated a while back and it introduced
>> two variants, the imx258 and imx258-pdaf. The pinephone pro
>> is using the pdaf variant so this switches it to the correct
>> variant and eliminates the pdaf pixels from the sensor output
>> resulting in a much cleaner image.
>>
>> Luis Garcia (1):
>> arm64: dts: rockchip: Fix imx258 variant on pinephone pro
>>
>> [...]
> Applied, thanks!
>
> [1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro
> commit: 6742b998166485558ccb0e89b5d5fd93c1aae3ca
>
> In the future, please don't send v2 patches as replies to the
> previous version and instead start a new thread.
>
> Next versions as replies, does sometimes confusing tooling.
>
>
> Best regards,
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/1] Fix imx258 variant on pinephone pro
2026-01-20 16:33 ` Luis Garcia
@ 2026-01-21 9:12 ` Heiko Stübner
-1 siblings, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2026-01-21 9:12 UTC (permalink / raw)
To: Luis Garcia
Cc: devicetree, linux-rockchip, linux-arm-kernel, Olivier Benjamin,
megi
Hi,
Am Dienstag, 20. Januar 2026, 17:33:37 Mitteleuropäische Normalzeit schrieb Luis Garcia:
> Thank you very much for the speedy turn around. Ohh
> interesting, here i was thinking i did the right thing with
> the reply to with the V2. Ill keep that in mind for the
> future but considering how far and few my contributions
> upstream are i hope i dont forget by then lol.
no worries. For individual patches this is mostly easy to figure out
and also recent versions of b4 handled this thread fine.
I think it's more a problem, once the thread goes deeper or multiple
patches are involved.
Heiko
> On 1/20/26 02:39, Heiko Stuebner wrote:
> > On Sun, 18 Jan 2026 14:46:19 -0700, Luis Garcia wrote:
> >> imx258 had the driver updated a while back and it introduced
> >> two variants, the imx258 and imx258-pdaf. The pinephone pro
> >> is using the pdaf variant so this switches it to the correct
> >> variant and eliminates the pdaf pixels from the sensor output
> >> resulting in a much cleaner image.
> >>
> >> Luis Garcia (1):
> >> arm64: dts: rockchip: Fix imx258 variant on pinephone pro
> >>
> >> [...]
> > Applied, thanks!
> >
> > [1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro
> > commit: 6742b998166485558ccb0e89b5d5fd93c1aae3ca
> >
> > In the future, please don't send v2 patches as replies to the
> > previous version and instead start a new thread.
> >
> > Next versions as replies, does sometimes confusing tooling.
> >
> >
> > Best regards,
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/1] Fix imx258 variant on pinephone pro
@ 2026-01-21 9:12 ` Heiko Stübner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stübner @ 2026-01-21 9:12 UTC (permalink / raw)
To: Luis Garcia
Cc: devicetree, linux-rockchip, linux-arm-kernel, Olivier Benjamin,
megi
Hi,
Am Dienstag, 20. Januar 2026, 17:33:37 Mitteleuropäische Normalzeit schrieb Luis Garcia:
> Thank you very much for the speedy turn around. Ohh
> interesting, here i was thinking i did the right thing with
> the reply to with the V2. Ill keep that in mind for the
> future but considering how far and few my contributions
> upstream are i hope i dont forget by then lol.
no worries. For individual patches this is mostly easy to figure out
and also recent versions of b4 handled this thread fine.
I think it's more a problem, once the thread goes deeper or multiple
patches are involved.
Heiko
> On 1/20/26 02:39, Heiko Stuebner wrote:
> > On Sun, 18 Jan 2026 14:46:19 -0700, Luis Garcia wrote:
> >> imx258 had the driver updated a while back and it introduced
> >> two variants, the imx258 and imx258-pdaf. The pinephone pro
> >> is using the pdaf variant so this switches it to the correct
> >> variant and eliminates the pdaf pixels from the sensor output
> >> resulting in a much cleaner image.
> >>
> >> Luis Garcia (1):
> >> arm64: dts: rockchip: Fix imx258 variant on pinephone pro
> >>
> >> [...]
> > Applied, thanks!
> >
> > [1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro
> > commit: 6742b998166485558ccb0e89b5d5fd93c1aae3ca
> >
> > In the future, please don't send v2 patches as replies to the
> > previous version and instead start a new thread.
> >
> > Next versions as replies, does sometimes confusing tooling.
> >
> >
> > Best regards,
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread