Re: [PATCH 2/3] Revert "spi/pl022: enable runtime PM"

[vipul kumar samar <vipulkumar.samar-qxv4g6HH51o@public.gmane.org>]

Hello ulf,

On 9/28/2012 4:51 PM, Ulf HANSSON wrote:
> From: Ulf Hansson<ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> This reverts commit 2fb30d1147c599f5657e8c62c862f9a0f58d9d99.
>
> Signed-off-by: Ulf Hansson<ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>   drivers/spi/spi-pl022.c |    4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index 3f2f36c..05cfb61e 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -2188,9 +2188,6 @@ pl022_probe(struct amba_device *adev, const struct amba_id *id)
>   	printk(KERN_INFO "pl022: mapped registers from 0x%08x to %p\n",
>   	       adev->res.start, pl022->virtbase);
>
> -	pm_runtime_enable(dev);
> -	pm_runtime_resume(dev);
> -
>   	pl022->clk = clk_get(&adev->dev, NULL);
>   	if (IS_ERR(pl022->clk)) {
>   		status = PTR_ERR(pl022->clk);
> @@ -2303,7 +2300,6 @@ pl022_remove(struct amba_device *adev)
>   	clk_disable(pl022->clk);
>   	clk_unprepare(pl022->clk);
>   	clk_put(pl022->clk);
> -	pm_runtime_disable(&adev->dev);
>   	iounmap(pl022->virtbase);
>   	amba_release_regions(adev);
>   	tasklet_disable(&pl022->pump_transfers);

sorry..Now i got it you revert complete rumtime patch.

Regards
Vipul Samar

------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html