From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] make GFP_NOTRACK flag unconditional
Date: Fri, 28 Sep 2012 18:29:03 +0400 [thread overview]
Message-ID: <5065B42F.5010007@parallels.com> (raw)
In-Reply-To: <0000013a0d475174-343e3b17-6755-42c1-9dae-a9287ad7d403-000000@email.amazonses.com>
On 09/28/2012 06:28 PM, Christoph Lameter wrote:
> On Fri, 28 Sep 2012, Glauber Costa wrote:
>
>> There was a general sentiment in a recent discussion (See
>> https://lkml.org/lkml/2012/9/18/258) that the __GFP flags should be
>> defined unconditionally. Currently, the only offender is GFP_NOTRACK,
>> which is conditional to KMEMCHECK.
>>
>> This simple patch makes it unconditional.
>
> __GFP_NOTRACK is only used in context where CONFIG_KMEMCHECK is defined?
>
> If that is not the case then you need to define GFP_NOTRACK and substitute
> it where necessary.
>
The flag is passed around extensively, but I was imagining the whole
point of that is that having the flag itself is harmless, and will be
ignored by the page allocator ?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] make GFP_NOTRACK flag unconditional
Date: Fri, 28 Sep 2012 18:29:03 +0400 [thread overview]
Message-ID: <5065B42F.5010007@parallels.com> (raw)
In-Reply-To: <0000013a0d475174-343e3b17-6755-42c1-9dae-a9287ad7d403-000000@email.amazonses.com>
On 09/28/2012 06:28 PM, Christoph Lameter wrote:
> On Fri, 28 Sep 2012, Glauber Costa wrote:
>
>> There was a general sentiment in a recent discussion (See
>> https://lkml.org/lkml/2012/9/18/258) that the __GFP flags should be
>> defined unconditionally. Currently, the only offender is GFP_NOTRACK,
>> which is conditional to KMEMCHECK.
>>
>> This simple patch makes it unconditional.
>
> __GFP_NOTRACK is only used in context where CONFIG_KMEMCHECK is defined?
>
> If that is not the case then you need to define GFP_NOTRACK and substitute
> it where necessary.
>
The flag is passed around extensively, but I was imagining the whole
point of that is that having the flag itself is harmless, and will be
ignored by the page allocator ?
next prev parent reply other threads:[~2012-09-28 14:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 9:56 [PATCH] make GFP_NOTRACK flag unconditional Glauber Costa
2012-09-28 9:56 ` Glauber Costa
2012-09-28 13:19 ` Mel Gorman
2012-09-28 13:19 ` Mel Gorman
2012-09-28 14:28 ` Christoph Lameter
2012-09-28 14:28 ` Christoph Lameter
2012-09-28 14:29 ` Glauber Costa [this message]
2012-09-28 14:29 ` Glauber Costa
2012-09-28 16:40 ` Christoph Lameter
2012-09-28 16:40 ` Christoph Lameter
2012-10-03 5:00 ` David Rientjes
2012-10-03 5:00 ` David Rientjes
2012-10-16 4:02 ` David Rientjes
2012-10-16 4:02 ` David Rientjes
2012-10-16 4:40 ` Andrew Morton
2012-10-16 4:40 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5065B42F.5010007@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.