All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.langsdorf@calxeda.com (Mark Langsdorf)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/12] ata: mark probe function as __devinit rather than __init
Date: Fri, 28 Sep 2012 16:38:02 -0500	[thread overview]
Message-ID: <506618BA.4070509@calxeda.com> (raw)
In-Reply-To: <1348868177-21205-3-git-send-email-arnd@arndb.de>

On 09/28/2012 04:36 PM, Arnd Bergmann wrote:
> Functions for hotplugging must be marked as __devinit so
> they do not get discarded, as pointed out by a build time
> warning from modpost.
> 
> Cc: Mark Langsdorf <mark.langsdorf@calxeda.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Jeff Garzik <jgarzik@redhat.com>
> ---
>  drivers/ata/sata_highbank.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
> index 0d7c4c2..36a141a 100644
> --- a/drivers/ata/sata_highbank.c
> +++ b/drivers/ata/sata_highbank.c
> @@ -260,7 +260,7 @@ static const struct of_device_id ahci_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, ahci_of_match);
>  
> -static int __init ahci_highbank_probe(struct platform_device *pdev)
> +static int __devinit ahci_highbank_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct ahci_host_priv *hpriv;

Thanks. I just ran into this today and couldn't figure out the error
message.

Acked-by: Mark Langsdorf <mark.langsdorf@calxeda.com>

--Mark Langsdorf
Calxeda, Inc.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Langsdorf <mark.langsdorf@calxeda.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"arm@kernel.org" <arm@kernel.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Jeff Garzik <jgarzik@redhat.com>
Subject: Re: [PATCH 02/12] ata: mark probe function as __devinit rather than __init
Date: Fri, 28 Sep 2012 16:38:02 -0500	[thread overview]
Message-ID: <506618BA.4070509@calxeda.com> (raw)
In-Reply-To: <1348868177-21205-3-git-send-email-arnd@arndb.de>

On 09/28/2012 04:36 PM, Arnd Bergmann wrote:
> Functions for hotplugging must be marked as __devinit so
> they do not get discarded, as pointed out by a build time
> warning from modpost.
> 
> Cc: Mark Langsdorf <mark.langsdorf@calxeda.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Jeff Garzik <jgarzik@redhat.com>
> ---
>  drivers/ata/sata_highbank.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
> index 0d7c4c2..36a141a 100644
> --- a/drivers/ata/sata_highbank.c
> +++ b/drivers/ata/sata_highbank.c
> @@ -260,7 +260,7 @@ static const struct of_device_id ahci_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, ahci_of_match);
>  
> -static int __init ahci_highbank_probe(struct platform_device *pdev)
> +static int __devinit ahci_highbank_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct ahci_host_priv *hpriv;

Thanks. I just ran into this today and couldn't figure out the error
message.

Acked-by: Mark Langsdorf <mark.langsdorf@calxeda.com>

--Mark Langsdorf
Calxeda, Inc.


  reply	other threads:[~2012-09-28 21:38 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28 21:36 [PATCH 00/12] New warnings and build errors in linux-next Arnd Bergmann
2012-09-28 21:36 ` Arnd Bergmann
2012-09-28 21:36 ` [PATCH 01/12] mtd: atmel nand: build regression Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-09-29 19:53   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-29 19:53     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 21:36 ` [PATCH 02/12] ata: mark probe function as __devinit rather than __init Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-09-28 21:38   ` Mark Langsdorf [this message]
2012-09-28 21:38     ` Mark Langsdorf
2012-09-28 21:36 ` [PATCH 03/12] mmc: dw_mmc: fix building exynos driver as a module Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-10-01 11:05   ` Will Newton
2012-10-01 11:05     ` Will Newton
2012-10-04 12:40     ` Seungwon Jeon
2012-10-04 12:40       ` Seungwon Jeon
2012-09-28 21:36 ` [PATCH 04/12] video: exynos: warnings in exynos_dp_core.c Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-10-05  8:01   ` Jingoo Han
2012-10-05  8:01     ` Jingoo Han
2012-10-05  8:16     ` Arnd Bergmann
2012-10-05  8:16       ` Arnd Bergmann
2012-09-28 21:36 ` [PATCH 05/12] ARM: ixp4xx: use __iomem for MMIO Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-09-29 10:35   ` ARM SoC tree, Was: " Krzysztof Halasa
2012-09-29 10:35     ` Krzysztof Halasa
2012-09-29 14:58     ` Arnd Bergmann
2012-09-29 14:58       ` Arnd Bergmann
2012-09-29 17:02       ` Krzysztof Halasa
2012-09-29 17:02         ` Krzysztof Halasa
2012-09-29 17:31         ` Olof Johansson
2012-09-29 17:31           ` Olof Johansson
2012-09-29 17:44         ` Russell King - ARM Linux
2012-09-29 17:44           ` Russell King - ARM Linux
2012-09-29 21:38           ` Krzysztof Halasa
2012-09-29 21:38             ` Krzysztof Halasa
2012-09-29 21:53             ` Russell King - ARM Linux
2012-09-29 21:53               ` Russell King - ARM Linux
2012-09-30 17:01               ` Krzysztof Halasa
2012-09-30 17:01                 ` Krzysztof Halasa
2012-09-28 21:36 ` [PATCH 06/12] sched: warnings in kernel/sched/fair.c Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-09-28 21:36 ` [PATCH 07/12] staging/iio/lis3l02dq: fix building without irq_to_gpio Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-09-29 10:02   ` Jonathan Cameron
2012-09-29 10:02     ` Jonathan Cameron
2012-09-29 15:03     ` Arnd Bergmann
2012-09-29 15:03       ` Arnd Bergmann
2012-10-13  9:54       ` Jonathan Cameron
2012-10-13  9:54         ` Jonathan Cameron
2012-09-28 21:36 ` [PATCH 08/12] dtc: be more quiet with "make -s" Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-09-28 21:55   ` Stephen Warren
2012-09-28 21:55     ` Stephen Warren
2012-09-29  7:27     ` Arnd Bergmann
2012-09-29  7:27       ` Arnd Bergmann
2012-09-28 21:36 ` [PATCH 09/12] tty/console: fix warnings in drivers/tty/serial/kgdboc.c Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-09-28 21:45   ` Jason Wessel
2012-09-28 21:45     ` Jason Wessel
2012-10-22 23:37     ` Greg Kroah-Hartman
2012-10-22 23:37       ` Greg Kroah-Hartman
2012-09-28 21:36 ` [PATCH 10/12] gpio: pcf857x: select IRQ_DOMAIN Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-09-30 21:39   ` Linus Walleij
2012-09-30 21:39     ` Linus Walleij
2012-09-28 21:36 ` [PATCH 11/12] pinctrl: samsung: use __devinit section for init code Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-10-01  6:15   ` Linus Walleij
2012-10-01  6:15     ` Linus Walleij
2012-10-02 11:52     ` Arnd Bergmann
2012-10-02 11:52       ` Arnd Bergmann
2012-10-02 12:57       ` Linus Walleij
2012-10-02 12:57         ` Linus Walleij
2012-10-02 20:28   ` Thierry Reding
2012-10-02 20:28     ` Thierry Reding
2012-09-28 21:36 ` [PATCH 12/12] time/jiffies: bring back unconditional LATCH definition Arnd Bergmann
2012-09-28 21:36   ` Arnd Bergmann
2012-09-28 21:55   ` John Stultz
2012-09-28 21:55     ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506618BA.4070509@calxeda.com \
    --to=mark.langsdorf@calxeda.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.