From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
b-cousson@ti.com, balbi@ti.com, santosh.shilimkar@ti.com,
dmitry.torokhov@gmail.com
Subject: Re: [PATCHv3 2/4] Input: keypad: Add smsc ece1099 keypad driver
Date: Mon, 01 Oct 2012 20:28:20 +0530 [thread overview]
Message-ID: <5069AF8C.2070807@ti.com> (raw)
In-Reply-To: <1349089310-22134-1-git-send-email-sourav.poddar@ti.com>
On Monday 01 October 2012 04:31 PM, Sourav Poddar wrote:
> +smsc_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct smsc *smsc = dev_get_drvdata(pdev->dev.parent);
> + struct input_dev *input;
> + struct smsc_keypad *kp;
> + int ret = 0, error;
> + int col, i, max_keys, row_shift;
> + int irq;
> + int addr;
> +
> + kp = devm_kzalloc(dev, sizeof(*kp), GFP_KERNEL);
> +
> + input = input_allocate_device();
> + if (!kp || !input) {
> + error = -ENOMEM;
> + goto err1;
> + }
> +
> + error = smsc_keypad_parse_dt(&pdev->dev, kp);
> + if (error)
> + return error;
>
Are we leaking input here?
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 2/4] Input: keypad: Add smsc ece1099 keypad driver
Date: Mon, 01 Oct 2012 20:28:20 +0530 [thread overview]
Message-ID: <5069AF8C.2070807@ti.com> (raw)
In-Reply-To: <1349089310-22134-1-git-send-email-sourav.poddar@ti.com>
On Monday 01 October 2012 04:31 PM, Sourav Poddar wrote:
> +smsc_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct smsc *smsc = dev_get_drvdata(pdev->dev.parent);
> + struct input_dev *input;
> + struct smsc_keypad *kp;
> + int ret = 0, error;
> + int col, i, max_keys, row_shift;
> + int irq;
> + int addr;
> +
> + kp = devm_kzalloc(dev, sizeof(*kp), GFP_KERNEL);
> +
> + input = input_allocate_device();
> + if (!kp || !input) {
> + error = -ENOMEM;
> + goto err1;
> + }
> +
> + error = smsc_keypad_parse_dt(&pdev->dev, kp);
> + if (error)
> + return error;
>
Are we leaking input here?
next prev parent reply other threads:[~2012-10-01 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 11:01 [PATCHv3 2/4] Input: keypad: Add smsc ece1099 keypad driver Sourav Poddar
2012-10-01 11:01 ` Sourav Poddar
2012-10-01 11:01 ` Sourav Poddar
2012-10-01 14:58 ` Shubhrajyoti [this message]
2012-10-01 14:58 ` Shubhrajyoti
2012-10-02 6:18 ` Dmitry Torokhov
2012-10-02 6:18 ` Dmitry Torokhov
2012-10-03 5:56 ` Poddar, Sourav
2012-10-03 5:56 ` Poddar, Sourav
2012-10-04 7:24 ` Dmitry Torokhov
2012-10-04 7:24 ` Dmitry Torokhov
2012-10-04 8:15 ` Sourav
2012-10-04 8:15 ` Sourav
2012-10-04 8:15 ` Sourav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5069AF8C.2070807@ti.com \
--to=shubhrajyoti@ti.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.