From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, sudhakar.raj@ti.com,
tony@atomide.com, nsekhar@ti.com,
davinci-linux-open-source@linux.davincidsp.com, "Hebbar,
Gururaja" <gururaja.hebbar@ti.com>,
lrg@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms
Date: Tue, 02 Oct 2012 10:48:53 +0300 [thread overview]
Message-ID: <506A9C65.5040309@ti.com> (raw)
In-Reply-To: <20120922153313.GN4495@opensource.wolfsonmicro.com>
On 09/22/2012 06:33 PM, Mark Brown wrote:
> On Fri, Aug 31, 2012 at 06:20:58PM +0530, Hebbar, Gururaja wrote:
>
>> +config SND_DAVINCI_HAVE_SRAM
>> + bool
>> + default y if ARCH_DAVINCI=y
>> + default n if ARCH_OMAP=y
>> +
>
> I've been sitting on this mostly since it seems like a step back from
> multi-platform kernels (which is where we're trying to get to) and I've
> been trying to decide what the best approach is. I'm thinking that we
> do want a generic API for allocating this stuff, it's a fairly generic
> feature (there's TCMs as well).
>
> Adding ifdefs like this does just doesn't seem good.
I also agree that ifdef is not a good solution.
It is better to have this information passed as device_data and via DT it can
be decided based on the compatible property for the device.
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms
Date: Tue, 02 Oct 2012 10:48:53 +0300 [thread overview]
Message-ID: <506A9C65.5040309@ti.com> (raw)
In-Reply-To: <20120922153313.GN4495@opensource.wolfsonmicro.com>
On 09/22/2012 06:33 PM, Mark Brown wrote:
> On Fri, Aug 31, 2012 at 06:20:58PM +0530, Hebbar, Gururaja wrote:
>
>> +config SND_DAVINCI_HAVE_SRAM
>> + bool
>> + default y if ARCH_DAVINCI=y
>> + default n if ARCH_OMAP=y
>> +
>
> I've been sitting on this mostly since it seems like a step back from
> multi-platform kernels (which is where we're trying to get to) and I've
> been trying to decide what the best approach is. I'm thinking that we
> do want a generic API for allocating this stuff, it's a fairly generic
> feature (there's TCMs as well).
>
> Adding ifdefs like this does just doesn't seem good.
I also agree that ifdef is not a good solution.
It is better to have this information passed as device_data and via DT it can
be decided based on the compatible property for the device.
--
P?ter
next prev parent reply other threads:[~2012-10-02 7:47 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 12:50 [PATCH 0/3] ASoC: Davinci: McASP: add support new McASP IP Variant Hebbar, Gururaja
2012-08-31 12:50 ` Hebbar, Gururaja
2012-08-31 12:50 ` [PATCH 1/3] " Hebbar, Gururaja
2012-08-31 12:50 ` Hebbar, Gururaja
2012-09-01 0:44 ` Mark Brown
2012-09-01 0:44 ` Mark Brown
2012-09-03 6:57 ` Hebbar, Gururaja
2012-09-03 6:57 ` Hebbar, Gururaja
2012-09-05 4:01 ` Mark Brown
2012-09-05 4:01 ` Mark Brown
2012-08-31 12:50 ` [PATCH 2/3] ASoC: Davinci: pcm: add support for sram-support-less platforms Hebbar, Gururaja
2012-08-31 12:50 ` Hebbar, Gururaja
2012-09-12 7:50 ` Hebbar, Gururaja
2012-09-12 7:50 ` Hebbar, Gururaja
2012-09-12 7:52 ` Mark Brown
2012-09-12 7:52 ` Mark Brown
2012-09-22 15:33 ` Mark Brown
2012-09-22 15:33 ` Mark Brown
2012-09-27 6:57 ` Hebbar, Gururaja
2012-09-27 6:57 ` Hebbar, Gururaja
[not found] ` <1BAFE6F6C881BF42822005164F1491C33EA92A1D-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2012-10-01 15:54 ` Mark Brown
2012-10-01 15:54 ` Mark Brown
2012-10-02 7:48 ` Peter Ujfalusi [this message]
2012-10-02 7:48 ` [alsa-devel] " Peter Ujfalusi
2012-10-02 9:37 ` Mark Brown
2012-10-02 9:37 ` [alsa-devel] " Mark Brown
2012-10-02 10:33 ` Daniel Mack
2012-10-02 10:33 ` [alsa-devel] " Daniel Mack
2012-10-02 11:06 ` Sekhar Nori
2012-10-02 11:06 ` Sekhar Nori
2012-10-02 13:42 ` Daniel Mack
2012-10-02 13:42 ` Daniel Mack
[not found] ` <506AEF57.2000306-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-02 16:41 ` Matt Porter
2012-10-02 16:41 ` Matt Porter
2012-10-02 16:50 ` Daniel Mack
2012-10-02 16:50 ` [alsa-devel] " Daniel Mack
[not found] ` <506B1B46.2070006-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-02 17:28 ` Matt Porter
2012-10-02 17:28 ` Matt Porter
2012-10-04 9:21 ` Daniel Mack
2012-10-04 9:21 ` [alsa-devel] " Daniel Mack
[not found] ` <506D552A.2000506-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-04 9:38 ` Porter, Matt
2012-10-04 9:38 ` Porter, Matt
2012-10-04 9:57 ` Daniel Mack
2012-10-04 9:57 ` [alsa-devel] " Daniel Mack
[not found] ` <506D5D8A.7030902-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-04 10:28 ` Matt Porter
2012-10-04 10:28 ` Matt Porter
2012-10-04 11:11 ` Daniel Mack
2012-10-04 11:11 ` [alsa-devel] " Daniel Mack
2012-10-02 16:30 ` Matt Porter
2012-10-02 16:30 ` Matt Porter
[not found] ` <506A9C65.5040309-l0cyMroinI0@public.gmane.org>
2012-10-02 16:28 ` Matt Porter
2012-10-02 16:28 ` Matt Porter
2012-10-02 8:37 ` Sekhar Nori
2012-10-02 8:37 ` Sekhar Nori
2012-08-31 12:50 ` [PATCH 3/3] ASoC: Davinci: evm: Fix typo in cpu dai name Hebbar, Gururaja
2012-08-31 12:50 ` Hebbar, Gururaja
2012-09-01 0:47 ` Mark Brown
2012-09-01 0:47 ` Mark Brown
2012-10-02 22:28 ` [alsa-devel] [PATCH 0/3] ASoC: Davinci: McASP: add support new McASP IP Variant Daniel Mack
2012-10-02 22:28 ` Daniel Mack
[not found] ` <506B6A9D.3090100-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-03 7:16 ` Hebbar, Gururaja
2012-10-03 7:16 ` Hebbar, Gururaja
2012-10-03 11:16 ` Daniel Mack
2012-10-03 11:16 ` [alsa-devel] " Daniel Mack
[not found] ` <506C1E97.1070700-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-03 12:57 ` Hebbar, Gururaja
2012-10-03 12:57 ` Hebbar, Gururaja
2012-10-03 14:07 ` Daniel Mack
2012-10-03 14:07 ` [alsa-devel] " Daniel Mack
[not found] ` <506C46AD.1090807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-04 19:50 ` Matt Porter
2012-10-04 19:50 ` Matt Porter
2012-11-25 10:26 ` Yegor Yefremov
2012-11-25 10:26 ` [alsa-devel] " Yegor Yefremov
2012-11-26 11:32 ` Hebbar, Gururaja
2012-11-26 11:32 ` [alsa-devel] " Hebbar, Gururaja
2012-11-26 11:35 ` Mark Brown
2012-11-26 11:35 ` [alsa-devel] " Mark Brown
[not found] ` <20121126113521.GD9411-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-11-26 11:42 ` Hebbar, Gururaja
2012-11-26 11:42 ` Hebbar, Gururaja
2012-11-26 11:57 ` Mark Brown
2012-11-26 11:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506A9C65.5040309@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=gururaja.hebbar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@ti.com \
--cc=nsekhar@ti.com \
--cc=sudhakar.raj@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.