From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, 21cnbao@gmail.com
Subject: Re: [PATCH] staging iio: use iio_trigger_generic_data_rdy_poll() in accel/adis16209 driver
Date: Wed, 03 Oct 2012 11:18:43 +0200 [thread overview]
Message-ID: <506C02F3.2050506@metafoo.de> (raw)
In-Reply-To: <1348877262-8593-1-git-send-email-pmeerw@pmeerw.net>
On 09/29/2012 02:07 AM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: 21cnbao@gmail.com
Looks good,
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/staging/iio/accel/adis16209_trigger.c | 11 +----------
> drivers/staging/iio/accel/adis16240_trigger.c | 11 +----------
> 2 files changed, 2 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209_trigger.c b/drivers/staging/iio/accel/adis16209_trigger.c
> index 2ad93dc..1122803 100644
> --- a/drivers/staging/iio/accel/adis16209_trigger.c
> +++ b/drivers/staging/iio/accel/adis16209_trigger.c
> @@ -8,15 +8,6 @@
> #include "adis16209.h"
>
> /**
> - * adis16209_data_rdy_trig_poll() the event handler for the data rdy trig
> - **/
> -static irqreturn_t adis16209_data_rdy_trig_poll(int irq, void *trig)
> -{
> - iio_trigger_poll(trig, iio_get_time_ns());
> - return IRQ_HANDLED;
> -}
> -
> -/**
> * adis16209_data_rdy_trigger_set_state() set datardy interrupt state
> **/
> static int adis16209_data_rdy_trigger_set_state(struct iio_trigger *trig,
> @@ -45,7 +36,7 @@ int adis16209_probe_trigger(struct iio_dev *indio_dev)
> }
>
> ret = request_irq(st->us->irq,
> - adis16209_data_rdy_trig_poll,
> + iio_trigger_generic_data_rdy_poll,
> IRQF_TRIGGER_RISING,
> "adis16209",
> st->trig);
> diff --git a/drivers/staging/iio/accel/adis16240_trigger.c b/drivers/staging/iio/accel/adis16240_trigger.c
> index fa90a22..f3caf09 100644
> --- a/drivers/staging/iio/accel/adis16240_trigger.c
> +++ b/drivers/staging/iio/accel/adis16240_trigger.c
> @@ -8,15 +8,6 @@
> #include "adis16240.h"
>
> /**
> - * adis16240_data_rdy_trig_poll() the event handler for the data rdy trig
> - **/
> -static irqreturn_t adis16240_data_rdy_trig_poll(int irq, void *trig)
> -{
> - iio_trigger_poll(trig, iio_get_time_ns());
> - return IRQ_HANDLED;
> -}
> -
> -/**
> * adis16240_data_rdy_trigger_set_state() set datardy interrupt state
> **/
> static int adis16240_data_rdy_trigger_set_state(struct iio_trigger *trig,
> @@ -45,7 +36,7 @@ int adis16240_probe_trigger(struct iio_dev *indio_dev)
> }
>
> ret = request_irq(st->us->irq,
> - adis16240_data_rdy_trig_poll,
> + iio_trigger_generic_data_rdy_poll,
> IRQF_TRIGGER_RISING,
> "adis16240",
> st->trig);
prev parent reply other threads:[~2012-10-03 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 0:07 [PATCH] staging iio: use iio_trigger_generic_data_rdy_poll() in accel/adis16209 driver Peter Meerwald
2012-10-03 9:18 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506C02F3.2050506@metafoo.de \
--to=lars@metafoo.de \
--cc=21cnbao@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.