From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Leela Krishna Amudala
<l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support
Date: Wed, 03 Oct 2012 09:27:31 -0600 [thread overview]
Message-ID: <506C5963.50902@wwwdotorg.org> (raw)
In-Reply-To: <CAL1wa8egdA=1iu8Jr-TQLnSweOQoCL=TD4cvo1BHHNn9UyOSEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 10/02/2012 10:06 PM, Leela Krishna Amudala wrote:
> On Mon, Oct 1, 2012 at 9:50 PM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
>> On 09/30/2012 11:29 PM, Leela Krishna Amudala wrote:
>>> Hello Stephen Warren,
>>>
>>> The binding names that I use in my dts file should match with the
>>> names given in http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html
>>> right?
>>
>> I don't think so; the binding in that link is for example:
>>
>>> + - xres, yres: Display resolution
>>> + - left-margin, right-margin, hsync-len: Horizontal Display timing parameters
>>> + in pixels
>>> + upper-margin, lower-margin, vsync-len: Vertical display timing parameters in
>>> + lines
>>> + - clock: displayclock in Hz
>>
>> i.e. a bunch of separate properties, one for each value needed to
>> describe the display timing. However, your patch contains:
>
> I mean to say that even I have to use separate properties for each one
> instead of grouping them.
> Also the names should match with the ones given in the example..?
Yes. The patch I pointed to isn't supposed to be just an example, but
/the/ standard way of representing display timings.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6 2/2] video: drm: exynos: Add device tree support
Date: Wed, 03 Oct 2012 09:27:31 -0600 [thread overview]
Message-ID: <506C5963.50902@wwwdotorg.org> (raw)
In-Reply-To: <CAL1wa8egdA=1iu8Jr-TQLnSweOQoCL=TD4cvo1BHHNn9UyOSEQ@mail.gmail.com>
On 10/02/2012 10:06 PM, Leela Krishna Amudala wrote:
> On Mon, Oct 1, 2012 at 9:50 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 09/30/2012 11:29 PM, Leela Krishna Amudala wrote:
>>> Hello Stephen Warren,
>>>
>>> The binding names that I use in my dts file should match with the
>>> names given in http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html
>>> right?
>>
>> I don't think so; the binding in that link is for example:
>>
>>> + - xres, yres: Display resolution
>>> + - left-margin, right-margin, hsync-len: Horizontal Display timing parameters
>>> + in pixels
>>> + upper-margin, lower-margin, vsync-len: Vertical display timing parameters in
>>> + lines
>>> + - clock: displayclock in Hz
>>
>> i.e. a bunch of separate properties, one for each value needed to
>> describe the display timing. However, your patch contains:
>
> I mean to say that even I have to use separate properties for each one
> instead of grouping them.
> Also the names should match with the ones given in the example..?
Yes. The patch I pointed to isn't supposed to be just an example, but
/the/ standard way of representing display timings.
next prev parent reply other threads:[~2012-10-03 15:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 11:22 [PATCH V6 0/2] video: drm: Add Device tree support to exynos DRM-FIMD Leela Krishna Amudala
2012-09-21 11:22 ` Leela Krishna Amudala
2012-09-21 11:22 ` [PATCH V6 1/2] drm/exynos: add platform_device_id table and driver data for drm fimd Leela Krishna Amudala
2012-09-21 11:22 ` Leela Krishna Amudala
2012-09-21 11:22 ` [PATCH V6 2/2] video: drm: exynos: Add device tree support Leela Krishna Amudala
2012-09-21 11:22 ` Leela Krishna Amudala
2012-09-21 5:14 ` Stephen Warren
2012-09-21 5:14 ` Stephen Warren
2012-09-21 7:22 ` Inki Dae
2012-09-21 7:22 ` Inki Dae
2012-09-21 16:06 ` Stephen Warren
2012-09-21 16:06 ` Stephen Warren
2012-09-24 12:35 ` Inki Dae
2012-09-24 12:35 ` Inki Dae
2012-09-25 13:03 ` Laurent Pinchart
2012-09-25 13:03 ` Laurent Pinchart
2012-09-25 15:03 ` Inki Dae
2012-09-25 15:03 ` Inki Dae
2012-09-25 15:31 ` Mark Brown
2012-09-25 15:31 ` Mark Brown
2012-09-26 4:32 ` Inki Dae
2012-09-26 4:32 ` Inki Dae
2012-10-01 5:29 ` Leela Krishna Amudala
2012-10-01 5:29 ` Leela Krishna Amudala
[not found] ` <CAL1wa8eOA6eV-9EoeUFrSFaFwq5sEVnYXn9yKnPRv=0mSU5WvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-01 16:20 ` Stephen Warren
2012-10-01 16:20 ` Stephen Warren
2012-10-03 4:06 ` Leela Krishna Amudala
2012-10-03 4:06 ` Leela Krishna Amudala
[not found] ` <CAL1wa8egdA=1iu8Jr-TQLnSweOQoCL=TD4cvo1BHHNn9UyOSEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-03 15:27 ` Stephen Warren [this message]
2012-10-03 15:27 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506C5963.50902@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.