Re: [Qemu-devel] [PATCH] qxl: Default to PCI revision 4 when spice-server is new enough

[Paolo Bonzini <pbonzini@redhat.com>]

Il 04/10/2012 19:31, Søren Sandmann ha scritto:
>> >
>> > No, that's not possible.  The revision must be the same for all machines
>> > started with the same "-M" argument.  So your only choice is to make
>> > 0.12 a requirement for QEMU 1.3.  Then you can use compatibility
>> > properties (see the long list of strings in hw/pc_piix.c) to ensure that
>> > pc-1.2 and earlier machines use the previous revision.
> Spice server 0.12 is already, so I'll send a patch to require that
> unconditionally. I'm assuming that later strings override earlier ones
> so that the revision=3 I added won't take effect for previous machines.

There is a PC_COMPAT_1_2 macro, just add the

        {\
            .driver   = "qxl-vga",\
            .property = "revision",\
            .value    = "3",\
        },{\
        {\
            .driver   = "qxl",\
            .property = "revision",\
            .value    = "3",\
        },{\

there.

Paolo