From: Mihai Lindner <mihaix.lindner@linux.intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: yocto@yoctoproject.org
Subject: Re: [PATCH 1/1] meta-tlk: fix ignored SRC_URI appends
Date: Fri, 05 Oct 2012 12:28:11 +0300 [thread overview]
Message-ID: <506EA82B.3070803@linux.intel.com> (raw)
In-Reply-To: <1594004.RBn6gvQsN0@helios>
On 2012-10-04 20:51, Paul Eggleton wrote:
> Hi Mihai,
>
> On Thursday 04 October 2012 20:47:08 Mihai Lindner wrote:
>> Fix SRC_URI appends ignored by meta-cedartrail and meta-crownbay. Used
>> SRC_URI_append instead of SRC_URI.
>> Also placed all variables in an .inc file to be required by all
>> linux-yocto recipes in here, since all versions use the same.
>>
>> [YOCTO #3217]
>>
>> Signed-off-by: Mihai Lindner <mihaix.lindner@linux.intel.com>
>> ---
>> meta-tlk/recipes-kernel/linux/linux-yocto.inc | 3 +++
>> meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend | 7 +------
>> meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend | 7 +------
>> meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend | 7 +------
>> 4 files changed, 6 insertions(+), 18 deletions(-)
>> create mode 100644 meta-tlk/recipes-kernel/linux/linux-yocto.inc
>>
>> diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto.inc
>> b/meta-tlk/recipes-kernel/linux/linux-yocto.inc new file mode 100644
>> index 0000000..96a3adf
>> --- /dev/null
>> +++ b/meta-tlk/recipes-kernel/linux/linux-yocto.inc
>> @@ -0,0 +1,3 @@
>> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>> +SRC_URI_append += "file://time-limited-kernel.cfg"
>
> You should use SRC_URI_append = " file://time-limited-kernel.cfg" (note leading
> space) here. Obviously what you have done does work, but we want to avoid
> _append += as it can be confusing.
>
> Cheers,
> Paul
>
Hi Paul,
Ok, good to know. I will resend.
I was trying to avoid spaces in values and += fitted the description.
Thanks,
--
Mihai Lindner
next prev parent reply other threads:[~2012-10-05 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 17:47 [PATCH 0/1] meta-tlk: fix ignored SRC_URI appends Mihai Lindner
2012-10-04 17:47 ` [PATCH 1/1] " Mihai Lindner
2012-10-04 17:51 ` Paul Eggleton
2012-10-05 9:28 ` Mihai Lindner [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-05 11:20 [PATCH 0/1] " Mihai Lindner
2012-10-05 11:20 ` [PATCH 1/1] " Mihai Lindner
2012-10-05 11:51 ` Richard Purdie
2012-10-05 12:51 ` Mihai Lindner
2012-10-05 12:52 ` Mihai Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506EA82B.3070803@linux.intel.com \
--to=mihaix.lindner@linux.intel.com \
--cc=paul.eggleton@linux.intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.