* [PATCH 0/1] meta-tlk: fix ignored SRC_URI appends
@ 2012-10-04 17:47 Mihai Lindner
2012-10-04 17:47 ` [PATCH 1/1] " Mihai Lindner
0 siblings, 1 reply; 8+ messages in thread
From: Mihai Lindner @ 2012-10-04 17:47 UTC (permalink / raw)
To: yocto
Fix SRC_URI appends ignored by meta-cedartrail and meta-crownbay. Used
SRC_URI_append instead of SRC_URI.
Also placed all variables in an .inc file to be required by all
linux-yocto recipes in here, since all versions use the same.
[YOCTO #3217]
Signed-off-by: Mihai Lindner <mihaix.lindner@linux.intel.com>
---
The following changes since commit c4a86a2ad5df3a94b47e394090f67f7e324b1483:
meta-crystalforest: Create a custom build Image recipe. (2012-10-03 23:56:13 -0500)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib mihai/bug3217
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=mihai/bug3217
Mihai Lindner (1):
meta-tlk: fix ignored SRC_URI appends
meta-tlk/recipes-kernel/linux/linux-yocto.inc | 3 +++
meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend | 7 +------
meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend | 7 +------
meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend | 7 +------
4 files changed, 6 insertions(+), 18 deletions(-)
create mode 100644 meta-tlk/recipes-kernel/linux/linux-yocto.inc
--
1.7.12
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] meta-tlk: fix ignored SRC_URI appends
2012-10-04 17:47 [PATCH 0/1] meta-tlk: fix ignored SRC_URI appends Mihai Lindner
@ 2012-10-04 17:47 ` Mihai Lindner
2012-10-04 17:51 ` Paul Eggleton
0 siblings, 1 reply; 8+ messages in thread
From: Mihai Lindner @ 2012-10-04 17:47 UTC (permalink / raw)
To: yocto
Fix SRC_URI appends ignored by meta-cedartrail and meta-crownbay. Used
SRC_URI_append instead of SRC_URI.
Also placed all variables in an .inc file to be required by all
linux-yocto recipes in here, since all versions use the same.
[YOCTO #3217]
Signed-off-by: Mihai Lindner <mihaix.lindner@linux.intel.com>
---
meta-tlk/recipes-kernel/linux/linux-yocto.inc | 3 +++
meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend | 7 +------
meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend | 7 +------
meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend | 7 +------
4 files changed, 6 insertions(+), 18 deletions(-)
create mode 100644 meta-tlk/recipes-kernel/linux/linux-yocto.inc
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto.inc b/meta-tlk/recipes-kernel/linux/linux-yocto.inc
new file mode 100644
index 0000000..96a3adf
--- /dev/null
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto.inc
@@ -0,0 +1,3 @@
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+SRC_URI_append += "file://time-limited-kernel.cfg"
+PR .= ".2"
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend b/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend
index 138cc21..bd54419 100644
--- a/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend
@@ -1,6 +1 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-# enable the time limited kernel configuration options
-SRC_URI += "file://time-limited-kernel.cfg"
-
-PR .= ".1"
+require ${PN}.inc
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend b/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend
index 138cc21..bd54419 100644
--- a/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend
@@ -1,6 +1 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-# enable the time limited kernel configuration options
-SRC_URI += "file://time-limited-kernel.cfg"
-
-PR .= ".1"
+require ${PN}.inc
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend b/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend
index 138cc21..bd54419 100644
--- a/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend
@@ -1,6 +1 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-# enable the time limited kernel configuration options
-SRC_URI += "file://time-limited-kernel.cfg"
-
-PR .= ".1"
+require ${PN}.inc
--
1.7.12
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] meta-tlk: fix ignored SRC_URI appends
2012-10-04 17:47 ` [PATCH 1/1] " Mihai Lindner
@ 2012-10-04 17:51 ` Paul Eggleton
2012-10-05 9:28 ` Mihai Lindner
0 siblings, 1 reply; 8+ messages in thread
From: Paul Eggleton @ 2012-10-04 17:51 UTC (permalink / raw)
To: Mihai Lindner; +Cc: yocto
Hi Mihai,
On Thursday 04 October 2012 20:47:08 Mihai Lindner wrote:
> Fix SRC_URI appends ignored by meta-cedartrail and meta-crownbay. Used
> SRC_URI_append instead of SRC_URI.
> Also placed all variables in an .inc file to be required by all
> linux-yocto recipes in here, since all versions use the same.
>
> [YOCTO #3217]
>
> Signed-off-by: Mihai Lindner <mihaix.lindner@linux.intel.com>
> ---
> meta-tlk/recipes-kernel/linux/linux-yocto.inc | 3 +++
> meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend | 7 +------
> meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend | 7 +------
> meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend | 7 +------
> 4 files changed, 6 insertions(+), 18 deletions(-)
> create mode 100644 meta-tlk/recipes-kernel/linux/linux-yocto.inc
>
> diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto.inc
> b/meta-tlk/recipes-kernel/linux/linux-yocto.inc new file mode 100644
> index 0000000..96a3adf
> --- /dev/null
> +++ b/meta-tlk/recipes-kernel/linux/linux-yocto.inc
> @@ -0,0 +1,3 @@
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +SRC_URI_append += "file://time-limited-kernel.cfg"
You should use SRC_URI_append = " file://time-limited-kernel.cfg" (note leading
space) here. Obviously what you have done does work, but we want to avoid
_append += as it can be confusing.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] meta-tlk: fix ignored SRC_URI appends
2012-10-04 17:51 ` Paul Eggleton
@ 2012-10-05 9:28 ` Mihai Lindner
0 siblings, 0 replies; 8+ messages in thread
From: Mihai Lindner @ 2012-10-05 9:28 UTC (permalink / raw)
To: Paul Eggleton; +Cc: yocto
On 2012-10-04 20:51, Paul Eggleton wrote:
> Hi Mihai,
>
> On Thursday 04 October 2012 20:47:08 Mihai Lindner wrote:
>> Fix SRC_URI appends ignored by meta-cedartrail and meta-crownbay. Used
>> SRC_URI_append instead of SRC_URI.
>> Also placed all variables in an .inc file to be required by all
>> linux-yocto recipes in here, since all versions use the same.
>>
>> [YOCTO #3217]
>>
>> Signed-off-by: Mihai Lindner <mihaix.lindner@linux.intel.com>
>> ---
>> meta-tlk/recipes-kernel/linux/linux-yocto.inc | 3 +++
>> meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend | 7 +------
>> meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend | 7 +------
>> meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend | 7 +------
>> 4 files changed, 6 insertions(+), 18 deletions(-)
>> create mode 100644 meta-tlk/recipes-kernel/linux/linux-yocto.inc
>>
>> diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto.inc
>> b/meta-tlk/recipes-kernel/linux/linux-yocto.inc new file mode 100644
>> index 0000000..96a3adf
>> --- /dev/null
>> +++ b/meta-tlk/recipes-kernel/linux/linux-yocto.inc
>> @@ -0,0 +1,3 @@
>> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>> +SRC_URI_append += "file://time-limited-kernel.cfg"
>
> You should use SRC_URI_append = " file://time-limited-kernel.cfg" (note leading
> space) here. Obviously what you have done does work, but we want to avoid
> _append += as it can be confusing.
>
> Cheers,
> Paul
>
Hi Paul,
Ok, good to know. I will resend.
I was trying to avoid spaces in values and += fitted the description.
Thanks,
--
Mihai Lindner
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/1] meta-tlk: fix ignored SRC_URI appends
@ 2012-10-05 11:20 Mihai Lindner
2012-10-05 11:20 ` [PATCH 1/1] " Mihai Lindner
0 siblings, 1 reply; 8+ messages in thread
From: Mihai Lindner @ 2012-10-05 11:20 UTC (permalink / raw)
To: yocto
Fix SRC_URI appends ignored by meta-cedartrail and meta-crownbay. Used
SRC_URI_append instead of SRC_URI.
Also placed all variables in an .inc file to be required by all
linux-yocto recipes in here, since all versions use the same.
[YOCTO #3217]
Signed-off-by: Mihai Lindner <mihaix.lindner@linux.intel.com>
---
The following changes since commit 6eea475e2038c1de3fbbd5bcd0986862ff85bb9a:
meta-crownbay: remove 3.0 kernel support (2012-10-04 20:20:52 -0500)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib mihai/bug3217
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=mihai/bug3217
Mihai Lindner (1):
meta-tlk: fix ignored SRC_URI appends
meta-tlk/recipes-kernel/linux/linux-yocto.inc | 3 +++
meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend | 7 +------
meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend | 7 +------
meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend | 7 +------
4 files changed, 6 insertions(+), 18 deletions(-)
create mode 100644 meta-tlk/recipes-kernel/linux/linux-yocto.inc
--
1.7.12
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] meta-tlk: fix ignored SRC_URI appends
2012-10-05 11:20 [PATCH 0/1] " Mihai Lindner
@ 2012-10-05 11:20 ` Mihai Lindner
2012-10-05 11:51 ` Richard Purdie
0 siblings, 1 reply; 8+ messages in thread
From: Mihai Lindner @ 2012-10-05 11:20 UTC (permalink / raw)
To: yocto
Fix SRC_URI appends ignored by meta-cedartrail and meta-crownbay. Used
SRC_URI_append instead of SRC_URI.
Also placed all variables in an .inc file to be required by all
linux-yocto recipes in here, since all versions use the same.
[YOCTO #3217]
Signed-off-by: Mihai Lindner <mihaix.lindner@linux.intel.com>
---
meta-tlk/recipes-kernel/linux/linux-yocto.inc | 3 +++
meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend | 7 +------
meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend | 7 +------
meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend | 7 +------
4 files changed, 6 insertions(+), 18 deletions(-)
create mode 100644 meta-tlk/recipes-kernel/linux/linux-yocto.inc
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto.inc b/meta-tlk/recipes-kernel/linux/linux-yocto.inc
new file mode 100644
index 0000000..b1cf883
--- /dev/null
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto.inc
@@ -0,0 +1,3 @@
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+SRC_URI_append = " file://time-limited-kernel.cfg"
+PR .= ".2"
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend b/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend
index 138cc21..bd54419 100644
--- a/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend
@@ -1,6 +1 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-# enable the time limited kernel configuration options
-SRC_URI += "file://time-limited-kernel.cfg"
-
-PR .= ".1"
+require ${PN}.inc
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend b/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend
index 138cc21..bd54419 100644
--- a/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend
@@ -1,6 +1 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-# enable the time limited kernel configuration options
-SRC_URI += "file://time-limited-kernel.cfg"
-
-PR .= ".1"
+require ${PN}.inc
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend b/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend
index 138cc21..bd54419 100644
--- a/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend
@@ -1,6 +1 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-# enable the time limited kernel configuration options
-SRC_URI += "file://time-limited-kernel.cfg"
-
-PR .= ".1"
+require ${PN}.inc
--
1.7.12
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] meta-tlk: fix ignored SRC_URI appends
2012-10-05 11:20 ` [PATCH 1/1] " Mihai Lindner
@ 2012-10-05 11:51 ` Richard Purdie
2012-10-05 12:51 ` Mihai Lindner
2012-10-05 12:52 ` Mihai Lindner
0 siblings, 2 replies; 8+ messages in thread
From: Richard Purdie @ 2012-10-05 11:51 UTC (permalink / raw)
To: Mihai Lindner; +Cc: yocto
On Fri, 2012-10-05 at 14:20 +0300, Mihai Lindner wrote:
> Fix SRC_URI appends ignored by meta-cedartrail and meta-crownbay. Used
> SRC_URI_append instead of SRC_URI.
> Also placed all variables in an .inc file to be required by all
> linux-yocto recipes in here, since all versions use the same.
>
> [YOCTO #3217]
>
> Signed-off-by: Mihai Lindner <mihaix.lindner@linux.intel.com>
> ---
> meta-tlk/recipes-kernel/linux/linux-yocto.inc | 3 +++
Could you use a slightly less generic name for this include please? I
worry about collisions...
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] meta-tlk: fix ignored SRC_URI appends
2012-10-05 11:51 ` Richard Purdie
@ 2012-10-05 12:51 ` Mihai Lindner
2012-10-05 12:52 ` Mihai Lindner
1 sibling, 0 replies; 8+ messages in thread
From: Mihai Lindner @ 2012-10-05 12:51 UTC (permalink / raw)
To: yocto
Fix SRC_URI appends ignored by meta-cedartrail and meta-crownbay. Used
SRC_URI_append instead of SRC_URI.
Also placed all variables in an .inc file to be required by all
linux-yocto recipes in here, since all versions use the same.
[YOCTO #3217]
Signed-off-by: Mihai Lindner <mihaix.lindner@linux.intel.com>
---
meta-tlk/recipes-kernel/linux/linux-yocto-tlk.inc | 3 +++
meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend | 7 +------
meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend | 7 +------
meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend | 7 +------
4 files changed, 6 insertions(+), 18 deletions(-)
create mode 100644 meta-tlk/recipes-kernel/linux/linux-yocto-tlk.inc
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto-tlk.inc b/meta-tlk/recipes-kernel/linux/linux-yocto-tlk.inc
new file mode 100644
index 0000000..b1cf883
--- /dev/null
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto-tlk.inc
@@ -0,0 +1,3 @@
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+SRC_URI_append = " file://time-limited-kernel.cfg"
+PR .= ".2"
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend b/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend
index 138cc21..e316320 100644
--- a/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto_3.0.bbappend
@@ -1,6 +1 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-# enable the time limited kernel configuration options
-SRC_URI += "file://time-limited-kernel.cfg"
-
-PR .= ".1"
+require ${PN}-tlk.inc
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend b/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend
index 138cc21..e316320 100644
--- a/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto_3.2.bbappend
@@ -1,6 +1 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-# enable the time limited kernel configuration options
-SRC_URI += "file://time-limited-kernel.cfg"
-
-PR .= ".1"
+require ${PN}-tlk.inc
diff --git a/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend b/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend
index 138cc21..e316320 100644
--- a/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend
+++ b/meta-tlk/recipes-kernel/linux/linux-yocto_3.4.bbappend
@@ -1,6 +1 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-# enable the time limited kernel configuration options
-SRC_URI += "file://time-limited-kernel.cfg"
-
-PR .= ".1"
+require ${PN}-tlk.inc
--
1.7.12
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] meta-tlk: fix ignored SRC_URI appends
2012-10-05 11:51 ` Richard Purdie
2012-10-05 12:51 ` Mihai Lindner
@ 2012-10-05 12:52 ` Mihai Lindner
1 sibling, 0 replies; 8+ messages in thread
From: Mihai Lindner @ 2012-10-05 12:52 UTC (permalink / raw)
To: Richard Purdie; +Cc: yocto
On 2012-10-05 14:51, Richard Purdie wrote:
> On Fri, 2012-10-05 at 14:20 +0300, Mihai Lindner wrote:
>> Fix SRC_URI appends ignored by meta-cedartrail and meta-crownbay. Used
>> SRC_URI_append instead of SRC_URI.
>> Also placed all variables in an .inc file to be required by all
>> linux-yocto recipes in here, since all versions use the same.
>>
>> [YOCTO #3217]
>>
>> Signed-off-by: Mihai Lindner <mihaix.lindner@linux.intel.com>
>> ---
>> meta-tlk/recipes-kernel/linux/linux-yocto.inc | 3 +++
>
> Could you use a slightly less generic name for this include please? I
> worry about collisions...
>
> Cheers,
>
> Richard
>
>
>
>
Sure.
Thanks,
--
Mihai Lindner
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-10-05 12:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-04 17:47 [PATCH 0/1] meta-tlk: fix ignored SRC_URI appends Mihai Lindner
2012-10-04 17:47 ` [PATCH 1/1] " Mihai Lindner
2012-10-04 17:51 ` Paul Eggleton
2012-10-05 9:28 ` Mihai Lindner
-- strict thread matches above, loose matches on Subject: below --
2012-10-05 11:20 [PATCH 0/1] " Mihai Lindner
2012-10-05 11:20 ` [PATCH 1/1] " Mihai Lindner
2012-10-05 11:51 ` Richard Purdie
2012-10-05 12:51 ` Mihai Lindner
2012-10-05 12:52 ` Mihai Lindner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.