All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>,
	kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [input:next 43/45] drivers/input/keyboard/omap4-keypad.c:218:6: warning: unused variable 'error'
Date: Fri, 13 Jul 2012 20:47:58 +0000	[thread overview]
Message-ID: <5072230.2etiZPh4nE@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <20120713202305.GA26333@localhost>

On Saturday, July 14, 2012 04:23:05 AM Fengguang Wu wrote:
> Hi Sourav,
> 
> There are new compile warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
> head:   7545a8052565aa68eeb4dfb59c1fb5d21a6867e7
> commit: 3dad34659e6646ab578d82b75a023cc4640fe322 [43/45] Input: omap4-keypad
> - add device tree support
> 
> All warnings:
> 
> drivers/input/keyboard/omap4-keypad.c: In function 'omap4_keypad_parse_dt':
> drivers/input/keyboard/omap4-keypad.c:218:6: warning: unused variable
> 'error' [-Wunused-variable]
> 
> vim +218 drivers/input/keyboard/omap4-keypad.c
>    215						   struct omap4_keypad *keypad_data)
>    216	{
>    217		struct device_node *np = dev->of_node;
> 
>  > 218		int error;
> 
>    219
>    220		if (!np) {
>    221			dev_err(dev, "missing DT data");

Hmm, must be me; I'll zap it later tonight.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>,
	kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [input:next 43/45] drivers/input/keyboard/omap4-keypad.c:218:6: warning: unused variable 'error'
Date: Fri, 13 Jul 2012 13:47:58 -0700	[thread overview]
Message-ID: <5072230.2etiZPh4nE@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <20120713202305.GA26333@localhost>

On Saturday, July 14, 2012 04:23:05 AM Fengguang Wu wrote:
> Hi Sourav,
> 
> There are new compile warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
> head:   7545a8052565aa68eeb4dfb59c1fb5d21a6867e7
> commit: 3dad34659e6646ab578d82b75a023cc4640fe322 [43/45] Input: omap4-keypad
> - add device tree support
> 
> All warnings:
> 
> drivers/input/keyboard/omap4-keypad.c: In function 'omap4_keypad_parse_dt':
> drivers/input/keyboard/omap4-keypad.c:218:6: warning: unused variable
> 'error' [-Wunused-variable]
> 
> vim +218 drivers/input/keyboard/omap4-keypad.c
>    215						   struct omap4_keypad *keypad_data)
>    216	{
>    217		struct device_node *np = dev->of_node;
> 
>  > 218		int error;
> 
>    219
>    220		if (!np) {
>    221			dev_err(dev, "missing DT data");

Hmm, must be me; I'll zap it later tonight.

-- 
Dmitry

  reply	other threads:[~2012-07-13 20:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-13 20:23 [input:next 43/45] drivers/input/keyboard/omap4-keypad.c:218:6: warning: unused variable 'error' Fengguang Wu
2012-07-13 20:23 ` Fengguang Wu
2012-07-13 20:47 ` Dmitry Torokhov [this message]
2012-07-13 20:47   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5072230.2etiZPh4nE@dtor-d630.eng.vmware.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=sourav.poddar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.