All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: use module_i2c_driver to simplify the code
@ 2012-10-08 14:09 Wei Yongjun
  2012-10-09  7:51 ` Michael Hennerich
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-10-08 14:09 UTC (permalink / raw)
  To: michael.hennerich, sameo; +Cc: yongjun_wei, device-drivers-devel, linux-kernel

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Use the module_i2c_driver() macro to make the code smaller
and a bit simpler.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/mfd/adp5520.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
index ea8b947..94e7a6d 100644
--- a/drivers/mfd/adp5520.c
+++ b/drivers/mfd/adp5520.c
@@ -360,17 +360,7 @@ static struct i2c_driver adp5520_driver = {
 	.id_table 	= adp5520_id,
 };
 
-static int __init adp5520_init(void)
-{
-	return i2c_add_driver(&adp5520_driver);
-}
-module_init(adp5520_init);
-
-static void __exit adp5520_exit(void)
-{
-	i2c_del_driver(&adp5520_driver);
-}
-module_exit(adp5520_exit);
+module_i2c_driver(adp5520_driver);
 
 MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
 MODULE_DESCRIPTION("ADP5520(01) PMIC-MFD Driver");


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: use module_i2c_driver to simplify the code
  2012-10-08 14:09 [PATCH] mfd: use module_i2c_driver to simplify the code Wei Yongjun
@ 2012-10-09  7:51 ` Michael Hennerich
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Hennerich @ 2012-10-09  7:51 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: sameo@linux.intel.com, yongjun_wei@trendmicro.com.cn,
	device-drivers-devel@blackfin.uclinux.org,
	linux-kernel@vger.kernel.org

On 10/08/2012 04:09 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Use the module_i2c_driver() macro to make the code smaller
> and a bit simpler.
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
>   drivers/mfd/adp5520.c | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
> index ea8b947..94e7a6d 100644
> --- a/drivers/mfd/adp5520.c
> +++ b/drivers/mfd/adp5520.c
> @@ -360,17 +360,7 @@ static struct i2c_driver adp5520_driver = {
>   	.id_table 	= adp5520_id,
>   };
>   
> -static int __init adp5520_init(void)
> -{
> -	return i2c_add_driver(&adp5520_driver);
> -}
> -module_init(adp5520_init);
> -
> -static void __exit adp5520_exit(void)
> -{
> -	i2c_del_driver(&adp5520_driver);
> -}
> -module_exit(adp5520_exit);
> +module_i2c_driver(adp5520_driver);
>   
>   MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
>   MODULE_DESCRIPTION("ADP5520(01) PMIC-MFD Driver");
>
>


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-09  7:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-08 14:09 [PATCH] mfd: use module_i2c_driver to simplify the code Wei Yongjun
2012-10-09  7:51 ` Michael Hennerich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.