Re: [Qemu-devel] [PATCH 04/14] create_config: separate section for qemu_*dir variables (v2)

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

On 04/18/2012 01:55 PM, Eduardo Habkost wrote:
> The generic *dir section will eventually go away and be replaced with
> qemu_* section. By now, both sections will be kept, while the variables
> get renamed on config-host.mak.
> 
> With this patch, a XXXdir variable will become a CONFIG_QEMU_XXXDIR
> define, and a qemu_XXXdir variable will become CONFIG_QEMU_XXXDIR as
> well (instead of becoming a CONFIG_QEMU_QEMU_XXXDIR define).
> 
> Changes v1 -> v2:
>  - Rebase on top of newer qemu.git changes, that changed
>    "tr '[:lower:]' '[:upper:]'" to "LC_ALL=C tr '[a-z]' '[A-Z]'".
> 

> + qemu_*dir=*) # qemu-specific directory configuration
> +    name=${line%=*}

Bug.  You want ${line%%=*}, in case the value portion of this assignment
contains a second '=' character.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]