From: Don Slutz <Don@CloudSwitch.Com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: <qemu-devel@nongnu.org>, <jinsong.liu@intel.com>,
<kvm@vger.kernel.org>, <wei.y.yang@intel.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
<donald.d.dugger@intel.com>, <junjie.mao@intel.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [QEMU PATCH] i386: cpu: add missing CPUID[EAX=7, ECX=0] flag names
Date: Tue, 9 Oct 2012 12:43:52 -0400 [thread overview]
Message-ID: <50745448.2060501@CloudSwitch.Com> (raw)
In-Reply-To: <1349791439-15369-1-git-send-email-ehabkost@redhat.com>
On 10/09/12 10:03, Eduardo Habkost wrote:
> This makes QEMU recognize the following CPU flag names:
>
> Flags | Corresponding KVM kernel commit
> -----------------+----------------------------------------
> FSGSBASE | 176f61da82435eae09cc96f70b530d1ba0746b8b
> AVX2, BMI1, BMI2 | fb215366b3c7320ac25dca766a0152df16534932
> HLE, RTM | 83c529151ab0d4a813e3f6a3e293fff75d468519
> INVPCID | ad756a1603c5fac207758faaac7f01c34c9d0b7b
> ERMS | a01c8f9b4e266df1d7166d23216f2060648f862d
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/cpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index f3708e6..b012372 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -105,8 +105,8 @@ static const char *svm_feature_name[] = {
> };
>
> static const char *cpuid_7_0_ebx_feature_name[] = {
> - NULL, NULL, NULL, NULL, NULL, NULL, NULL, "smep",
> - NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> + "fsgsbase", NULL, NULL, "bmi1", "hle", "avx2", NULL, "smep",
> + "bmi2", "erms", "invpcid", "rtm", NULL, NULL, NULL, NULL,
> NULL, NULL, NULL, NULL, "smap", NULL, NULL, NULL,
> NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> };
Reviewed-by: Don Slutz <Don@CloudSwitch.com>
WARNING: multiple messages have this Message-ID (diff)
From: Don Slutz <Don@CloudSwitch.Com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: jinsong.liu@intel.com, kvm@vger.kernel.org, wei.y.yang@intel.com,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, donald.d.dugger@intel.com,
junjie.mao@intel.com, Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [QEMU PATCH] i386: cpu: add missing CPUID[EAX=7, ECX=0] flag names
Date: Tue, 9 Oct 2012 12:43:52 -0400 [thread overview]
Message-ID: <50745448.2060501@CloudSwitch.Com> (raw)
In-Reply-To: <1349791439-15369-1-git-send-email-ehabkost@redhat.com>
On 10/09/12 10:03, Eduardo Habkost wrote:
> This makes QEMU recognize the following CPU flag names:
>
> Flags | Corresponding KVM kernel commit
> -----------------+----------------------------------------
> FSGSBASE | 176f61da82435eae09cc96f70b530d1ba0746b8b
> AVX2, BMI1, BMI2 | fb215366b3c7320ac25dca766a0152df16534932
> HLE, RTM | 83c529151ab0d4a813e3f6a3e293fff75d468519
> INVPCID | ad756a1603c5fac207758faaac7f01c34c9d0b7b
> ERMS | a01c8f9b4e266df1d7166d23216f2060648f862d
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/cpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index f3708e6..b012372 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -105,8 +105,8 @@ static const char *svm_feature_name[] = {
> };
>
> static const char *cpuid_7_0_ebx_feature_name[] = {
> - NULL, NULL, NULL, NULL, NULL, NULL, NULL, "smep",
> - NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> + "fsgsbase", NULL, NULL, "bmi1", "hle", "avx2", NULL, "smep",
> + "bmi2", "erms", "invpcid", "rtm", NULL, NULL, NULL, NULL,
> NULL, NULL, NULL, NULL, "smap", NULL, NULL, NULL,
> NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> };
Reviewed-by: Don Slutz <Don@CloudSwitch.com>
next prev parent reply other threads:[~2012-10-09 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 14:03 [QEMU PATCH] i386: cpu: add missing CPUID[EAX=7,ECX=0] flag names Eduardo Habkost
2012-10-09 14:03 ` [Qemu-devel] [QEMU PATCH] i386: cpu: add missing CPUID[EAX=7, ECX=0] " Eduardo Habkost
2012-10-09 16:43 ` Don Slutz [this message]
2012-10-09 16:43 ` Don Slutz
2012-10-26 19:40 ` Marcelo Tosatti
2012-10-26 19:40 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50745448.2060501@CloudSwitch.Com \
--to=don@cloudswitch.com \
--cc=donald.d.dugger@intel.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jinsong.liu@intel.com \
--cc=junjie.mao@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei.y.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.