From: John Stultz <johnstul@us.ibm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] time: cast ->raw_interval to u64 to avoid shift overflow
Date: Tue, 09 Oct 2012 19:14:03 +0000 [thread overview]
Message-ID: <5074777B.9070907@us.ibm.com> (raw)
In-Reply-To: <20121009071823.GA19159@elgon.mountain>
On 10/09/2012 12:18 AM, Dan Carpenter wrote:
> We fixed a bunch of integer overflows in timekeeping code during the 3.6
> cycle. I did an audit based on that and found this potential overflow.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Yep. Looks like this would trigger if you had NOZ idle for more then 4
seconds.
Thanks for the audit, and sending this in!
Thomas: Mind queuing this? Probably should be marked for stable too.
Acked-by: John Stultz <johnstul@us.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: John Stultz <johnstul@us.ibm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] time: cast ->raw_interval to u64 to avoid shift overflow
Date: Tue, 09 Oct 2012 12:14:03 -0700 [thread overview]
Message-ID: <5074777B.9070907@us.ibm.com> (raw)
In-Reply-To: <20121009071823.GA19159@elgon.mountain>
On 10/09/2012 12:18 AM, Dan Carpenter wrote:
> We fixed a bunch of integer overflows in timekeeping code during the 3.6
> cycle. I did an audit based on that and found this potential overflow.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Yep. Looks like this would trigger if you had NOZ idle for more then 4
seconds.
Thanks for the audit, and sending this in!
Thomas: Mind queuing this? Probably should be marked for stable too.
Acked-by: John Stultz <johnstul@us.ibm.com>
next prev parent reply other threads:[~2012-10-09 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 7:18 [patch] time: cast ->raw_interval to u64 to avoid shift overflow Dan Carpenter
2012-10-09 7:18 ` Dan Carpenter
2012-10-09 19:14 ` John Stultz [this message]
2012-10-09 19:14 ` John Stultz
2012-10-09 19:50 ` [tip:timers/core] timekeeping: Cast raw_interval " tip-bot for Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5074777B.9070907@us.ibm.com \
--to=johnstul@us.ibm.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.