* [PATCH] kexec: fix Makefile.in binaries_arch
@ 2012-10-10 0:35 Tony Jones
2012-10-10 3:33 ` Khalid Aziz
0 siblings, 1 reply; 3+ messages in thread
From: Tony Jones @ 2012-10-10 0:35 UTC (permalink / raw)
To: kexec; +Cc: Simon Horman
Definitions of BINARIES_ARCH in Makefile.in seems to have been broken since commit 0775c60eb.
Signed-off-by: Tony Jones <tonyj@suse.com>
---
diff --git a/Makefile.in b/Makefile.in
index ba2e638..97405a2 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -176,8 +176,8 @@ PSRCS:=$(foreach s, $(SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
PGSRCS:=$(foreach s, $(GENERATED_SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
MAN_PAGES:=$(KEXEC_MANPAGE) $(KDUMP_MANPAGE) $(VMCORE_DMESG_MANPAGE)
-BINARIES_i386:=$(KEXEC_TEST) $(KEXEC_TEST)
-BINARIES_x86_64:=$(KEXEC) $(KDUMP) $(BINARIES_$(ARCH))
+BINARIES_i386:=$(KEXEC_TEST)
+BINARIES_x86_64:=$(KEXEC_TEST)
BINARIES:=$(KEXEC) $(KDUMP) $(VMCORE_DMESG) $(BINARIES_$(ARCH))
TARGETS:=$(BINARIES) $(MAN_PAGES)
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kexec: fix Makefile.in binaries_arch
2012-10-10 0:35 [PATCH] kexec: fix Makefile.in binaries_arch Tony Jones
@ 2012-10-10 3:33 ` Khalid Aziz
2012-10-11 4:32 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Khalid Aziz @ 2012-10-10 3:33 UTC (permalink / raw)
To: Tony Jones; +Cc: Simon Horman, kexec
On Tue, 2012-10-09 at 17:35 -0700, Tony Jones wrote:
> Definitions of BINARIES_ARCH in Makefile.in seems to have been broken since commit 0775c60eb.
>
> Signed-off-by: Tony Jones <tonyj@suse.com>
> ---
>
> diff --git a/Makefile.in b/Makefile.in
> index ba2e638..97405a2 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -176,8 +176,8 @@ PSRCS:=$(foreach s, $(SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
> PGSRCS:=$(foreach s, $(GENERATED_SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
>
> MAN_PAGES:=$(KEXEC_MANPAGE) $(KDUMP_MANPAGE) $(VMCORE_DMESG_MANPAGE)
> -BINARIES_i386:=$(KEXEC_TEST) $(KEXEC_TEST)
> -BINARIES_x86_64:=$(KEXEC) $(KDUMP) $(BINARIES_$(ARCH))
> +BINARIES_i386:=$(KEXEC_TEST)
> +BINARIES_x86_64:=$(KEXEC_TEST)
> BINARIES:=$(KEXEC) $(KDUMP) $(VMCORE_DMESG) $(BINARIES_$(ARCH))
>
> TARGETS:=$(BINARIES) $(MAN_PAGES)
>
That looks like a much needed fix and clean up.
--
Khalid
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kexec: fix Makefile.in binaries_arch
2012-10-10 3:33 ` Khalid Aziz
@ 2012-10-11 4:32 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2012-10-11 4:32 UTC (permalink / raw)
To: Khalid Aziz; +Cc: Tony Jones, kexec
On Tue, Oct 09, 2012 at 09:33:56PM -0600, Khalid Aziz wrote:
> On Tue, 2012-10-09 at 17:35 -0700, Tony Jones wrote:
> > Definitions of BINARIES_ARCH in Makefile.in seems to have been broken since commit 0775c60eb.
> >
> > Signed-off-by: Tony Jones <tonyj@suse.com>
> > ---
> >
> > diff --git a/Makefile.in b/Makefile.in
> > index ba2e638..97405a2 100644
> > --- a/Makefile.in
> > +++ b/Makefile.in
> > @@ -176,8 +176,8 @@ PSRCS:=$(foreach s, $(SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
> > PGSRCS:=$(foreach s, $(GENERATED_SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
> >
> > MAN_PAGES:=$(KEXEC_MANPAGE) $(KDUMP_MANPAGE) $(VMCORE_DMESG_MANPAGE)
> > -BINARIES_i386:=$(KEXEC_TEST) $(KEXEC_TEST)
> > -BINARIES_x86_64:=$(KEXEC) $(KDUMP) $(BINARIES_$(ARCH))
> > +BINARIES_i386:=$(KEXEC_TEST)
> > +BINARIES_x86_64:=$(KEXEC_TEST)
> > BINARIES:=$(KEXEC) $(KDUMP) $(VMCORE_DMESG) $(BINARIES_$(ARCH))
> >
> > TARGETS:=$(BINARIES) $(MAN_PAGES)
> >
>
> That looks like a much needed fix and clean up.
Thanks, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-11 4:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-10 0:35 [PATCH] kexec: fix Makefile.in binaries_arch Tony Jones
2012-10-10 3:33 ` Khalid Aziz
2012-10-11 4:32 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.