From: Glauber Costa <glommer@parallels.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@xenotime.net>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
"David S. Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [patch for-linus] memcg, kmem: fix build error when CONFIG_INET is disabled
Date: Wed, 10 Oct 2012 12:56:26 +0400 [thread overview]
Message-ID: <5075383A.1000001@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210092325500.9528@chino.kir.corp.google.com>
On 10/10/2012 10:32 AM, David Rientjes wrote:
> Commit e1aab161e013 ("socket: initial cgroup code.") causes a build error
> when CONFIG_INET is disabled in Linus' tree:
>
unlikely that something that old would cause a build bug now, specially
that commit, that actually wraps things inside CONFIG_INET.
More likely caused by the recently merged
"memcg-cleanup-kmem-tcp-ifdefs.patch" in -mm by mhocko (CC'd)
As a matter of fact, I just tested, and it indeed start failing after
that patch.
Michal, since it is just a cleanup patch, I'd prefer just reverting if
you are okay with it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@xenotime.net>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
"David S. Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [patch for-linus] memcg, kmem: fix build error when CONFIG_INET is disabled
Date: Wed, 10 Oct 2012 12:56:26 +0400 [thread overview]
Message-ID: <5075383A.1000001@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210092325500.9528@chino.kir.corp.google.com>
On 10/10/2012 10:32 AM, David Rientjes wrote:
> Commit e1aab161e013 ("socket: initial cgroup code.") causes a build error
> when CONFIG_INET is disabled in Linus' tree:
>
unlikely that something that old would cause a build bug now, specially
that commit, that actually wraps things inside CONFIG_INET.
More likely caused by the recently merged
"memcg-cleanup-kmem-tcp-ifdefs.patch" in -mm by mhocko (CC'd)
As a matter of fact, I just tested, and it indeed start failing after
that patch.
Michal, since it is just a cleanup patch, I'd prefer just reverting if
you are okay with it.
next prev parent reply other threads:[~2012-10-10 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 6:32 [patch for-linus] memcg, kmem: fix build error when CONFIG_INET is disabled David Rientjes
2012-10-10 6:32 ` David Rientjes
2012-10-10 8:56 ` Glauber Costa [this message]
2012-10-10 8:56 ` Glauber Costa
2012-10-10 9:27 ` Michal Hocko
2012-10-10 9:27 ` Michal Hocko
2012-10-10 9:29 ` Glauber Costa
2012-10-10 9:29 ` Glauber Costa
2012-10-10 14:33 ` Fengguang Wu
2012-10-10 14:33 ` Fengguang Wu
2012-10-10 20:17 ` David Rientjes
2012-10-10 20:17 ` David Rientjes
2012-10-10 20:27 ` Glauber Costa
2012-10-10 20:27 ` Glauber Costa
2012-10-10 9:27 ` Michal Hocko
2012-10-10 9:27 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5075383A.1000001@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rdunlap@xenotime.net \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.