From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/13] clk: davinci - add PSC clock driver
Date: Wed, 10 Oct 2012 18:15:49 +0530 [thread overview]
Message-ID: <50756DFD.4070203@ti.com> (raw)
In-Reply-To: <50756B96.1070008@ti.com>
On 10/10/2012 6:05 PM, Sekhar Nori wrote:
>> +struct clk *clk_register_davinci_psc(struct device *dev, const char *name,
>> + const char *parent_name,
>> + struct clk_davinci_psc_data *psc_data,
>> + spinlock_t *lock)
>
> Why do you need the lock to be provided from outside of this file? You
> can initialize a lock for serializing writes to PSC registers within
> this file, no?
Looking again, it seems like the common clock framework defines an
"enable_lock" in drivers/clk/clk.c to serialize the clock enable/disable
calls. Unless I am missing something, this lock seems unnecessary.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: Murali Karicheri <m-karicheri2@ti.com>, <khilman@ti.com>,
<davinci-linux-open-source@linux.davincidsp.com>,
<mturquette@linaro.org>, <linux-c6x-dev@linux-c6x.org>,
<arnd@arndb.de>, <linus.walleij@linaro.org>,
<linux-kernel@vger.kernel.org>, <rob.herring@calxeda.com>,
<linux-keystone@list.ti.com>, <viresh.linux@gmail.com>,
<linux@arm.linux.org.uk>, <akpm@linux-foundation.org>,
<shawn.guo@linaro.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 02/13] clk: davinci - add PSC clock driver
Date: Wed, 10 Oct 2012 18:15:49 +0530 [thread overview]
Message-ID: <50756DFD.4070203@ti.com> (raw)
In-Reply-To: <50756B96.1070008@ti.com>
On 10/10/2012 6:05 PM, Sekhar Nori wrote:
>> +struct clk *clk_register_davinci_psc(struct device *dev, const char *name,
>> + const char *parent_name,
>> + struct clk_davinci_psc_data *psc_data,
>> + spinlock_t *lock)
>
> Why do you need the lock to be provided from outside of this file? You
> can initialize a lock for serializing writes to PSC registers within
> this file, no?
Looking again, it seems like the common clock framework defines an
"enable_lock" in drivers/clk/clk.c to serialize the clock enable/disable
calls. Unless I am missing something, this lock seems unnecessary.
Thanks,
Sekhar
next prev parent reply other threads:[~2012-10-10 12:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1348682889-9509-1-git-send-email-m-karicheri2@ti.com>
[not found] ` <1348682889-9509-2-git-send-email-m-karicheri2@ti.com>
2012-09-27 13:19 ` [PATCH 01/13] clk: davinci - add Main PLL clock driver Linus Walleij
2012-09-27 13:19 ` Linus Walleij
2012-09-28 20:12 ` [linux-keystone] " Karicheri, Muralidharan
2012-09-28 20:12 ` Karicheri, Muralidharan
2012-10-10 12:02 ` Sekhar Nori
2012-10-10 12:02 ` Sekhar Nori
2012-10-10 14:34 ` [PATCH 01/13] calk: " Karicheri, Muralidharan
2012-10-10 14:34 ` Karicheri, Muralidharan
2012-10-11 10:15 ` Sekhar Nori
2012-10-11 10:15 ` Sekhar Nori
2012-10-11 14:07 ` Karicheri, Muralidharan
2012-10-11 14:07 ` Karicheri, Muralidharan
2012-10-11 10:35 ` [PATCH 01/13] clk: " Sekhar Nori
2012-10-11 10:35 ` Sekhar Nori
2012-10-11 14:10 ` Karicheri, Muralidharan
2012-10-11 14:10 ` Karicheri, Muralidharan
[not found] ` <1348682889-9509-3-git-send-email-m-karicheri2@ti.com>
2012-10-10 12:35 ` [PATCH 02/13] clk: davinci - add PSC " Sekhar Nori
2012-10-10 12:35 ` Sekhar Nori
2012-10-10 12:45 ` Sekhar Nori [this message]
2012-10-10 12:45 ` Sekhar Nori
2012-10-10 14:19 ` Karicheri, Muralidharan
2012-10-10 14:19 ` Karicheri, Muralidharan
2012-10-10 14:35 ` Karicheri, Muralidharan
2012-10-10 14:35 ` Karicheri, Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50756DFD.4070203@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.