All of lore.kernel.org
 help / color / mirror / Atom feed
From: hs@denx.de (Heiko Schocher)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc
Date: Thu, 11 Oct 2012 08:35:47 +0200	[thread overview]
Message-ID: <507668C3.6080908@denx.de> (raw)
In-Reply-To: <A73F36158E33644199EB82C5EC81C7BC3E9CA495@DBDE01.ent.ti.com>

Hello Manjunathappa

On 11.10.2012 07:42, Manjunathappa, Prakash wrote:
> Hi,
> On Mon, Oct 08, 2012 at 18:47:07, Constantine Shulyupin wrote:
>> From: Constantine Shulyupin<const@MakeLinux.com>
>>
>> Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly
>> CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST
>> and set MUSB_OTG configuration by default
>> because this configuration options are removed from Kconfig.
>>
>> Signed-off-by: Constantine Shulyupin<const@MakeLinux.com>
>>
>> ---
>>   arch/arm/mach-davinci/usb.c |    6 ------
>>   1 file changed, 6 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c
>> index f77b953..34509ff 100644
>> --- a/arch/arm/mach-davinci/usb.c
>> +++ b/arch/arm/mach-davinci/usb.c
>> @@ -42,14 +42,8 @@ static struct musb_hdrc_config musb_config = {
>>   };
>>
>>   static struct musb_hdrc_platform_data usb_data = {
>> -#if defined(CONFIG_USB_MUSB_OTG)
>>   	/* OTG requires a Mini-AB connector */
>>   	.mode           = MUSB_OTG,
>> -#elif defined(CONFIG_USB_MUSB_PERIPHERAL)
>> -	.mode           = MUSB_PERIPHERAL,
>> -#elif defined(CONFIG_USB_MUSB_HOST)
>> -	.mode           = MUSB_HOST,
>> -#endif
>>   	.clock		= "usb",
>>   	.config		=&musb_config,
>>   };
>
> Tested it on DM6446-EVM for host mode with MSC thumb drive and gadget
> mode with g-ether. It works.
>
> Acked-by: Manjunathappa, Prakash<prakash.pm@ti.com>

I sent a similiar patch here:

http://comments.gmane.org/gmane.linux.usb.general/54512

If the issues, mentioned from Sergei for my patch, nullified I add my:

Acked-by: Heiko Schocher <hs@denx.de>

for this patch.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Schocher <hs@denx.de>
To: "Manjunathappa, Prakash" <prakash.pm@ti.com>
Cc: Constantine Shulyupin <const@MakeLinux.com>,
	"Nori, Sekhar" <nsekhar@ti.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"davinci-linux-open-source@linux.davincidsp.com" 
	<davinci-linux-open-source@linux.davincidsp.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Balbi, Felipe" <balbi@ti.com>,
	Sergei Shtylyov <sshtylyov@mvista.com>,
	Wolfgang Denk <wd@denx.de>
Subject: Re: RE: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc
Date: Thu, 11 Oct 2012 08:35:47 +0200	[thread overview]
Message-ID: <507668C3.6080908@denx.de> (raw)
In-Reply-To: <A73F36158E33644199EB82C5EC81C7BC3E9CA495@DBDE01.ent.ti.com>

Hello Manjunathappa

On 11.10.2012 07:42, Manjunathappa, Prakash wrote:
> Hi,
> On Mon, Oct 08, 2012 at 18:47:07, Constantine Shulyupin wrote:
>> From: Constantine Shulyupin<const@MakeLinux.com>
>>
>> Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly
>> CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST
>> and set MUSB_OTG configuration by default
>> because this configuration options are removed from Kconfig.
>>
>> Signed-off-by: Constantine Shulyupin<const@MakeLinux.com>
>>
>> ---
>>   arch/arm/mach-davinci/usb.c |    6 ------
>>   1 file changed, 6 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c
>> index f77b953..34509ff 100644
>> --- a/arch/arm/mach-davinci/usb.c
>> +++ b/arch/arm/mach-davinci/usb.c
>> @@ -42,14 +42,8 @@ static struct musb_hdrc_config musb_config = {
>>   };
>>
>>   static struct musb_hdrc_platform_data usb_data = {
>> -#if defined(CONFIG_USB_MUSB_OTG)
>>   	/* OTG requires a Mini-AB connector */
>>   	.mode           = MUSB_OTG,
>> -#elif defined(CONFIG_USB_MUSB_PERIPHERAL)
>> -	.mode           = MUSB_PERIPHERAL,
>> -#elif defined(CONFIG_USB_MUSB_HOST)
>> -	.mode           = MUSB_HOST,
>> -#endif
>>   	.clock		= "usb",
>>   	.config		=&musb_config,
>>   };
>
> Tested it on DM6446-EVM for host mode with MSC thumb drive and gadget
> mode with g-ether. It works.
>
> Acked-by: Manjunathappa, Prakash<prakash.pm@ti.com>

I sent a similiar patch here:

http://comments.gmane.org/gmane.linux.usb.general/54512

If the issues, mentioned from Sergei for my patch, nullified I add my:

Acked-by: Heiko Schocher <hs@denx.de>

for this patch.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2012-10-11  6:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08 13:17 [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc Constantine Shulyupin
2012-10-08 13:17 ` Constantine Shulyupin
2012-10-11  5:42 ` Manjunathappa, Prakash
2012-10-11  5:42   ` Manjunathappa, Prakash
2012-10-11  6:35   ` Heiko Schocher [this message]
2012-10-11  6:35     ` Heiko Schocher
2012-10-11  8:50     ` Sekhar Nori
2012-10-11  8:50       ` Sekhar Nori
2012-10-11 10:06       ` Constantine Shulyupin
2012-10-11 10:06         ` Constantine Shulyupin
2012-10-23 12:34 ` Sekhar Nori
2012-10-23 12:34   ` Sekhar Nori
2012-10-23 12:39   ` Felipe Balbi
2012-10-23 12:39     ` Felipe Balbi
2012-10-24 11:10     ` Sekhar Nori
2012-10-24 11:10       ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507668C3.6080908@denx.de \
    --to=hs@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.