All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: aliguori@us.ibm.com, juzhang@redhat.com, jan.kiszka@siemens.com,
	Jason Baron <jbaron@redhat.com>,
	qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com,
	yamahata@valinux.co.jp, alex.williamson@redhat.com,
	kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com,
	lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com,
	kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.
Date: Thu, 11 Oct 2012 16:54:53 +0200	[thread overview]
Message-ID: <5076DDBD.50903@redhat.com> (raw)
In-Reply-To: <20121011144656.GF8983@redhat.com>

Il 11/10/2012 16:46, Michael S. Tsirkin ha scritto:
> Yes. Reason I ask is because q35 is adding bridges by default now.
> Would it be possible to only add them if requested on command line by user
> instead?

Can you just use shpc or pcie hotplug on those bridges?

> I realize some guests expect devices at specific slots
> but this does not apply to bridges I think?
> 
> It would also be nice to add comments explaining why
> specific slots were selected e.g. /* BSD XYZ fails to boot unless ahci is at alow 2 */
> etc.
> 
> Also - will adding this code now mean that when adding bridges
> we'll need to add compatibility code in bios/qemu in the future?

It will need SSDT changes.  One ugliness of Jason's patch was that it
introduced a massive chain of 32*32 Ifs in the SSDT.  Changing it to use
LoadTable shouldn't be hard.  Then you can patch out the LoadTable (e.g.
_INI -> INI_) based on what QEMU tells you is a bridge or not.

Paolo

  reply	other threads:[~2012-10-11 15:29 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09  3:30 [Qemu-devel] [PATCH v2 00/21] q35 qemu support Jason Baron
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 01/21] blockdev: Introduce a default machine blockdev interface field, QEMUMachine->mach_if Jason Baron
2012-10-09  7:34   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 02/21] blockdev: Introduce IF_AHCI Jason Baron
2012-10-09  7:36   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 03/21] pci: pci capability must be in PCI space Jason Baron
2012-10-09  7:36   ` Paolo Bonzini
2012-10-13  8:29   ` Blue Swirl
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 04/21] pci: introduce pci_swizzle_map_irq_fn() for standardized interrupt pin swizzle Jason Baron
2012-10-09  7:39   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 06/21] pc: Move ioapic_init() from pc_piix.c to pc.c Jason Baron
2012-10-09  7:44   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 05/21] pc, pc_piix: split out pc nic initialization Jason Baron
2012-10-09  7:39   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 07/21] pc/piix_pci: factor out smram/pam logic Jason Baron
2012-10-09  7:47   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 08/21] pci_ids: add intel 82801BA pci-to-pci bridge id and PCI_CLASS_SERIAL_SMBUS Jason Baron
2012-10-09  7:48   ` Paolo Bonzini
2012-10-13  8:31   ` Blue Swirl
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 09/21] pci: Add class 0xc05 as 'SMBus' Jason Baron
2012-10-09  7:49   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 10/21] pcie: pass pcie window size to pcie_host_mmcfg_update() Jason Baron
2012-10-09  7:52   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 11/21] pcie: Convert PCIExpressHost to use the QOM Jason Baron
2012-10-09  7:52   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 12/21] q35: Introduce q35 pc based chipset emulator Jason Baron
2012-10-11 14:47   ` Michael S. Tsirkin
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 13/21] q35: Re-base q35 Jason Baron
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 14/21] q35: Suppress SMM BIOS initialization under KVM Jason Baron
2012-10-09  7:53   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 15/21] q35: Fix non-PCI IRQ processing in ich9_lpc_update_apic Jason Baron
2012-10-09  7:53   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 17/21] q35: Add kvmclock support Jason Baron
2012-10-09  7:54   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 16/21] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_ERROR and PCI_STATUS_DETECTED_PARITY from w1cmask Jason Baron
2012-10-09  7:54   ` Paolo Bonzini
2012-10-11 14:53   ` Michael S. Tsirkin
2012-10-19 15:13     ` Jason Baron
2012-10-19 16:17       ` Isaku Yamahata
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 19/21] Add a fallback bios file search, if -L fails Jason Baron
2012-10-09  7:59   ` Paolo Bonzini
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 18/21] q35: Fix irr initialization for slots 25..31 Jason Baron
2012-10-09  7:58   ` Paolo Bonzini
2012-10-11 14:49   ` Michael S. Tsirkin
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 20/21] q35: automatically load the q35 dsdt table Jason Baron
2012-10-09  8:02   ` Paolo Bonzini
2012-10-09  8:29     ` Paolo Bonzini
2012-10-09 20:06     ` Jason Baron
2012-10-13  8:33   ` Blue Swirl
2012-10-09  3:30 ` [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug Jason Baron
2012-10-09  8:04   ` Paolo Bonzini
2012-10-11 10:57   ` Michael S. Tsirkin
2012-10-11 14:21     ` Jason Baron
2012-10-11 14:46       ` Michael S. Tsirkin
2012-10-11 14:54         ` Paolo Bonzini [this message]
2012-10-11 15:40           ` Jason Baron
2012-10-11 15:34         ` Jason Baron
2012-10-11 20:40           ` Michael S. Tsirkin
2012-10-12 15:27             ` Jason Baron
2012-10-13 23:03               ` Michael S. Tsirkin
2012-10-12  7:27           ` Gerd Hoffmann
2012-10-12  9:39             ` Michael S. Tsirkin
2012-10-12 10:06               ` Gerd Hoffmann
2012-10-12 10:39                 ` Michael S. Tsirkin
2012-10-12 15:00                 ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5076DDBD.50903@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jbaron@redhat.com \
    --cc=juzhang@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mkletzan@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.