From: Michael Haggerty <mhagger@alum.mit.edu>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Tim Henigan" <tim.henigan@gmail.com>
Subject: Re: [minor] two tests broken when run with a --root directory that's a symlink
Date: Fri, 12 Oct 2012 00:50:13 +0200 [thread overview]
Message-ID: <50774D25.6000403@alum.mit.edu> (raw)
In-Reply-To: <CACBZZX6Cu_4X=AywsDMebdoFYdEN1Gmp439aEAcehHBuMhziTw@mail.gmail.com>
On 10/11/2012 11:55 PM, Ævar Arnfjörð Bjarmason wrote:
> These issues are minor, I noticed it because I test with /dev/shm/git
> as the --root, which on Debian is symlinked to /run/..
>
> $ rm -rf /tmp/{foo,bar}
> $ mkdir /tmp/target; ln -s /tmp/target /tmp/link
> $ prove ./t4035-diff-quiet.sh ./t9903-bash-prompt.sh :: --root=/tmp/target
> ./t4035-diff-quiet.sh ... ok
> ./t9903-bash-prompt.sh .. ok
> All tests successful.
> Files=2, Tests=64, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.07
> cusr 0.06 csys = 0.17 CPU)
> Result: PASS
> $ prove ./t4035-diff-quiet.sh ./t9903-bash-prompt.sh :: --root=/tmp/link
> ./t4035-diff-quiet.sh ... Dubious, test returned 1 (wstat 256, 0x100)
> Failed 3/20 subtests
> ./t9903-bash-prompt.sh .. Dubious, test returned 1 (wstat 256, 0x100)
> Failed 6/44 subtests
>
> Everything else in the test suite passes with a --root that's a symlink.
I ran into the same problem a while ago, and submitted a patch series
that fixes t4035 (whose problems are related to GIT_CEILING_DIRECTORIES):
http://thread.gmane.org/gmane.comp.version-control.git/206633
Junio didn't like the approach so much and I haven't yet had time to
submit a revised version.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2012-10-11 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 21:55 [minor] two tests broken when run with a --root directory that's a symlink Ævar Arnfjörð Bjarmason
2012-10-11 22:38 ` [PATCH] bash prompt: fix tests when run with a symlink --root SZEDER Gábor
2012-10-11 22:50 ` Michael Haggerty [this message]
2012-10-11 23:26 ` [minor] two tests broken when run with a --root directory that's a symlink Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50774D25.6000403@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=szeder@ira.uka.de \
--cc=tim.henigan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.