From: Junio C Hamano <gitster@pobox.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Tim Henigan" <tim.henigan@gmail.com>
Subject: Re: [minor] two tests broken when run with a --root directory that's a symlink
Date: Thu, 11 Oct 2012 16:26:37 -0700 [thread overview]
Message-ID: <7vpq4o615e.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <50774D25.6000403@alum.mit.edu> (Michael Haggerty's message of "Fri, 12 Oct 2012 00:50:13 +0200")
Michael Haggerty <mhagger@alum.mit.edu> writes:
> I ran into the same problem a while ago, and submitted a patch series
> that fixes t4035 (whose problems are related to GIT_CEILING_DIRECTORIES):
>
> http://thread.gmane.org/gmane.comp.version-control.git/206633
>
> Junio didn't like the approach so much and I haven't yet had time to
> submit a revised version.
I like the approach of comparing each element of CEILING and the
directory not before but after resolving any symlinks in them.
My comments was only about the implementation that seemed to make
the API layering boundary more complex than necessary.
prev parent reply other threads:[~2012-10-11 23:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 21:55 [minor] two tests broken when run with a --root directory that's a symlink Ævar Arnfjörð Bjarmason
2012-10-11 22:38 ` [PATCH] bash prompt: fix tests when run with a symlink --root SZEDER Gábor
2012-10-11 22:50 ` [minor] two tests broken when run with a --root directory that's a symlink Michael Haggerty
2012-10-11 23:26 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpq4o615e.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=szeder@ira.uka.de \
--cc=tim.henigan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.