* [U-Boot] [PATCH] m28: Properly configure the SPI flash chipselect
@ 2012-10-12 1:36 Marek Vasut
2012-10-12 2:08 ` Marek Vasut
2012-10-12 19:17 ` Tom Rini
0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2012-10-12 1:36 UTC (permalink / raw)
To: u-boot
The SPI flash is not properly detected by plain "sf probe" due to
it being located on different bus and different chipselect. Fix
this problem.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Tom Rini <trini@ti.com>
---
include/configs/m28evk.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
index 9eb2a54..bdbb820 100644
--- a/include/configs/m28evk.h
+++ b/include/configs/m28evk.h
@@ -246,18 +246,20 @@
#define CONFIG_MXS_SPI_DMA_ENABLE
#define CONFIG_SPI_HALF_DUPLEX
#define CONFIG_DEFAULT_SPI_BUS 2
+#define CONFIG_DEFAULT_SPI_CS 0
#define CONFIG_DEFAULT_SPI_MODE SPI_MODE_0
/* SPI FLASH */
#ifdef CONFIG_CMD_SF
#define CONFIG_SPI_FLASH
#define CONFIG_SPI_FLASH_STMICRO
-#define CONFIG_SF_DEFAULT_CS 2
-#define CONFIG_SF_DEFAULT_MODE SPI_MODE_0
+#define CONFIG_SF_DEFAULT_BUS 2
+#define CONFIG_SF_DEFAULT_CS 0
#define CONFIG_SF_DEFAULT_SPEED 40000000
+#define CONFIG_SF_DEFAULT_MODE SPI_MODE_0
-#define CONFIG_ENV_SPI_CS 0
#define CONFIG_ENV_SPI_BUS 2
+#define CONFIG_ENV_SPI_CS 0
#define CONFIG_ENV_SPI_MAX_HZ 40000000
#define CONFIG_ENV_SPI_MODE SPI_MODE_0
#endif
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] m28: Properly configure the SPI flash chipselect
2012-10-12 1:36 [U-Boot] [PATCH] m28: Properly configure the SPI flash chipselect Marek Vasut
@ 2012-10-12 2:08 ` Marek Vasut
2012-10-12 7:47 ` Stefano Babic
2012-10-12 19:17 ` Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2012-10-12 2:08 UTC (permalink / raw)
To: u-boot
Dear Tom Rini,
> The SPI flash is not properly detected by plain "sf probe" due to
> it being located on different bus and different chipselect. Fix
> this problem.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tom Rini <trini@ti.com>
[...]
Please apply for .10 release, this is an important bugfix. Tested by DUTS as of
now.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] m28: Properly configure the SPI flash chipselect
2012-10-12 2:08 ` Marek Vasut
@ 2012-10-12 7:47 ` Stefano Babic
2012-10-12 8:07 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Stefano Babic @ 2012-10-12 7:47 UTC (permalink / raw)
To: u-boot
Am 12/10/2012 04:08, schrieb Marek Vasut:
> Dear Tom Rini,
>
>> The SPI flash is not properly detected by plain "sf probe" due to
>> it being located on different bus and different chipselect. Fix
>> this problem.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Stefano Babic <sbabic@denx.de>
>> Cc: Tom Rini <trini@ti.com>
> [...]
>
> Please apply for .10 release, this is an important bugfix. Tested by DUTS as of
> now.
So should Tom apply it directly to u-boot/master or do you think we
follow the usual path through u-boot-imx/master ?
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] m28: Properly configure the SPI flash chipselect
2012-10-12 7:47 ` Stefano Babic
@ 2012-10-12 8:07 ` Marek Vasut
2012-10-12 10:48 ` Stefano Babic
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2012-10-12 8:07 UTC (permalink / raw)
To: u-boot
Dear Stefano Babic,
> Am 12/10/2012 04:08, schrieb Marek Vasut:
> > Dear Tom Rini,
> >
> >> The SPI flash is not properly detected by plain "sf probe" due to
> >> it being located on different bus and different chipselect. Fix
> >> this problem.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Stefano Babic <sbabic@denx.de>
> >> Cc: Tom Rini <trini@ti.com>
> >
> > [...]
> >
> > Please apply for .10 release, this is an important bugfix. Tested by DUTS
> > as of now.
>
> So should Tom apply it directly to u-boot/master or do you think we
> follow the usual path through u-boot-imx/master ?
I don't have any further patches, so if Tom is OK with picking it up directly,
WFM.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] m28: Properly configure the SPI flash chipselect
2012-10-12 8:07 ` Marek Vasut
@ 2012-10-12 10:48 ` Stefano Babic
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2012-10-12 10:48 UTC (permalink / raw)
To: u-boot
Am 12/10/2012 10:07, schrieb Marek Vasut:
> Dear Stefano Babic,
>
>> Am 12/10/2012 04:08, schrieb Marek Vasut:
>>> Dear Tom Rini,
>>>
>>>> The SPI flash is not properly detected by plain "sf probe" due to
>>>> it being located on different bus and different chipselect. Fix
>>>> this problem.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> Cc: Stefano Babic <sbabic@denx.de>
>>>> Cc: Tom Rini <trini@ti.com>
>>>
>>> [...]
>>>
>>> Please apply for .10 release, this is an important bugfix. Tested by DUTS
>>> as of now.
>>
>> So should Tom apply it directly to u-boot/master or do you think we
>> follow the usual path through u-boot-imx/master ?
>
> I don't have any further patches, so if Tom is OK with picking it up directly,
> WFM.
Ok, fine with m, of course !
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] m28: Properly configure the SPI flash chipselect
2012-10-12 1:36 [U-Boot] [PATCH] m28: Properly configure the SPI flash chipselect Marek Vasut
2012-10-12 2:08 ` Marek Vasut
@ 2012-10-12 19:17 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2012-10-12 19:17 UTC (permalink / raw)
To: u-boot
On Fri, Oct 12, 2012 at 03:36:56AM +0200, Marek Vasut wrote:
> The SPI flash is not properly detected by plain "sf probe" due to
> it being located on different bus and different chipselect. Fix
> this problem.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tom Rini <trini@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121012/d4790dca/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-12 19:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-12 1:36 [U-Boot] [PATCH] m28: Properly configure the SPI flash chipselect Marek Vasut
2012-10-12 2:08 ` Marek Vasut
2012-10-12 7:47 ` Stefano Babic
2012-10-12 8:07 ` Marek Vasut
2012-10-12 10:48 ` Stefano Babic
2012-10-12 19:17 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.