From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: rientjes@google.com, akpm@linux-foundation.org,
isimatu.yasuaki@jp.fujitsu.com
Subject: [PATCH] mm: cleanup register_node()
Date: Fri, 12 Oct 2012 17:22:43 +0900 [thread overview]
Message-ID: <5077D353.3010708@jp.fujitsu.com> (raw)
register_node() is defined as extern in include/linux/node.h. But the function
is only called from register_one_node() in driver/base/node.c.
So the patch defines register_node() as static.
CC: David Rientjes <rientjes@google.com>
CC: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
drivers/base/node.c | 2 +-
include/linux/node.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
Index: linux-3.6/drivers/base/node.c
===================================================================
--- linux-3.6.orig/drivers/base/node.c 2012-10-12 16:35:51.000000000 +0900
+++ linux-3.6/drivers/base/node.c 2012-10-12 16:52:25.294207322 +0900
@@ -259,7 +259,7 @@ static inline void hugetlb_unregister_no
*
* Initialize and register the node device.
*/
-int register_node(struct node *node, int num, struct node *parent)
+static int register_node(struct node *node, int num, struct node *parent)
{
int error;
Index: linux-3.6/include/linux/node.h
===================================================================
--- linux-3.6.orig/include/linux/node.h 2012-10-01 08:47:46.000000000 +0900
+++ linux-3.6/include/linux/node.h 2012-10-12 16:52:55.215210433 +0900
@@ -30,7 +30,6 @@ struct memory_block;
extern struct node node_devices[];
typedef void (*node_registration_func_t)(struct node *);
-extern int register_node(struct node *, int, struct node *);
extern void unregister_node(struct node *node);
#ifdef CONFIG_NUMA
extern int register_one_node(int nid);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Cc: <rientjes@google.com>, <akpm@linux-foundation.org>,
<isimatu.yasuaki@jp.fujitsu.com>
Subject: [PATCH] mm: cleanup register_node()
Date: Fri, 12 Oct 2012 17:22:43 +0900 [thread overview]
Message-ID: <5077D353.3010708@jp.fujitsu.com> (raw)
register_node() is defined as extern in include/linux/node.h. But the function
is only called from register_one_node() in driver/base/node.c.
So the patch defines register_node() as static.
CC: David Rientjes <rientjes@google.com>
CC: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
drivers/base/node.c | 2 +-
include/linux/node.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
Index: linux-3.6/drivers/base/node.c
===================================================================
--- linux-3.6.orig/drivers/base/node.c 2012-10-12 16:35:51.000000000 +0900
+++ linux-3.6/drivers/base/node.c 2012-10-12 16:52:25.294207322 +0900
@@ -259,7 +259,7 @@ static inline void hugetlb_unregister_no
*
* Initialize and register the node device.
*/
-int register_node(struct node *node, int num, struct node *parent)
+static int register_node(struct node *node, int num, struct node *parent)
{
int error;
Index: linux-3.6/include/linux/node.h
===================================================================
--- linux-3.6.orig/include/linux/node.h 2012-10-01 08:47:46.000000000 +0900
+++ linux-3.6/include/linux/node.h 2012-10-12 16:52:55.215210433 +0900
@@ -30,7 +30,6 @@ struct memory_block;
extern struct node node_devices[];
typedef void (*node_registration_func_t)(struct node *);
-extern int register_node(struct node *, int, struct node *);
extern void unregister_node(struct node *node);
#ifdef CONFIG_NUMA
extern int register_one_node(int nid);
next reply other threads:[~2012-10-12 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 8:22 Yasuaki Ishimatsu [this message]
2012-10-12 8:22 ` [PATCH] mm: cleanup register_node() Yasuaki Ishimatsu
2012-10-13 9:56 ` David Rientjes
2012-10-13 9:56 ` David Rientjes
2012-10-13 23:17 ` KOSAKI Motohiro
2012-10-13 23:17 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5077D353.3010708@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.