* [PATCH] davinci: fix return value check by using IS_ERR in tnetv107x_devices_init()
@ 2012-09-21 6:12 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2012-09-21 6:12 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function clk_get() returns ERR_PTR() not
NULL pointer. The NULL test in the error handling should be
replaced with IS_ERR().
dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/arm/mach-davinci/devices-tnetv107x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-davinci/devices-tnetv107x.c b/arch/arm/mach-davinci/devices-tnetv107x.c
index 29b17f7..773ab07 100644
--- a/arch/arm/mach-davinci/devices-tnetv107x.c
+++ b/arch/arm/mach-davinci/devices-tnetv107x.c
@@ -374,7 +374,7 @@ void __init tnetv107x_devices_init(struct tnetv107x_device_info *info)
* complete sample conversion in time.
*/
tsc_clk = clk_get(NULL, "sys_tsc_clk");
- if (tsc_clk) {
+ if (!IS_ERR(tsc_clk)) {
error = clk_set_rate(tsc_clk, 5000000);
WARN_ON(error < 0);
clk_put(tsc_clk);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] davinci: fix return value check by using IS_ERR in tnetv107x_devices_init()
@ 2012-09-21 6:12 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2012-09-21 6:12 UTC (permalink / raw)
To: nsekhar, khilman, linux
Cc: yongjun_wei, davinci-linux-open-source, linux-arm-kernel,
linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function clk_get() returns ERR_PTR() not
NULL pointer. The NULL test in the error handling should be
replaced with IS_ERR().
dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
arch/arm/mach-davinci/devices-tnetv107x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-davinci/devices-tnetv107x.c b/arch/arm/mach-davinci/devices-tnetv107x.c
index 29b17f7..773ab07 100644
--- a/arch/arm/mach-davinci/devices-tnetv107x.c
+++ b/arch/arm/mach-davinci/devices-tnetv107x.c
@@ -374,7 +374,7 @@ void __init tnetv107x_devices_init(struct tnetv107x_device_info *info)
* complete sample conversion in time.
*/
tsc_clk = clk_get(NULL, "sys_tsc_clk");
- if (tsc_clk) {
+ if (!IS_ERR(tsc_clk)) {
error = clk_set_rate(tsc_clk, 5000000);
WARN_ON(error < 0);
clk_put(tsc_clk);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] davinci: fix return value check by using IS_ERR in tnetv107x_devices_init()
2012-09-21 6:12 ` Wei Yongjun
@ 2012-10-12 12:50 ` Sekhar Nori
-1 siblings, 0 replies; 4+ messages in thread
From: Sekhar Nori @ 2012-10-12 12:50 UTC (permalink / raw)
To: linux-arm-kernel
Hi Wei,
On 9/21/2012 11:42 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function clk_get() returns ERR_PTR() not
> NULL pointer. The NULL test in the error handling should be
> replaced with IS_ERR().
>
> dpatch engine is used to auto generated this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Queuing this for v3.8. While committing, I added ARM: prefix to the
subject line as is the norm with all arch/arm/* patches.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] davinci: fix return value check by using IS_ERR in tnetv107x_devices_init()
@ 2012-10-12 12:50 ` Sekhar Nori
0 siblings, 0 replies; 4+ messages in thread
From: Sekhar Nori @ 2012-10-12 12:50 UTC (permalink / raw)
To: Wei Yongjun
Cc: khilman, linux, yongjun_wei, davinci-linux-open-source,
linux-arm-kernel, linux-kernel
Hi Wei,
On 9/21/2012 11:42 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function clk_get() returns ERR_PTR() not
> NULL pointer. The NULL test in the error handling should be
> replaced with IS_ERR().
>
> dpatch engine is used to auto generated this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Queuing this for v3.8. While committing, I added ARM: prefix to the
subject line as is the norm with all arch/arm/* patches.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-12 12:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-21 6:12 [PATCH] davinci: fix return value check by using IS_ERR in tnetv107x_devices_init() Wei Yongjun
2012-09-21 6:12 ` Wei Yongjun
2012-10-12 12:50 ` Sekhar Nori
2012-10-12 12:50 ` Sekhar Nori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.