From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org, patches@linaro.org,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] targphys.h: Don't define target_phys_addr_t for user-mode emulators
Date: Fri, 12 Oct 2012 22:58:26 +0200 [thread overview]
Message-ID: <50788472.3000707@suse.de> (raw)
In-Reply-To: <1350064784-13058-1-git-send-email-peter.maydell@linaro.org>
Am 12.10.2012 19:59, schrieb Peter Maydell:
> Commit 4be403c accidentally defined the target_phys_addr_t type when
> building user-mode emulators. Since the type doesn't really make
> any sense except for system emulators, avoid defining it when building
> in user mode.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Andreas Färber <afaerber@suse.de>
I do ask myself though why we would include targphys.h in user mode. ;)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org, patches@linaro.org,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] targphys.h: Don't define target_phys_addr_t for user-mode emulators
Date: Fri, 12 Oct 2012 22:58:26 +0200 [thread overview]
Message-ID: <50788472.3000707@suse.de> (raw)
In-Reply-To: <1350064784-13058-1-git-send-email-peter.maydell@linaro.org>
Am 12.10.2012 19:59, schrieb Peter Maydell:
> Commit 4be403c accidentally defined the target_phys_addr_t type when
> building user-mode emulators. Since the type doesn't really make
> any sense except for system emulators, avoid defining it when building
> in user mode.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Andreas Färber <afaerber@suse.de>
I do ask myself though why we would include targphys.h in user mode. ;)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-10-12 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 17:59 [Qemu-trivial] [PATCH] targphys.h: Don't define target_phys_addr_t for user-mode emulators Peter Maydell
2012-10-12 17:59 ` [Qemu-devel] " Peter Maydell
2012-10-12 20:58 ` Andreas Färber [this message]
2012-10-12 20:58 ` Andreas Färber
2012-10-19 8:32 ` [Qemu-trivial] " Stefan Hajnoczi
2012-10-19 8:32 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50788472.3000707@suse.de \
--to=afaerber@suse.de \
--cc=avi@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.