* [PATCH] iio: remove useless irq_enabled variable in at91
@ 2012-10-13 8:06 Peter Meerwald
2012-10-13 8:06 ` [PATCH] iio: use iio_push_to_buffer() in at91 driver Peter Meerwald
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Peter Meerwald @ 2012-10-13 8:06 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Peter Meerwald
irq_enabled is only set, but never read
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
drivers/iio/adc/at91_adc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index 3ed94bf..b3ba8af 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -46,7 +46,6 @@ struct at91_adc_state {
struct clk *clk;
bool done;
int irq;
- bool irq_enabled;
u16 last_value;
struct mutex lock;
u8 num_channels;
@@ -85,7 +84,6 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
buffer->access->store_to(buffer, (u8 *)st->buffer);
iio_trigger_notify_done(idev->trig);
- st->irq_enabled = true;
/* Needed to ACK the DRDY interruption */
at91_adc_readl(st, AT91_ADC_LCDR);
@@ -106,7 +104,6 @@ static irqreturn_t at91_adc_eoc_trigger(int irq, void *private)
if (iio_buffer_enabled(idev)) {
disable_irq_nosync(irq);
- st->irq_enabled = false;
iio_trigger_poll(idev->trig, iio_get_time_ns());
} else {
st->last_value = at91_adc_readl(st, AT91_ADC_LCDR);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] iio: use iio_push_to_buffer() in at91 driver
2012-10-13 8:06 [PATCH] iio: remove useless irq_enabled variable in at91 Peter Meerwald
@ 2012-10-13 8:06 ` Peter Meerwald
2012-10-13 9:40 ` Jonathan Cameron
2012-10-13 8:06 ` [PATCH] staging iio: use iio_trigger_generic_data_rdy_poll() in accel/adis16209,adis16240 driver Peter Meerwald
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Peter Meerwald @ 2012-10-13 8:06 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Peter Meerwald
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
drivers/iio/adc/at91_adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index b3ba8af..2e2c9a8 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -81,7 +81,7 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
*timestamp = pf->timestamp;
}
- buffer->access->store_to(buffer, (u8 *)st->buffer);
+ iio_push_to_buffer(buffer, st->buffer);
iio_trigger_notify_done(idev->trig);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] staging iio: use iio_trigger_generic_data_rdy_poll() in accel/adis16209,adis16240 driver
2012-10-13 8:06 [PATCH] iio: remove useless irq_enabled variable in at91 Peter Meerwald
2012-10-13 8:06 ` [PATCH] iio: use iio_push_to_buffer() in at91 driver Peter Meerwald
@ 2012-10-13 8:06 ` Peter Meerwald
2012-10-13 9:42 ` Jonathan Cameron
2012-10-13 8:06 ` [PATCH] iio: fix spelling of Accelerometer in Kconfig Peter Meerwald
2012-10-13 9:37 ` [PATCH] iio: remove useless irq_enabled variable in at91 Jonathan Cameron
3 siblings, 1 reply; 8+ messages in thread
From: Peter Meerwald @ 2012-10-13 8:06 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Peter Meerwald
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/staging/iio/accel/adis16209_trigger.c | 11 +----------
drivers/staging/iio/accel/adis16240_trigger.c | 11 +----------
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16209_trigger.c b/drivers/staging/iio/accel/adis16209_trigger.c
index 2ad93dc..1122803 100644
--- a/drivers/staging/iio/accel/adis16209_trigger.c
+++ b/drivers/staging/iio/accel/adis16209_trigger.c
@@ -8,15 +8,6 @@
#include "adis16209.h"
/**
- * adis16209_data_rdy_trig_poll() the event handler for the data rdy trig
- **/
-static irqreturn_t adis16209_data_rdy_trig_poll(int irq, void *trig)
-{
- iio_trigger_poll(trig, iio_get_time_ns());
- return IRQ_HANDLED;
-}
-
-/**
* adis16209_data_rdy_trigger_set_state() set datardy interrupt state
**/
static int adis16209_data_rdy_trigger_set_state(struct iio_trigger *trig,
@@ -45,7 +36,7 @@ int adis16209_probe_trigger(struct iio_dev *indio_dev)
}
ret = request_irq(st->us->irq,
- adis16209_data_rdy_trig_poll,
+ iio_trigger_generic_data_rdy_poll,
IRQF_TRIGGER_RISING,
"adis16209",
st->trig);
diff --git a/drivers/staging/iio/accel/adis16240_trigger.c b/drivers/staging/iio/accel/adis16240_trigger.c
index fa90a22..f3caf09 100644
--- a/drivers/staging/iio/accel/adis16240_trigger.c
+++ b/drivers/staging/iio/accel/adis16240_trigger.c
@@ -8,15 +8,6 @@
#include "adis16240.h"
/**
- * adis16240_data_rdy_trig_poll() the event handler for the data rdy trig
- **/
-static irqreturn_t adis16240_data_rdy_trig_poll(int irq, void *trig)
-{
- iio_trigger_poll(trig, iio_get_time_ns());
- return IRQ_HANDLED;
-}
-
-/**
* adis16240_data_rdy_trigger_set_state() set datardy interrupt state
**/
static int adis16240_data_rdy_trigger_set_state(struct iio_trigger *trig,
@@ -45,7 +36,7 @@ int adis16240_probe_trigger(struct iio_dev *indio_dev)
}
ret = request_irq(st->us->irq,
- adis16240_data_rdy_trig_poll,
+ iio_trigger_generic_data_rdy_poll,
IRQF_TRIGGER_RISING,
"adis16240",
st->trig);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] iio: fix spelling of Accelerometer in Kconfig
2012-10-13 8:06 [PATCH] iio: remove useless irq_enabled variable in at91 Peter Meerwald
2012-10-13 8:06 ` [PATCH] iio: use iio_push_to_buffer() in at91 driver Peter Meerwald
2012-10-13 8:06 ` [PATCH] staging iio: use iio_trigger_generic_data_rdy_poll() in accel/adis16209,adis16240 driver Peter Meerwald
@ 2012-10-13 8:06 ` Peter Meerwald
2012-10-13 9:43 ` Jonathan Cameron
2012-10-13 9:37 ` [PATCH] iio: remove useless irq_enabled variable in at91 Jonathan Cameron
3 siblings, 1 reply; 8+ messages in thread
From: Peter Meerwald @ 2012-10-13 8:06 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Peter Meerwald
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: Srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/iio/accel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
index b2510c4..fe4bcd7 100644
--- a/drivers/iio/accel/Kconfig
+++ b/drivers/iio/accel/Kconfig
@@ -8,7 +8,7 @@ config HID_SENSOR_ACCEL_3D
select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
select HID_SENSOR_IIO_COMMON
- tristate "HID Acelerometers 3D"
+ tristate "HID Accelerometers 3D"
help
Say yes here to build support for the HID SENSOR
accelerometers 3D.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: remove useless irq_enabled variable in at91
2012-10-13 8:06 [PATCH] iio: remove useless irq_enabled variable in at91 Peter Meerwald
` (2 preceding siblings ...)
2012-10-13 8:06 ` [PATCH] iio: fix spelling of Accelerometer in Kconfig Peter Meerwald
@ 2012-10-13 9:37 ` Jonathan Cameron
3 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2012-10-13 9:37 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio
On 10/13/2012 09:06 AM, Peter Meerwald wrote:
> irq_enabled is only set, but never read
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Added to togreg branch of iio.git thanks.
> ---
> drivers/iio/adc/at91_adc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 3ed94bf..b3ba8af 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -46,7 +46,6 @@ struct at91_adc_state {
> struct clk *clk;
> bool done;
> int irq;
> - bool irq_enabled;
> u16 last_value;
> struct mutex lock;
> u8 num_channels;
> @@ -85,7 +84,6 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
> buffer->access->store_to(buffer, (u8 *)st->buffer);
>
> iio_trigger_notify_done(idev->trig);
> - st->irq_enabled = true;
>
> /* Needed to ACK the DRDY interruption */
> at91_adc_readl(st, AT91_ADC_LCDR);
> @@ -106,7 +104,6 @@ static irqreturn_t at91_adc_eoc_trigger(int irq, void *private)
>
> if (iio_buffer_enabled(idev)) {
> disable_irq_nosync(irq);
> - st->irq_enabled = false;
> iio_trigger_poll(idev->trig, iio_get_time_ns());
> } else {
> st->last_value = at91_adc_readl(st, AT91_ADC_LCDR);
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: use iio_push_to_buffer() in at91 driver
2012-10-13 8:06 ` [PATCH] iio: use iio_push_to_buffer() in at91 driver Peter Meerwald
@ 2012-10-13 9:40 ` Jonathan Cameron
0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2012-10-13 9:40 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio
On 10/13/2012 09:06 AM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Ate this up in the multiple buffers patch series, but cleaner history to
do it with this patch then change it again.
Added to togreg branch of iio.git
> ---
> drivers/iio/adc/at91_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index b3ba8af..2e2c9a8 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -81,7 +81,7 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p)
> *timestamp = pf->timestamp;
> }
>
> - buffer->access->store_to(buffer, (u8 *)st->buffer);
> + iio_push_to_buffer(buffer, st->buffer);
>
> iio_trigger_notify_done(idev->trig);
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging iio: use iio_trigger_generic_data_rdy_poll() in accel/adis16209,adis16240 driver
2012-10-13 8:06 ` [PATCH] staging iio: use iio_trigger_generic_data_rdy_poll() in accel/adis16209,adis16240 driver Peter Meerwald
@ 2012-10-13 9:42 ` Jonathan Cameron
0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2012-10-13 9:42 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio
On 10/13/2012 09:06 AM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
added to togreg branch of iio.git
> ---
> drivers/staging/iio/accel/adis16209_trigger.c | 11 +----------
> drivers/staging/iio/accel/adis16240_trigger.c | 11 +----------
> 2 files changed, 2 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209_trigger.c b/drivers/staging/iio/accel/adis16209_trigger.c
> index 2ad93dc..1122803 100644
> --- a/drivers/staging/iio/accel/adis16209_trigger.c
> +++ b/drivers/staging/iio/accel/adis16209_trigger.c
> @@ -8,15 +8,6 @@
> #include "adis16209.h"
>
> /**
> - * adis16209_data_rdy_trig_poll() the event handler for the data rdy trig
> - **/
> -static irqreturn_t adis16209_data_rdy_trig_poll(int irq, void *trig)
> -{
> - iio_trigger_poll(trig, iio_get_time_ns());
> - return IRQ_HANDLED;
> -}
> -
> -/**
> * adis16209_data_rdy_trigger_set_state() set datardy interrupt state
> **/
> static int adis16209_data_rdy_trigger_set_state(struct iio_trigger *trig,
> @@ -45,7 +36,7 @@ int adis16209_probe_trigger(struct iio_dev *indio_dev)
> }
>
> ret = request_irq(st->us->irq,
> - adis16209_data_rdy_trig_poll,
> + iio_trigger_generic_data_rdy_poll,
> IRQF_TRIGGER_RISING,
> "adis16209",
> st->trig);
> diff --git a/drivers/staging/iio/accel/adis16240_trigger.c b/drivers/staging/iio/accel/adis16240_trigger.c
> index fa90a22..f3caf09 100644
> --- a/drivers/staging/iio/accel/adis16240_trigger.c
> +++ b/drivers/staging/iio/accel/adis16240_trigger.c
> @@ -8,15 +8,6 @@
> #include "adis16240.h"
>
> /**
> - * adis16240_data_rdy_trig_poll() the event handler for the data rdy trig
> - **/
> -static irqreturn_t adis16240_data_rdy_trig_poll(int irq, void *trig)
> -{
> - iio_trigger_poll(trig, iio_get_time_ns());
> - return IRQ_HANDLED;
> -}
> -
> -/**
> * adis16240_data_rdy_trigger_set_state() set datardy interrupt state
> **/
> static int adis16240_data_rdy_trigger_set_state(struct iio_trigger *trig,
> @@ -45,7 +36,7 @@ int adis16240_probe_trigger(struct iio_dev *indio_dev)
> }
>
> ret = request_irq(st->us->irq,
> - adis16240_data_rdy_trig_poll,
> + iio_trigger_generic_data_rdy_poll,
> IRQF_TRIGGER_RISING,
> "adis16240",
> st->trig);
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio: fix spelling of Accelerometer in Kconfig
2012-10-13 8:06 ` [PATCH] iio: fix spelling of Accelerometer in Kconfig Peter Meerwald
@ 2012-10-13 9:43 ` Jonathan Cameron
0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2012-10-13 9:43 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio
On 10/13/2012 09:06 AM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Acked-by: Srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
Added to togreg branch of iio.git
(I'd have picked all these up today from the original thread, but
this nice series with acks etc does make life easier - thanks!)
> ---
> drivers/iio/accel/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index b2510c4..fe4bcd7 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -8,7 +8,7 @@ config HID_SENSOR_ACCEL_3D
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> select HID_SENSOR_IIO_COMMON
> - tristate "HID Acelerometers 3D"
> + tristate "HID Accelerometers 3D"
> help
> Say yes here to build support for the HID SENSOR
> accelerometers 3D.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-10-13 9:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-13 8:06 [PATCH] iio: remove useless irq_enabled variable in at91 Peter Meerwald
2012-10-13 8:06 ` [PATCH] iio: use iio_push_to_buffer() in at91 driver Peter Meerwald
2012-10-13 9:40 ` Jonathan Cameron
2012-10-13 8:06 ` [PATCH] staging iio: use iio_trigger_generic_data_rdy_poll() in accel/adis16209,adis16240 driver Peter Meerwald
2012-10-13 9:42 ` Jonathan Cameron
2012-10-13 8:06 ` [PATCH] iio: fix spelling of Accelerometer in Kconfig Peter Meerwald
2012-10-13 9:43 ` Jonathan Cameron
2012-10-13 9:37 ` [PATCH] iio: remove useless irq_enabled variable in at91 Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.