From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: "Heiko Stübner" <heiko@sntech.de>,
"José Miguel Gonçalves" <jose.goncalves@inov.pt>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: SAMSUNG: Add naming of s3c64xx-spi devices
Date: Mon, 15 Oct 2012 16:58:26 +0200 [thread overview]
Message-ID: <507C2492.8010408@samsung.com> (raw)
In-Reply-To: <201210021443.54897.heiko@sntech.de>
Hi Heiko,
On 10/02/2012 02:43 PM, Heiko Stübner wrote:
> Commit a5238e360b71 (spi: s3c64xx: move controller information into driver
> data) introduced separate device names for the different subtypes of the
> spi controller but forgot to set these in the relevant machines.
>
> To fix this introduce a s3c64xx_spi_setname function and populate all
> Samsung arches with the correct names. The function resides in a new
> header, as the s3c64xx-spi.h contains driver platform data and should
> therefore at some later point move out of the Samsung include dir.
>
> Tested on a s3c2416-based machine.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Cc: stable@vger.kernel.org
This patch looks good to me. I've tested it on Exynos4412 SoC based
board. And it fixes quite serious problem - broken SPI support on
a all Samsung machs (non-dt) except s3c64xx in mainline v3.6 kernel.
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Tested-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
(mach-exynos only)
José Miguel, can you confirm it solves the problem for you ?
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: Add naming of s3c64xx-spi devices
Date: Mon, 15 Oct 2012 16:58:26 +0200 [thread overview]
Message-ID: <507C2492.8010408@samsung.com> (raw)
In-Reply-To: <201210021443.54897.heiko@sntech.de>
Hi Heiko,
On 10/02/2012 02:43 PM, Heiko St?bner wrote:
> Commit a5238e360b71 (spi: s3c64xx: move controller information into driver
> data) introduced separate device names for the different subtypes of the
> spi controller but forgot to set these in the relevant machines.
>
> To fix this introduce a s3c64xx_spi_setname function and populate all
> Samsung arches with the correct names. The function resides in a new
> header, as the s3c64xx-spi.h contains driver platform data and should
> therefore at some later point move out of the Samsung include dir.
>
> Tested on a s3c2416-based machine.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Cc: stable at vger.kernel.org
This patch looks good to me. I've tested it on Exynos4412 SoC based
board. And it fixes quite serious problem - broken SPI support on
a all Samsung machs (non-dt) except s3c64xx in mainline v3.6 kernel.
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Tested-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
(mach-exynos only)
Jos? Miguel, can you confirm it solves the problem for you ?
--
Regards,
Sylwester
next prev parent reply other threads:[~2012-10-15 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 12:43 [PATCH] ARM: SAMSUNG: Add naming of s3c64xx-spi devices Heiko Stübner
2012-10-02 12:43 ` Heiko Stübner
2012-10-15 14:58 ` Sylwester Nawrocki [this message]
2012-10-15 14:58 ` Sylwester Nawrocki
2012-10-15 16:22 ` José Miguel Gonçalves
2012-10-15 16:22 ` José Miguel Gonçalves
2012-10-17 8:23 ` Kukjin Kim
2012-10-17 8:23 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507C2492.8010408@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=heiko@sntech.de \
--cc=jose.goncalves@inov.pt \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.