From: Wolfgang Grandegger <wg@grandegger.com>
To: Muhammad Ghias <mghias@connecttech.com>
Cc: "'Marc Kleine-Budde'" <mkl@pengutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CAN: sja1000: Add support for Connect Tech Inc's Canpro/104-Plus Opto CAN board
Date: Wed, 17 Oct 2012 08:35:52 +0200 [thread overview]
Message-ID: <507E51C8.4090300@grandegger.com> (raw)
In-Reply-To: <02ac01cdabe1$b5403e10$1fc0ba30$@connecttech.com>
On 10/16/2012 11:03 PM, Muhammad Ghias wrote:
> Patch adds support for CANpro/104-Plus Opto CAN board. Board uses PLX9030
> bridge and two NXP SJA1000 CAN controllers. Patch is generated and tested
> with kernel 3.6.1.
>
> If you have any questions or any feedback please let me know.
>
> Thanks,
The above two lines should go ...
> Signed-off-by: Muhammad Ghias <mghias@connecttech.com>
> ---
... here (out of the commit message).
Apart from that the patch looks good. You can add my
Acked-by: Wolfgang Grandegger <wg@grandegger.com>
Thanks for your contribution.
Wolfgang.
next prev parent reply other threads:[~2012-10-17 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 21:03 [PATCH] CAN: sja1000: Add support for Connect Tech Inc's Canpro/104-Plus Opto CAN board Muhammad Ghias
2012-10-17 6:35 ` Wolfgang Grandegger [this message]
2012-10-17 10:13 ` Marc Kleine-Budde
2012-10-17 18:42 ` Muhammad Ghias
2012-10-17 18:42 ` Muhammad Ghias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507E51C8.4090300@grandegger.com \
--to=wg@grandegger.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mghias@connecttech.com \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.