All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Muhammad Ghias" <mghias@connecttech.com>
To: 'Marc Kleine-Budde' <mkl@pengutronix.de>
Cc: 'Wolfgang Grandegger' <wg@grandegger.com>,
	linux-kernel@vger.kernel.org, linux-can@vger.kernel.org
Subject: RE: [PATCH] CAN: sja1000: Add support for Connect Tech Inc's Canpro/104-Plus Opto CAN board
Date: Wed, 17 Oct 2012 14:42:12 -0400	[thread overview]
Message-ID: <036301cdac97$1ee892d0$5cb9b870$@connecttech.com> (raw)
In-Reply-To: <507E84C5.2040600@pengutronix.de>

Hi Marc,

I tested the patch v2 with kernel 3.6.1 and 3.7-rc1. Clean compile and works
with hardware.

Regards,
Muhammad

-----Original Message-----
From: Marc Kleine-Budde [mailto:mkl@pengutronix.de] 
Sent: October-17-12 6:13 AM
To: Muhammad Ghias
Cc: 'Wolfgang Grandegger'; linux-kernel@vger.kernel.org;
linux-can@vger.kernel.org
Subject: Re: [PATCH] CAN: sja1000: Add support for Connect Tech Inc's
Canpro/104-Plus Opto CAN board

On 10/16/2012 11:03 PM, Muhammad Ghias wrote:
> Patch adds support for CANpro/104-Plus Opto CAN board. Board uses PLX9030
> bridge and two NXP SJA1000 CAN controllers. Patch is generated and tested
> with kernel 3.6.1.
> 
> If you have any questions or any feedback please let me know.

Thanks, the code looks good. Please try, if possible, to send your
patches via git send-email, as outlooks messed up the patch. I've fixed
all line wrapping problems by hand, applied the patch and send a v2,
please test.

regards, Marc

P.S.: Please use the linux-can@vger.kernel.org mailing list for CAN
related patches/topics.

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

WARNING: multiple messages have this Message-ID (diff)
From: "Muhammad Ghias" <mghias@connecttech.com>
To: "'Marc Kleine-Budde'" <mkl@pengutronix.de>
Cc: "'Wolfgang Grandegger'" <wg@grandegger.com>,
	<linux-kernel@vger.kernel.org>, <linux-can@vger.kernel.org>
Subject: RE: [PATCH] CAN: sja1000: Add support for Connect Tech Inc's Canpro/104-Plus Opto CAN board
Date: Wed, 17 Oct 2012 14:42:12 -0400	[thread overview]
Message-ID: <036301cdac97$1ee892d0$5cb9b870$@connecttech.com> (raw)
In-Reply-To: <507E84C5.2040600@pengutronix.de>

Hi Marc,

I tested the patch v2 with kernel 3.6.1 and 3.7-rc1. Clean compile and works
with hardware.

Regards,
Muhammad

-----Original Message-----
From: Marc Kleine-Budde [mailto:mkl@pengutronix.de] 
Sent: October-17-12 6:13 AM
To: Muhammad Ghias
Cc: 'Wolfgang Grandegger'; linux-kernel@vger.kernel.org;
linux-can@vger.kernel.org
Subject: Re: [PATCH] CAN: sja1000: Add support for Connect Tech Inc's
Canpro/104-Plus Opto CAN board

On 10/16/2012 11:03 PM, Muhammad Ghias wrote:
> Patch adds support for CANpro/104-Plus Opto CAN board. Board uses PLX9030
> bridge and two NXP SJA1000 CAN controllers. Patch is generated and tested
> with kernel 3.6.1.
> 
> If you have any questions or any feedback please let me know.

Thanks, the code looks good. Please try, if possible, to send your
patches via git send-email, as outlooks messed up the patch. I've fixed
all line wrapping problems by hand, applied the patch and send a v2,
please test.

regards, Marc

P.S.: Please use the linux-can@vger.kernel.org mailing list for CAN
related patches/topics.

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



  reply	other threads:[~2012-10-17 18:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16 21:03 [PATCH] CAN: sja1000: Add support for Connect Tech Inc's Canpro/104-Plus Opto CAN board Muhammad Ghias
2012-10-17  6:35 ` Wolfgang Grandegger
2012-10-17 10:13 ` Marc Kleine-Budde
2012-10-17 18:42   ` Muhammad Ghias [this message]
2012-10-17 18:42     ` Muhammad Ghias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='036301cdac97$1ee892d0$5cb9b870$@connecttech.com' \
    --to=mghias@connecttech.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.