From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paul Mackerras <paulus@samba.org>, Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>,
Juan Quintela <quintela@redhat.com>,
Orit Wasserman <owasserm@redhat.com>
Subject: Re: [PATCH 5/5] KVM: PPC: Book3S HV: Provide a method for userspace to read and write the HPT
Date: Wed, 17 Oct 2012 10:27:47 +0000 [thread overview]
Message-ID: <507E8823.3090006@redhat.com> (raw)
In-Reply-To: <87txtuyykr.fsf@codemonkey.ws>
On 10/16/2012 10:03 PM, Anthony Liguori wrote:
>>
>> This forces userspace to dedicate a thread for the HPT.
>
> If no changes are available, does read return a size > 0? I don't think
> it's necessary to support polling. The kernel should always be able to
> respond to userspace here. The only catch is whether to return !0 read
> sizes when there are no changes.
>
> At any case, I can't see why a dedicated thread is needed. QEMU is
> going to poll HPT based on how fast we can send data over the wire.
That means spinning if we can send the data faster than we dirty it.
But we do that anyway for memory.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paul Mackerras <paulus@samba.org>, Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>,
Juan Quintela <quintela@redhat.com>,
Orit Wasserman <owasserm@redhat.com>
Subject: Re: [PATCH 5/5] KVM: PPC: Book3S HV: Provide a method for userspace to read and write the HPT
Date: Wed, 17 Oct 2012 12:27:47 +0200 [thread overview]
Message-ID: <507E8823.3090006@redhat.com> (raw)
In-Reply-To: <87txtuyykr.fsf@codemonkey.ws>
On 10/16/2012 10:03 PM, Anthony Liguori wrote:
>>
>> This forces userspace to dedicate a thread for the HPT.
>
> If no changes are available, does read return a size > 0? I don't think
> it's necessary to support polling. The kernel should always be able to
> respond to userspace here. The only catch is whether to return !0 read
> sizes when there are no changes.
>
> At any case, I can't see why a dedicated thread is needed. QEMU is
> going to poll HPT based on how fast we can send data over the wire.
That means spinning if we can send the data faster than we dirty it.
But we do that anyway for memory.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-10-17 10:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 3:58 [PATCH 0/5] KVM: PPC: Book3S HV: HPT read/write functions for userspace Paul Mackerras
2012-10-16 3:58 ` Paul Mackerras
2012-10-16 3:59 ` [PATCH 1/5] KVM: Provide mmu notifier retry test based on struct kvm Paul Mackerras
2012-10-16 3:59 ` Paul Mackerras
2012-10-16 9:44 ` Avi Kivity
2012-10-16 9:44 ` Avi Kivity
2012-10-16 10:06 ` Alexander Graf
2012-10-16 10:06 ` Alexander Graf
2012-10-16 4:00 ` [PATCH 2/5] KVM: PPC: Book3S HV: Restructure HPT entry creation code Paul Mackerras
2012-10-16 4:00 ` Paul Mackerras
2012-10-16 4:00 ` [PATCH 3/5] KVM: PPC: Book3S HV: Add a mechanism for recording modified HPTEs Paul Mackerras
2012-10-16 4:00 ` Paul Mackerras
2012-10-16 4:01 ` [PATCH 4/5] KVM: PPC: Book3S HV: Make a HPTE removal function available Paul Mackerras
2012-10-16 4:01 ` Paul Mackerras
2012-10-16 4:01 ` [PATCH 5/5] KVM: PPC: Book3S HV: Provide a method for userspace to read and write the HPT Paul Mackerras
2012-10-16 4:01 ` Paul Mackerras
2012-10-16 10:06 ` Avi Kivity
2012-10-16 10:06 ` Avi Kivity
2012-10-16 11:58 ` Paul Mackerras
2012-10-16 11:58 ` Paul Mackerras
2012-10-16 13:06 ` Avi Kivity
2012-10-16 13:06 ` Avi Kivity
2012-10-16 20:03 ` Anthony Liguori
2012-10-16 20:03 ` Anthony Liguori
2012-10-17 10:27 ` Avi Kivity [this message]
2012-10-17 10:27 ` Avi Kivity
2012-10-16 21:52 ` Paul Mackerras
2012-10-16 21:52 ` Paul Mackerras
2012-10-17 10:31 ` Avi Kivity
2012-10-17 10:31 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507E8823.3090006@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=owasserm@redhat.com \
--cc=paulus@samba.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.