* [Xenomai] [PATCH] can: Let Flexcan driver depend on platform support
@ 2012-10-17 11:20 Jan Kiszka
2012-10-17 11:22 ` Gilles Chanteperdrix
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2012-10-17 11:20 UTC (permalink / raw)
To: Xenomai; +Cc: Wolfgang Grandegger
Just like the Linux version does, let our RT Flexcan driver depend on
CONFIG_HAVE_CAN_FLEXCAN so that it can only be selected on platforms
that actually support it.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
ksrc/drivers/can/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ksrc/drivers/can/Kconfig b/ksrc/drivers/can/Kconfig
index 216b807..ce411dd 100644
--- a/ksrc/drivers/can/Kconfig
+++ b/ksrc/drivers/can/Kconfig
@@ -80,7 +80,7 @@ config XENO_DRIVERS_CAN_VIRT
More ports can be enabled with the module parameter "devices".
config XENO_DRIVERS_CAN_FLEXCAN
- depends on XENO_DRIVERS_CAN && !XENO_DRIVERS_CAN_CALC_BITTIME_OLD
+ depends on XENO_DRIVERS_CAN && HAVE_CAN_FLEXCAN && !XENO_DRIVERS_CAN_CALC_BITTIME_OLD
tristate "Freescale FLEXCAN based chips"
help
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Xenomai] [PATCH] can: Let Flexcan driver depend on platform support
2012-10-17 11:20 [Xenomai] [PATCH] can: Let Flexcan driver depend on platform support Jan Kiszka
@ 2012-10-17 11:22 ` Gilles Chanteperdrix
2012-10-17 11:27 ` Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Gilles Chanteperdrix @ 2012-10-17 11:22 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Wolfgang Grandegger, Xenomai
On 10/17/2012 01:20 PM, Jan Kiszka wrote:
> Just like the Linux version does, let our RT Flexcan driver depend on
> CONFIG_HAVE_CAN_FLEXCAN so that it can only be selected on platforms
> that actually support it.
Do all old kernels for CPUs which have a flexcan controller have this
symbol defined?
--
Gilles.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Xenomai] [PATCH] can: Let Flexcan driver depend on platform support
2012-10-17 11:22 ` Gilles Chanteperdrix
@ 2012-10-17 11:27 ` Jan Kiszka
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kiszka @ 2012-10-17 11:27 UTC (permalink / raw)
To: Gilles Chanteperdrix; +Cc: Wolfgang Grandegger, Xenomai
On 2012-10-17 13:22, Gilles Chanteperdrix wrote:
> On 10/17/2012 01:20 PM, Jan Kiszka wrote:
>
>> Just like the Linux version does, let our RT Flexcan driver depend on
>> CONFIG_HAVE_CAN_FLEXCAN so that it can only be selected on platforms
>> that actually support it.
>
>
> Do all old kernels for CPUs which have a flexcan controller have this
> symbol defined?
That's a question for Wolfgang. We briefly discussed this yesterday, and
that dependency appeared reasonable on first glance.
The platform has to provide at least CONFIG_OF. So that could be plan B
in case HAVE_CAN_FLEXCAN is too strict.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-17 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-17 11:20 [Xenomai] [PATCH] can: Let Flexcan driver depend on platform support Jan Kiszka
2012-10-17 11:22 ` Gilles Chanteperdrix
2012-10-17 11:27 ` Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.