All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Vinod Koul <vinod.koul-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: djbw-b10kYP2dOMg@public.gmane.org,
	khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
	w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	lrg-l0cyMroinI0@public.gmane.org,
	broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
	perex-/Fr2/VpizcU@public.gmane.org,
	tiwai-l3A5Bk7waGM@public.gmane.org,
	shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	marex-ynQEQJNshbs@public.gmane.org,
	artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	Huang Shijie <shijie8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] dma: add new DMA control commands
Date: Thu, 18 Oct 2012 14:45:41 +0800	[thread overview]
Message-ID: <507FA595.4020507@freescale.com> (raw)
In-Reply-To: <1350541111.5263.3.camel@vkoul-udesk3>

于 2012年10月18日 14:18, Vinod Koul 写道:
> Why cant you do start (prepare clock etc) when you submit the descriptor
> to dmaengine. Can be done in tx_submit callback.
> Similarly remove the clock when dma transaction gets completed.
I ever thought this method too.

But it will become low efficient in the following case:

   Assuming the gpmi-nand driver has to read out 1024 pages in one 
_SINGLE_ read operation.
The gpmi-nand will submit the descriptor to dmaengine per page. So with 
your method,
the system will repeat the enable/disable dma clock 1024 time. At every 
enable/disable dma clock,
the system has to enable the clock chain and it's parents ...

But with this patch, we only need to enable/disable dma clock one time, 
just at we select the nand chip.

thanks
Huang Shijie

WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: marex@denx.de, Huang Shijie <shijie8@gmail.com>,
	alsa-devel@alsa-project.org, shawn.guo@linaro.org,
	linux@arm.linux.org.uk, tiwai@suse.de,
	artem.bityutskiy@linux.intel.com,
	broonie@opensource.wolfsonmicro.com, linux-mmc@vger.kernel.org,
	w.sang@pengutronix.de, perex@perex.cz,
	linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org,
	ben-linux@fluff.org, djbw@fb.com, khali@linux-fr.org,
	cjb@laptop.org, dwmw2@infradead.org, lrg@ti.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dma: add new DMA control commands
Date: Thu, 18 Oct 2012 14:45:41 +0800	[thread overview]
Message-ID: <507FA595.4020507@freescale.com> (raw)
In-Reply-To: <1350541111.5263.3.camel@vkoul-udesk3>

于 2012年10月18日 14:18, Vinod Koul 写道:
> Why cant you do start (prepare clock etc) when you submit the descriptor
> to dmaengine. Can be done in tx_submit callback.
> Similarly remove the clock when dma transaction gets completed.
I ever thought this method too.

But it will become low efficient in the following case:

   Assuming the gpmi-nand driver has to read out 1024 pages in one 
_SINGLE_ read operation.
The gpmi-nand will submit the descriptor to dmaengine per page. So with 
your method,
the system will repeat the enable/disable dma clock 1024 time. At every 
enable/disable dma clock,
the system has to enable the clock chain and it's parents ...

But with this patch, we only need to enable/disable dma clock one time, 
just at we select the nand chip.

thanks
Huang Shijie

WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: add new DMA control commands
Date: Thu, 18 Oct 2012 14:45:41 +0800	[thread overview]
Message-ID: <507FA595.4020507@freescale.com> (raw)
In-Reply-To: <1350541111.5263.3.camel@vkoul-udesk3>

? 2012?10?18? 14:18, Vinod Koul ??:
> Why cant you do start (prepare clock etc) when you submit the descriptor
> to dmaengine. Can be done in tx_submit callback.
> Similarly remove the clock when dma transaction gets completed.
I ever thought this method too.

But it will become low efficient in the following case:

   Assuming the gpmi-nand driver has to read out 1024 pages in one 
_SINGLE_ read operation.
The gpmi-nand will submit the descriptor to dmaengine per page. So with 
your method,
the system will repeat the enable/disable dma clock 1024 time. At every 
enable/disable dma clock,
the system has to enable the clock chain and it's parents ...

But with this patch, we only need to enable/disable dma clock one time, 
just at we select the nand chip.

thanks
Huang Shijie

WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: <djbw@fb.com>, <khali@linux-fr.org>, <ben-linux@fluff.org>,
	<w.sang@pengutronix.de>, <cjb@laptop.org>, <dwmw2@infradead.org>,
	<lrg@ti.com>, <broonie@opensource.wolfsonmicro.com>,
	<perex@perex.cz>, <tiwai@suse.de>, <shawn.guo@linaro.org>,
	<marex@denx.de>, <artem.bityutskiy@linux.intel.com>,
	<linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
	<linux-mmc@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	<alsa-devel@alsa-project.org>,
	<linux-arm-kernel@lists.infradead.org>, <linux@arm.linux.org.uk>,
	Huang Shijie <shijie8@gmail.com>
Subject: Re: [PATCH] dma: add new DMA control commands
Date: Thu, 18 Oct 2012 14:45:41 +0800	[thread overview]
Message-ID: <507FA595.4020507@freescale.com> (raw)
In-Reply-To: <1350541111.5263.3.camel@vkoul-udesk3>

于 2012年10月18日 14:18, Vinod Koul 写道:
> Why cant you do start (prepare clock etc) when you submit the descriptor
> to dmaengine. Can be done in tx_submit callback.
> Similarly remove the clock when dma transaction gets completed.
I ever thought this method too.

But it will become low efficient in the following case:

   Assuming the gpmi-nand driver has to read out 1024 pages in one 
_SINGLE_ read operation.
The gpmi-nand will submit the descriptor to dmaengine per page. So with 
your method,
the system will repeat the enable/disable dma clock 1024 time. At every 
enable/disable dma clock,
the system has to enable the clock chain and it's parents ...

But with this patch, we only need to enable/disable dma clock one time, 
just at we select the nand chip.

thanks
Huang Shijie





  reply	other threads:[~2012-10-18  6:45 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  5:32 [PATCH] dma: add new DMA control commands Huang Shijie
2012-10-18  5:32 ` Huang Shijie
2012-10-18  5:32 ` Huang Shijie
2012-10-18  5:32 ` Huang Shijie
2012-10-18  6:18 ` Vinod Koul
2012-10-18  6:18   ` Vinod Koul
2012-10-18  6:18   ` Vinod Koul
2012-10-18  6:45   ` Huang Shijie [this message]
2012-10-18  6:45     ` Huang Shijie
2012-10-18  6:45     ` Huang Shijie
2012-10-18  6:45     ` Huang Shijie
     [not found]     ` <507FA595.4020507-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-10-18  7:14       ` Marek Vasut
2012-10-18  7:14         ` Marek Vasut
2012-10-18  7:14         ` Marek Vasut
2012-10-18  7:14         ` Marek Vasut
2012-10-18  7:49         ` Huang Shijie
2012-10-18  7:49           ` Huang Shijie
2012-10-18  7:49           ` Huang Shijie
2012-10-18  7:49           ` Huang Shijie
     [not found]           ` <507FB495.7050104-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-10-18  8:16             ` Marek Vasut
2012-10-18  8:16               ` Marek Vasut
2012-10-18  8:16               ` Marek Vasut
2012-10-18  8:16               ` Marek Vasut
2012-10-18  8:29               ` Huang Shijie
2012-10-18  8:29                 ` Huang Shijie
2012-10-18  8:29                 ` Huang Shijie
2012-10-18  8:29                 ` Huang Shijie
2012-11-09 15:29                 ` Artem Bityutskiy
2012-11-09 15:29                   ` Artem Bityutskiy
2012-11-09 15:29                   ` Artem Bityutskiy
2012-10-18  8:49               ` Huang Shijie
2012-10-18  8:49                 ` Huang Shijie
2012-10-18  8:49                 ` Huang Shijie
2012-10-18  8:49                 ` Huang Shijie
     [not found]                 ` <507FC290.10205-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-10-18  8:49                   ` Marek Vasut
2012-10-18  8:49                     ` Marek Vasut
2012-10-18  8:49                     ` Marek Vasut
2012-10-18  8:49                     ` Marek Vasut
2012-10-18  9:13                     ` Huang Shijie
2012-10-18  9:13                       ` Huang Shijie
2012-10-18  9:13                       ` Huang Shijie
2012-10-18  9:13                       ` Huang Shijie
     [not found]                       ` <507FC827.40601-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-10-18 10:51                         ` Marek Vasut
2012-10-18 10:51                           ` Marek Vasut
2012-10-18 10:51                           ` Marek Vasut
2012-10-18 10:51                           ` Marek Vasut
     [not found]                           ` <201210181251.15116.marex-ynQEQJNshbs@public.gmane.org>
2012-10-18 15:11                             ` Huang Shijie
2012-10-18 15:11                               ` Huang Shijie
2012-10-18 15:11                               ` Huang Shijie
2012-10-18 15:11                               ` Huang Shijie
2012-10-18  8:52     ` Russell King - ARM Linux
2012-10-18  8:52       ` Russell King - ARM Linux
2012-10-18  8:52       ` Russell King - ARM Linux
     [not found]       ` <20121018085208.GR21164-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-10-18  9:10         ` Huang Shijie
2012-10-18  9:10           ` Huang Shijie
2012-10-18  9:10           ` Huang Shijie
2012-10-18  9:10           ` Huang Shijie
2012-10-18  9:29     ` Jassi Brar
2012-10-18  9:29       ` Jassi Brar
2012-10-18  9:29       ` Jassi Brar
2012-10-18 15:18       ` Huang Shijie
2012-10-18 15:18         ` Huang Shijie
2012-10-18 15:18         ` Huang Shijie
2012-10-18 15:25         ` Jassi Brar
2012-10-18 15:25           ` Jassi Brar
2012-10-18 15:25           ` Jassi Brar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507FA595.4020507@freescale.com \
    --to=b32955-kzfg59tc24xl57midrcfdg@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
    --cc=djbw-b10kYP2dOMg@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=lrg-l0cyMroinI0@public.gmane.org \
    --cc=marex-ynQEQJNshbs@public.gmane.org \
    --cc=perex-/Fr2/VpizcU@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=shijie8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tiwai-l3A5Bk7waGM@public.gmane.org \
    --cc=vinod.koul-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.