From: Li Zefan <lizefan@huawei.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <bsingharora@gmail.com>
Subject: Re: [PATCH 5/6] memcg: make mem_cgroup_reparent_charges non failing
Date: Thu, 18 Oct 2012 16:30:19 +0800 [thread overview]
Message-ID: <507FBE1B.4080906@huawei.com> (raw)
In-Reply-To: <1350480648-10905-6-git-send-email-mhocko@suse.cz>
> static int mem_cgroup_force_empty_write(struct cgroup *cont, unsigned int event)
> @@ -5013,13 +5011,9 @@ free_out:
> static int mem_cgroup_pre_destroy(struct cgroup *cont)
> {
> struct mem_cgroup *memcg = mem_cgroup_from_cont(cont);
> - int ret;
>
> - css_get(&memcg->css);
> - ret = mem_cgroup_reparent_charges(memcg);
> - css_put(&memcg->css);
> -
> - return ret;
> + mem_cgroup_reparent_charges(memcg);
> + return 0;
> }
>
Why don't you make pre_destroy() return void?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: <linux-mm@kvack.org>, <cgroups@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <bsingharora@gmail.com>
Subject: Re: [PATCH 5/6] memcg: make mem_cgroup_reparent_charges non failing
Date: Thu, 18 Oct 2012 16:30:19 +0800 [thread overview]
Message-ID: <507FBE1B.4080906@huawei.com> (raw)
In-Reply-To: <1350480648-10905-6-git-send-email-mhocko@suse.cz>
> static int mem_cgroup_force_empty_write(struct cgroup *cont, unsigned int event)
> @@ -5013,13 +5011,9 @@ free_out:
> static int mem_cgroup_pre_destroy(struct cgroup *cont)
> {
> struct mem_cgroup *memcg = mem_cgroup_from_cont(cont);
> - int ret;
>
> - css_get(&memcg->css);
> - ret = mem_cgroup_reparent_charges(memcg);
> - css_put(&memcg->css);
> -
> - return ret;
> + mem_cgroup_reparent_charges(memcg);
> + return 0;
> }
>
Why don't you make pre_destroy() return void?
next prev parent reply other threads:[~2012-10-18 8:30 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 13:30 [RFC] memcg/cgroup: do not fail fail on pre_destroy callbacks Michal Hocko
2012-10-17 13:30 ` Michal Hocko
2012-10-17 13:30 ` [PATCH 1/6] memcg: split mem_cgroup_force_empty into reclaiming and reparenting parts Michal Hocko
2012-10-17 13:30 ` Michal Hocko
2012-10-18 21:56 ` Tejun Heo
2012-10-18 21:56 ` Tejun Heo
2012-10-17 13:30 ` [PATCH 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent Michal Hocko
2012-10-17 13:30 ` Michal Hocko
[not found] ` <1350480648-10905-3-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-18 21:58 ` Tejun Heo
2012-10-18 21:58 ` Tejun Heo
2012-10-18 21:58 ` Tejun Heo
2012-10-17 13:30 ` [PATCH 3/6] memcg: Simplify mem_cgroup_force_empty_list error handling Michal Hocko
2012-10-17 13:30 ` Michal Hocko
2012-10-18 22:16 ` Tejun Heo
2012-10-18 22:16 ` Tejun Heo
[not found] ` <20121018221654.GP13370-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-10-19 13:24 ` Michal Hocko
2012-10-19 13:24 ` Michal Hocko
2012-10-19 13:24 ` Michal Hocko
[not found] ` <20121019132438.GD799-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-10-19 19:49 ` Tejun Heo
2012-10-19 19:49 ` Tejun Heo
2012-10-19 19:49 ` Tejun Heo
2012-10-17 13:30 ` [PATCH 4/6] cgroups: forbid pre_destroy callback to fail Michal Hocko
2012-10-17 13:30 ` Michal Hocko
2012-10-18 22:41 ` Tejun Heo
2012-10-18 22:41 ` Tejun Heo
[not found] ` <20121018224148.GR13370-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-10-18 22:46 ` Tejun Heo
2012-10-18 22:46 ` Tejun Heo
2012-10-18 22:46 ` Tejun Heo
[not found] ` <20121018224606.GS13370-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-10-19 13:34 ` Michal Hocko
2012-10-19 13:34 ` Michal Hocko
2012-10-19 13:34 ` Michal Hocko
2012-10-19 13:32 ` Michal Hocko
2012-10-19 13:32 ` Michal Hocko
2012-10-19 13:32 ` Michal Hocko
[not found] ` <20121019133244.GE799-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-10-19 20:24 ` Tejun Heo
2012-10-19 20:24 ` Tejun Heo
2012-10-19 20:24 ` Tejun Heo
[not found] ` <20121019202405.GR13370-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-10-22 10:30 ` Michal Hocko
2012-10-22 10:30 ` Michal Hocko
2012-10-22 10:30 ` Michal Hocko
2012-10-24 19:25 ` Tejun Heo
2012-10-24 19:25 ` Tejun Heo
[not found] ` <20121024192535.GG12182-OlzNCW9NnSVy/B6EtB590w@public.gmane.org>
2012-10-25 14:37 ` Michal Hocko
2012-10-25 14:37 ` Michal Hocko
2012-10-25 14:37 ` Michal Hocko
[not found] ` <20121025143756.GI11105-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-10-25 17:42 ` Tejun Heo
2012-10-25 17:42 ` Tejun Heo
2012-10-25 17:42 ` Tejun Heo
2012-10-25 18:48 ` Michal Hocko
2012-10-25 18:48 ` Michal Hocko
2012-10-19 9:33 ` Li Zefan
2012-10-19 9:33 ` Li Zefan
[not found] ` <50811E5E.1090205-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-10-19 11:09 ` Michal Hocko
2012-10-19 11:09 ` Michal Hocko
2012-10-19 11:09 ` Michal Hocko
2012-10-19 20:17 ` Tejun Heo
2012-10-19 20:17 ` Tejun Heo
2012-10-19 20:17 ` Tejun Heo
2012-10-17 13:30 ` [PATCH 5/6] memcg: make mem_cgroup_reparent_charges non failing Michal Hocko
2012-10-17 13:30 ` Michal Hocko
2012-10-18 8:30 ` Li Zefan [this message]
2012-10-18 8:30 ` Li Zefan
2012-10-18 8:42 ` Michal Hocko
2012-10-18 8:42 ` Michal Hocko
2012-10-18 22:48 ` Tejun Heo
2012-10-18 22:48 ` Tejun Heo
2012-10-19 13:49 ` Michal Hocko
2012-10-19 13:49 ` Michal Hocko
2012-10-19 13:49 ` Michal Hocko
2012-10-17 13:30 ` [PATCH 6/6] hugetlb: do not fail in hugetlb_cgroup_pre_destroy Michal Hocko
2012-10-17 13:30 ` Michal Hocko
[not found] ` <1350480648-10905-7-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-18 22:48 ` Tejun Heo
2012-10-18 22:48 ` Tejun Heo
2012-10-18 22:48 ` Tejun Heo
2012-10-17 15:30 ` [RFC] memcg/cgroup: do not fail fail on pre_destroy callbacks Glauber Costa
2012-10-17 15:30 ` Glauber Costa
[not found] ` <1350480648-10905-1-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-18 0:29 ` Kamezawa Hiroyuki
2012-10-18 0:29 ` Kamezawa Hiroyuki
2012-10-18 0:29 ` Kamezawa Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507FBE1B.4080906@huawei.com \
--to=lizefan@huawei.com \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.