From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 9/9] OMAPDSS: DISPC: cleanup lcd/digit enable/disable
Date: Thu, 18 Oct 2012 10:09:40 +0000 [thread overview]
Message-ID: <507FD564.6000806@ti.com> (raw)
In-Reply-To: <507EC2EA.4000402@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
On 2012-10-17 17:38, Archit Taneja wrote:
> Hi,
>
> On Wednesday 17 October 2012 04:50 PM, Tomi Valkeinen wrote:
>> - if (r)
>> - DSSERR("failed to register FRAMEDONE isr\n");
>> + /* if we couldn't register for framedone, just sleep and exit */
>> + if (r) {
>> + msleep(200);
>
> We sleep for 200 ms if we fail to register for framedone. But we just
> wait for 100ms for FRAMEDONE to occur. It seems a bit incorrect, both
> should be kept the same, shouldn't they?
They are just arbitrary numbers, but you're right, it makes more sense
to have same numbers for both.
>> - r = omap_dispc_register_isr(dispc_disable_isr,
>> &frame_done_completion,
>> + r = omap_dispc_register_isr(dispc_mgr_disable_isr, &framedone_compl,
>> irq_mask);
>> if (r)
>> DSSERR("failed to register %x isr\n", irq_mask);
>
> We should probably sleep here too as we did for LCD above.
Yep, good point. I'll add that.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 9/9] OMAPDSS: DISPC: cleanup lcd/digit enable/disable
Date: Thu, 18 Oct 2012 13:09:40 +0300 [thread overview]
Message-ID: <507FD564.6000806@ti.com> (raw)
In-Reply-To: <507EC2EA.4000402@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
On 2012-10-17 17:38, Archit Taneja wrote:
> Hi,
>
> On Wednesday 17 October 2012 04:50 PM, Tomi Valkeinen wrote:
>> - if (r)
>> - DSSERR("failed to register FRAMEDONE isr\n");
>> + /* if we couldn't register for framedone, just sleep and exit */
>> + if (r) {
>> + msleep(200);
>
> We sleep for 200 ms if we fail to register for framedone. But we just
> wait for 100ms for FRAMEDONE to occur. It seems a bit incorrect, both
> should be kept the same, shouldn't they?
They are just arbitrary numbers, but you're right, it makes more sense
to have same numbers for both.
>> - r = omap_dispc_register_isr(dispc_disable_isr,
>> &frame_done_completion,
>> + r = omap_dispc_register_isr(dispc_mgr_disable_isr, &framedone_compl,
>> irq_mask);
>> if (r)
>> DSSERR("failed to register %x isr\n", irq_mask);
>
> We should probably sleep here too as we did for LCD above.
Yep, good point. I'll add that.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]
next prev parent reply other threads:[~2012-10-18 10:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 11:20 [PATCH 0/9] OMAPDSS: minor fixes & cleanups Tomi Valkeinen
2012-10-17 11:20 ` Tomi Valkeinen
2012-10-17 11:20 ` [PATCH 1/9] OMAPDSS: DSI: fix dsi_get_dsidev_from_id() Tomi Valkeinen
2012-10-17 11:20 ` Tomi Valkeinen
2012-10-17 11:20 ` [PATCH 2/9] OMAPDSS: fix registering the vsync isr in apply Tomi Valkeinen
2012-10-17 11:20 ` Tomi Valkeinen
2012-10-17 11:20 ` [PATCH 3/9] OMAPDSS: DISPC: constify function parameters Tomi Valkeinen
2012-10-17 11:20 ` Tomi Valkeinen
2012-10-17 11:20 ` [PATCH 4/9] OMAPDSS: combine LCD related config into one func Tomi Valkeinen
2012-10-17 11:20 ` Tomi Valkeinen
2012-10-17 11:20 ` [PATCH 5/9] OMAPDSS: remove declarations for non-existing funcs Tomi Valkeinen
2012-10-17 11:20 ` Tomi Valkeinen
2012-10-17 11:20 ` [PATCH 6/9] OMAPDSS: DISPC: remove struct omap_overlay use Tomi Valkeinen
2012-10-17 11:20 ` Tomi Valkeinen
2012-10-17 11:20 ` [PATCH 7/9] OMAPDSS: DISPC: cleanup lcd and digit enable Tomi Valkeinen
2012-10-17 11:20 ` Tomi Valkeinen
2012-10-17 11:20 ` [PATCH 8/9] OMAPDSS: DISPC: add dispc_mgr_get_sync_lost_irq() Tomi Valkeinen
2012-10-17 11:20 ` Tomi Valkeinen
2012-10-17 11:20 ` [PATCH 9/9] OMAPDSS: DISPC: cleanup lcd/digit enable/disable Tomi Valkeinen
2012-10-17 11:20 ` Tomi Valkeinen
2012-10-17 14:38 ` Archit Taneja
2012-10-17 14:50 ` Archit Taneja
2012-10-18 10:09 ` Tomi Valkeinen [this message]
2012-10-18 10:09 ` Tomi Valkeinen
2012-10-22 5:48 ` [PATCH 0/9] OMAPDSS: minor fixes & cleanups Archit Taneja
2012-10-22 5:48 ` Archit Taneja
2012-10-22 6:54 ` Tomi Valkeinen
2012-10-22 6:54 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507FD564.6000806@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.