From: Stefan Bader <stefan.bader@canonical.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Xen PVM: Strange lockups when running PostgreSQL load
Date: Thu, 18 Oct 2012 14:43:16 +0200 [thread overview]
Message-ID: <507FF964.9090009@canonical.com> (raw)
In-Reply-To: <507FFA5102000078000A250D@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1347 bytes --]
On 18.10.2012 12:47, Jan Beulich wrote:
>>>> On 18.10.12 at 12:20, Stefan Bader <stefan.bader@canonical.com> wrote:
>> On 18.10.2012 09:48, Ian Campbell wrote:
>>> spinning_lock() returns the old lock which the caller is expected to
>>> remember and replace via unspinning_lock() -- it effectively implements
>>> a stack of locks which are being waited on. xen_spin_lock_slow (the only
>>> caller0 appears to do this correctly from a brief inspection.
>>
>> Yes, just *when* can there be a stack of locks (spinlocks). The poll_irq
>> hypercall seems to be an active (in the sense of not preemting to another
>> task)
>> process. How could there be a situation that another lock (on the same cpu
>> is tried to be taken).
>
> Obviously when this is an acquire not disabling interrupts, and
> an interrupt comes in while in the poll hypercall (or about to go
> there, or just having come back from one).
>
> Jan
>
Obviously. ;) Ok, so my thinking there was ok and its one level deep max. At
some point staring at things I start question my sanity.
A wild thinking would be whether in that case the interrupted spinlock may miss
a wakeup forever when the unlocker only can check for the toplevel. Hm, but that
should be easy to rule out by just adding an error to spin_unlock_slow when it
fails to find anything...
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-10-18 12:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 13:10 Xen PVM: Strange lockups when running PostgreSQL load Stefan Bader
2012-10-17 13:28 ` Andrew Cooper
2012-10-17 13:45 ` Stefan Bader
2012-10-17 13:55 ` Ian Campbell
2012-10-17 15:21 ` Stefan Bader
2012-10-17 15:35 ` Andrew Cooper
2012-10-17 16:27 ` Stefan Bader
2012-10-17 17:46 ` Andrew Cooper
2012-10-18 7:00 ` Jan Beulich
2012-10-18 7:08 ` Jan Beulich
2012-10-18 7:38 ` Stefan Bader
2012-10-18 7:48 ` Ian Campbell
2012-10-18 10:20 ` Stefan Bader
2012-10-18 10:47 ` Jan Beulich
2012-10-18 12:43 ` Stefan Bader [this message]
2012-10-18 20:52 ` Stefan Bader
2012-10-19 7:10 ` Stefan Bader
2012-10-19 8:06 ` Jan Beulich
2012-10-19 8:33 ` Stefan Bader
2012-10-19 9:24 ` Jan Beulich
2012-10-19 14:03 ` Stefan Bader
2012-10-19 14:49 ` Jan Beulich
2012-10-19 14:57 ` Stefan Bader
2012-10-19 15:08 ` Jan Beulich
2012-10-19 15:21 ` Stefan Bader
2012-10-19 15:33 ` Jan Beulich
2012-10-18 7:24 ` Stefan Bader
2012-10-17 14:51 ` Jan Beulich
2012-10-17 15:12 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507FF964.9090009@canonical.com \
--to=stefan.bader@canonical.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.