From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH] KVM: do not de-cache cr4 bits needlessly
Date: Thu, 18 Oct 2012 14:49:40 +0200 [thread overview]
Message-ID: <507FFAE4.8000109@redhat.com> (raw)
In-Reply-To: <20121015074907.GB20788@redhat.com>
On 10/15/2012 09:49 AM, Gleb Natapov wrote:
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index e9c83b1..3df12c8 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -635,7 +635,7 @@ int kvm_set_cr3(struct kvm_vcpu *vcpu, unsigned long cr3)
> }
>
> if (is_long_mode(vcpu)) {
> - if (kvm_read_cr4(vcpu) & X86_CR4_PCIDE) {
> + if (kvm_read_cr4_bits(vcpu, X86_CR4_PCIDE)) {
> if (cr3 & CR3_PCID_ENABLED_RESERVED_BITS)
> return 1;
> } else
Applied, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2012-10-18 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 7:49 [PATCH] KVM: do not de-cache cr4 bits needlessly Gleb Natapov
2012-10-18 12:49 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507FFAE4.8000109@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.