From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-trivial] [PATCH v2] ui/vnc-jobs.c: Fix minor typos in comments
Date: Thu, 18 Oct 2012 18:53:35 +0200 [thread overview]
Message-ID: <5080340F.8000205@weilnetz.de> (raw)
In-Reply-To: <1350578453-24368-1-git-send-email-peter.maydell@linaro.org>
Am 18.10.2012 18:40, schrieb Peter Maydell:
> Fix some minor typos/grammar errors in comments.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> v1->v2: reinstated carelessly dropped 'if', noted by Stefan Weil.
>
> ui/vnc-jobs.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
> index 087b84d..3c592b3 100644
> --- a/ui/vnc-jobs.c
> +++ b/ui/vnc-jobs.c
> @@ -33,21 +33,21 @@
> /*
> * Locking:
> *
> - * There is three levels of locking:
> + * There are three levels of locking:
> * - jobs queue lock: for each operation on the queue (push, pop, isEmpty?)
> * - VncDisplay global lock: mainly used for framebuffer updates to avoid
> * screen corruption if the framebuffer is updated
> - * while the worker is doing something.
> + * while the worker is doing something.
> * - VncState::output lock: used to make sure the output buffer is not corrupted
> - * if two threads try to write on it at the same time
> + * if two threads try to write on it at the same time
> *
> - * While the VNC worker thread is working, the VncDisplay global lock is hold
> - * to avoid screen corruptions (this does not block vnc_refresh() because it
> - * uses trylock()) but the output lock is not hold because the thread work on
> + * While the VNC worker thread is working, the VncDisplay global lock is held
> + * to avoid screen corruption (this does not block vnc_refresh() because it
> + * uses trylock()) but the output lock is not held because the thread works on
> * its own output buffer.
> * When the encoding job is done, the worker thread will hold the output lock
> * and copy its output buffer in vs->output.
> -*/
> + */
>
> struct VncJobQueue {
> QemuCond cond;
> @@ -62,7 +62,7 @@ typedef struct VncJobQueue VncJobQueue;
>
> /*
> * We use a single global queue, but most of the functions are
> - * already reetrant, so we can easilly add more than one encoding thread
> + * already reentrant, so we can easily add more than one encoding thread
> */
> static VncJobQueue *queue;
>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] ui/vnc-jobs.c: Fix minor typos in comments
Date: Thu, 18 Oct 2012 18:53:35 +0200 [thread overview]
Message-ID: <5080340F.8000205@weilnetz.de> (raw)
In-Reply-To: <1350578453-24368-1-git-send-email-peter.maydell@linaro.org>
Am 18.10.2012 18:40, schrieb Peter Maydell:
> Fix some minor typos/grammar errors in comments.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> v1->v2: reinstated carelessly dropped 'if', noted by Stefan Weil.
>
> ui/vnc-jobs.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
> index 087b84d..3c592b3 100644
> --- a/ui/vnc-jobs.c
> +++ b/ui/vnc-jobs.c
> @@ -33,21 +33,21 @@
> /*
> * Locking:
> *
> - * There is three levels of locking:
> + * There are three levels of locking:
> * - jobs queue lock: for each operation on the queue (push, pop, isEmpty?)
> * - VncDisplay global lock: mainly used for framebuffer updates to avoid
> * screen corruption if the framebuffer is updated
> - * while the worker is doing something.
> + * while the worker is doing something.
> * - VncState::output lock: used to make sure the output buffer is not corrupted
> - * if two threads try to write on it at the same time
> + * if two threads try to write on it at the same time
> *
> - * While the VNC worker thread is working, the VncDisplay global lock is hold
> - * to avoid screen corruptions (this does not block vnc_refresh() because it
> - * uses trylock()) but the output lock is not hold because the thread work on
> + * While the VNC worker thread is working, the VncDisplay global lock is held
> + * to avoid screen corruption (this does not block vnc_refresh() because it
> + * uses trylock()) but the output lock is not held because the thread works on
> * its own output buffer.
> * When the encoding job is done, the worker thread will hold the output lock
> * and copy its output buffer in vs->output.
> -*/
> + */
>
> struct VncJobQueue {
> QemuCond cond;
> @@ -62,7 +62,7 @@ typedef struct VncJobQueue VncJobQueue;
>
> /*
> * We use a single global queue, but most of the functions are
> - * already reetrant, so we can easilly add more than one encoding thread
> + * already reentrant, so we can easily add more than one encoding thread
> */
> static VncJobQueue *queue;
>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
next prev parent reply other threads:[~2012-10-18 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 16:40 [Qemu-trivial] [PATCH v2] ui/vnc-jobs.c: Fix minor typos in comments Peter Maydell
2012-10-18 16:40 ` [Qemu-devel] " Peter Maydell
2012-10-18 16:53 ` Stefan Weil [this message]
2012-10-18 16:53 ` Stefan Weil
2012-10-19 8:42 ` [Qemu-trivial] " Stefan Hajnoczi
2012-10-19 8:42 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5080340F.8000205@weilnetz.de \
--to=sw@weilnetz.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.