From: James Hogan <james.hogan@imgtec.com>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Ben Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [RESEND PATCH 4/4] net: smc91x: use io{read,write}*_rep accessors instead of string functions
Date: Fri, 19 Oct 2012 09:25:48 +0100 [thread overview]
Message-ID: <50810E8C.5010806@imgtec.com> (raw)
In-Reply-To: <1350488704-3711-5-git-send-email-will.deacon@arm.com>
On 17/10/12 16:45, Will Deacon wrote:
> The {read,write}s{b,w,l} operations are not defined by all architectures
> and are being removed from the asm-generic/io.h interface.
>
> This patch replaces the usage of these string functions in the default
> SMC accessors with io{read,write}{8,16,32}_rep calls instead, which are
> defined for all architectures.
Hi,
Should this patch (and the mmc one) precede patch 1?
Also there appear to be some other places that it's used (e.g.
smsc911x.c and smc911x.h). I guess these should be fixed up first too?
Cheers
James
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Will Deacon <will.deacon@arm.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-arch@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
Ben Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [RESEND PATCH 4/4] net: smc91x: use io{read,write}*_rep accessors instead of string functions
Date: Fri, 19 Oct 2012 09:25:48 +0100 [thread overview]
Message-ID: <50810E8C.5010806@imgtec.com> (raw)
In-Reply-To: <1350488704-3711-5-git-send-email-will.deacon@arm.com>
On 17/10/12 16:45, Will Deacon wrote:
> The {read,write}s{b,w,l} operations are not defined by all architectures
> and are being removed from the asm-generic/io.h interface.
>
> This patch replaces the usage of these string functions in the default
> SMC accessors with io{read,write}{8,16,32}_rep calls instead, which are
> defined for all architectures.
Hi,
Should this patch (and the mmc one) precede patch 1?
Also there appear to be some other places that it's used (e.g.
smsc911x.c and smc911x.h). I guess these should be fixed up first too?
Cheers
James
next prev parent reply other threads:[~2012-10-19 8:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 15:45 [RESEND PATCH 0/4] Fix endianness of generic I/O accessors Will Deacon
2012-10-17 15:45 ` [RESEND PATCH 1/4] asm-generic: io: remove {read,write} string functions Will Deacon
2012-10-26 13:29 ` Arnd Bergmann
2012-10-26 13:38 ` Will Deacon
2012-10-17 15:45 ` [RESEND PATCH 2/4] asm-generic: io: don't perform swab during {in,out} " Will Deacon
2012-10-17 19:16 ` Geert Uytterhoeven
2012-10-18 0:04 ` Benjamin Herrenschmidt
2012-10-18 5:48 ` Geert Uytterhoeven
2012-10-19 12:53 ` Will Deacon
2012-10-23 1:25 ` Benjamin Herrenschmidt
2012-10-28 9:28 ` Geert Uytterhoeven
2012-10-28 20:38 ` Benjamin Herrenschmidt
2012-10-18 0:01 ` Benjamin Herrenschmidt
2012-10-17 15:45 ` [RESEND PATCH 3/4] mmc: mmci: use io{read,write}*_rep accessors instead of " Will Deacon
2012-10-17 15:45 ` [RESEND PATCH 4/4] net: smc91x: " Will Deacon
2012-10-19 8:25 ` James Hogan [this message]
2012-10-19 8:25 ` James Hogan
2012-10-19 9:27 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50810E8C.5010806@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.