From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 3/5] ARM: tegra: fix clock entry of slink controller
Date: Fri, 19 Oct 2012 14:43:50 +0530 [thread overview]
Message-ID: <508119CE.9070408@nvidia.com> (raw)
In-Reply-To: <5080862C.9030203-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Friday 19 October 2012 04:13 AM, Stephen Warren wrote:
>
> The patch subject isn't entirely accurate here; this patch isn't just
> about fixing clock entries.
>
OK, then will break in two patches.
>
>> + OF_DEV_AUXDATA("nvidia,tegra20-slink", TEGRA_SLINK1_BASE, "spi-tegra-slink.0", NULL),
> Here, can't we just use the existing device names in the clock files...
>
> So we can completely drop the changes to these two files:
>
I want to name the driver as spi-tegra-slink. When we add the sflash spi
driver for tegra20, the driver name will be spi-tegra-sflash.
Also current name is "spi_tegra" I do not want to name with "_". So it
is require to convert as "-".
>> diff --git a/arch/arm/mach-tegra/tegra20_clocks_data.c b/arch/arm/mach-tegra/tegra20_clocks_data.c
>> diff --git a/arch/arm/mach-tegra/tegra30_clocks_data.c b/arch/arm/mach-tegra/tegra30_clocks_data.c
> The device names will hopefully be irrelevant once we're able to use
> DT-based clock lookups.
Agree, but currently we can add this to have progress.
WARNING: multiple messages have this Message-ID (diff)
From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: tegra: fix clock entry of slink controller
Date: Fri, 19 Oct 2012 14:43:50 +0530 [thread overview]
Message-ID: <508119CE.9070408@nvidia.com> (raw)
In-Reply-To: <5080862C.9030203@wwwdotorg.org>
On Friday 19 October 2012 04:13 AM, Stephen Warren wrote:
>
> The patch subject isn't entirely accurate here; this patch isn't just
> about fixing clock entries.
>
OK, then will break in two patches.
>
>> + OF_DEV_AUXDATA("nvidia,tegra20-slink", TEGRA_SLINK1_BASE, "spi-tegra-slink.0", NULL),
> Here, can't we just use the existing device names in the clock files...
>
> So we can completely drop the changes to these two files:
>
I want to name the driver as spi-tegra-slink. When we add the sflash spi
driver for tegra20, the driver name will be spi-tegra-sflash.
Also current name is "spi_tegra" I do not want to name with "_". So it
is require to convert as "-".
>> diff --git a/arch/arm/mach-tegra/tegra20_clocks_data.c b/arch/arm/mach-tegra/tegra20_clocks_data.c
>> diff --git a/arch/arm/mach-tegra/tegra30_clocks_data.c b/arch/arm/mach-tegra/tegra30_clocks_data.c
> The device names will hopefully be irrelevant once we're able to use
> DT-based clock lookups.
Agree, but currently we can add this to have progress.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] ARM: tegra: fix clock entry of slink controller
Date: Fri, 19 Oct 2012 14:43:50 +0530 [thread overview]
Message-ID: <508119CE.9070408@nvidia.com> (raw)
In-Reply-To: <5080862C.9030203@wwwdotorg.org>
On Friday 19 October 2012 04:13 AM, Stephen Warren wrote:
>
> The patch subject isn't entirely accurate here; this patch isn't just
> about fixing clock entries.
>
OK, then will break in two patches.
>
>> + OF_DEV_AUXDATA("nvidia,tegra20-slink", TEGRA_SLINK1_BASE, "spi-tegra-slink.0", NULL),
> Here, can't we just use the existing device names in the clock files...
>
> So we can completely drop the changes to these two files:
>
I want to name the driver as spi-tegra-slink. When we add the sflash spi
driver for tegra20, the driver name will be spi-tegra-sflash.
Also current name is "spi_tegra" I do not want to name with "_". So it
is require to convert as "-".
>> diff --git a/arch/arm/mach-tegra/tegra20_clocks_data.c b/arch/arm/mach-tegra/tegra20_clocks_data.c
>> diff --git a/arch/arm/mach-tegra/tegra30_clocks_data.c b/arch/arm/mach-tegra/tegra30_clocks_data.c
> The device names will hopefully be irrelevant once we're able to use
> DT-based clock lookups.
Agree, but currently we can add this to have progress.
next prev parent reply other threads:[~2012-10-19 9:13 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 10:56 [PATCH 0/5] ARM: tegra: Enable SLINK controller driver Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
[not found] ` <1350557795-31487-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-18 10:56 ` [PATCH 1/5] ARM: tegra: Add slink controller base address Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
[not found] ` <1350557795-31487-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-18 22:39 ` Stephen Warren
2012-10-18 22:39 ` Stephen Warren
2012-10-18 22:39 ` Stephen Warren
[not found] ` <50808526.1080504-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-19 9:06 ` Laxman Dewangan
2012-10-19 9:06 ` Laxman Dewangan
2012-10-19 9:06 ` Laxman Dewangan
2012-10-18 10:56 ` [PATCH 2/5] ARM: tegra: dts: add slink controller dt entry Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
[not found] ` <1350557795-31487-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-18 22:41 ` Stephen Warren
2012-10-18 22:41 ` Stephen Warren
2012-10-18 22:41 ` Stephen Warren
2012-10-19 9:10 ` Laxman Dewangan
2012-10-19 9:10 ` Laxman Dewangan
[not found] ` <5081190D.50200-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-19 15:56 ` Stephen Warren
2012-10-19 15:56 ` Stephen Warren
2012-10-19 15:56 ` Stephen Warren
[not found] ` <50817820.6010301-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-24 3:26 ` Vinod Koul
2012-10-24 3:26 ` Vinod Koul
2012-10-24 3:26 ` Vinod Koul
2012-10-18 10:56 ` [PATCH 3/5] ARM: tegra: fix clock entry of slink controller Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
[not found] ` <1350557795-31487-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-18 22:43 ` Stephen Warren
2012-10-18 22:43 ` Stephen Warren
2012-10-18 22:43 ` Stephen Warren
[not found] ` <5080862C.9030203-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-19 9:13 ` Laxman Dewangan [this message]
2012-10-19 9:13 ` Laxman Dewangan
2012-10-19 9:13 ` Laxman Dewangan
[not found] ` <508119CE.9070408-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-19 15:59 ` Stephen Warren
2012-10-19 15:59 ` Stephen Warren
2012-10-19 15:59 ` Stephen Warren
2012-10-18 10:56 ` [PATCH 4/5] ARM: tegra: dts: cardhu: enable SLINK4 Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
2012-10-18 10:56 ` [PATCH 5/5] ARM: tegra: config: enable spi driver for Tegra SLINK controller Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
2012-10-18 10:56 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508119CE.9070408@nvidia.com \
--to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.