* clvmd always sets debug level to DEBUG_SYSLOG
@ 2012-10-19 12:33 Robert Milasan
2012-10-19 13:39 ` Zdenek Kabelac
0 siblings, 1 reply; 3+ messages in thread
From: Robert Milasan @ 2012-10-19 12:33 UTC (permalink / raw)
To: lvm-devel
Hello,
just realized now that in clvmd.c debugging level is set wrong due to
using the wrong variable in clvmd_set_debug.
If a user run clvmd -d0, usually this means no debugging or DEBUG_OFF,
but 0 argument is saved in debug_arg and debugging level is set using
debug_opt in clvmd_set_debug:
# cat clvmd.c |grep clvmd_set_debug
clvmd_set_debug(debug_opt);
and it suppose to be: clvmd_set_debug(debug_arg)
Here is the patch:
Index: LVM2.2.02.84/daemons/clvmd/clvmd.c
===================================================================
--- LVM2.2.02.84.orig/daemons/clvmd/clvmd.c
+++ LVM2.2.02.84/daemons/clvmd/clvmd.c
@@ -428,7 +428,7 @@ int main(int argc, char *argv[])
if (debug_opt && !check_local_clvmd())
return debug_clvmd(debug_arg, clusterwide_opt)==1?0:1;
- clvmd_set_debug(debug_opt);
+ clvmd_set_debug(debug_arg);
/* Fork into the background (unless requested not to) */
if (!foreground_mode)
Cheers!
--
Robert Milasan
L3 Support Engineer
SUSE Linux (http://www.suse.com)
email: rmilasan at suse.com
GPG fingerprint: B6FE F4A8 0FA3 3040 3402 6FE7 2F64 167C 1909 6D1A
^ permalink raw reply [flat|nested] 3+ messages in thread
* clvmd always sets debug level to DEBUG_SYSLOG
2012-10-19 12:33 clvmd always sets debug level to DEBUG_SYSLOG Robert Milasan
@ 2012-10-19 13:39 ` Zdenek Kabelac
2012-10-19 13:46 ` Robert Milasan
0 siblings, 1 reply; 3+ messages in thread
From: Zdenek Kabelac @ 2012-10-19 13:39 UTC (permalink / raw)
To: lvm-devel
Dne 19.10.2012 14:33, Robert Milasan napsal(a):
> Hello,
> just realized now that in clvmd.c debugging level is set wrong due to
> using the wrong variable in clvmd_set_debug.
>
> If a user run clvmd -d0, usually this means no debugging or DEBUG_OFF,
> but 0 argument is saved in debug_arg and debugging level is set using
> debug_opt in clvmd_set_debug:
>
> # cat clvmd.c |grep clvmd_set_debug
> clvmd_set_debug(debug_opt);
>
> and it suppose to be: clvmd_set_debug(debug_arg)
>
> Here is the patch:
>
Thanks for noticing, the patch (in a bit updated version) pushed upstream.
(https://www.redhat.com/archives/lvm-devel/2012-October/msg00166.html)
Zdenek
^ permalink raw reply [flat|nested] 3+ messages in thread
* clvmd always sets debug level to DEBUG_SYSLOG
2012-10-19 13:39 ` Zdenek Kabelac
@ 2012-10-19 13:46 ` Robert Milasan
0 siblings, 0 replies; 3+ messages in thread
From: Robert Milasan @ 2012-10-19 13:46 UTC (permalink / raw)
To: lvm-devel
On Fri, 19 Oct 2012 15:39:52 +0200
"Zdenek Kabelac" <zkabelac@redhat.com> wrote:
>
> Thanks for noticing, the patch (in a bit updated version) pushed
> upstream.
> (https://www.redhat.com/archives/lvm-devel/2012-October/msg00166.html)
>
> Zdenek
>
> --
> lvm-devel mailing list
> lvm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/lvm-devel
>
Yes I know, didn't wanna do this again for a newer version of LVM, the
idea is more important.
--
Robert Milasan
L3 Support Engineer
SUSE Linux (http://www.suse.com)
email: rmilasan at suse.com
GPG fingerprint: B6FE F4A8 0FA3 3040 3402 6FE7 2F64 167C 1909 6D1A
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-19 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-19 12:33 clvmd always sets debug level to DEBUG_SYSLOG Robert Milasan
2012-10-19 13:39 ` Zdenek Kabelac
2012-10-19 13:46 ` Robert Milasan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.