Re: usb-audio: Reloop Play support (TI TUSB3200AC)

[Daniel Mack <zonque@gmail.com>]

On 20.10.2012 16:24, Didier Villevalois wrote:
> OK this quirk works perfectly! (hooray!!!)
> 
> /* Reloop Play */
> {
> 	USB_DEVICE(0x200c, 0x100b),
> 	.bInterfaceClass = USB_CLASS_PER_INTERFACE,
> 	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> 		.vendor_name = "Reloop",
> 		.product_name = "Play",
> 		.ifnum = QUIRK_ANY_INTERFACE,
> 		.type = QUIRK_COMPOSITE,
> 		.data = &(const struct snd_usb_audio_quirk[]) {
> 			{
> 				.ifnum = 0,
> 				.type = QUIRK_AUDIO_STANDARD_MIXER,
> 			},
> 			{
> 				.ifnum = 1,
> 				.type = QUIRK_AUDIO_FIXED_ENDPOINT,
> 				.data = &(const struct audioformat) {
> 					.formats = SNDRV_PCM_FMTBIT_S24_3LE,
> 					.channels = 4,
> 					.iface = 1,
> 					.altsetting = 1,
> 					.altset_idx = 1,
> 					.attributes = UAC_EP_CS_ATTR_SAMPLE_RATE,
> 					.endpoint = 0x01,
> 					.rates = SNDRV_PCM_RATE_44100 |
> 						 SNDRV_PCM_RATE_48000,
> 					.rate_min = 44100,
> 					.rate_max = 48000,
> 					.nr_rates = 2,
> 					.rate_table = (unsigned int[]) {
> 						44100, 48000
> 					}
> 				}
> 			},
> 			{
> 				.ifnum = -1
> 			}
> 		}
> 	}
> },
> 
> Does anyone have additional comments to do before I make a patch ?

Let's ask Clemens - the quirks master - for comments :)

> Also are there some special ALSA rules or straight signed-off
> git-formated patches over the kernel tree are OK ?

That's ok. The patch should apply on top of

  git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

though.

> Thanks again for your help! I'm really happy to have a working
> device! :D

Good work! I just really wonder what that updated firmware is all about ...


Daniel