All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Didier 'Ptitjes' Villevalois <ptitjes@free.fr>
Cc: alsa-devel@alsa-project.org, Daniel Mack <zonque@gmail.com>
Subject: Re: usb-audio: Reloop Play support (TI TUSB3200AC)
Date: Sat, 20 Oct 2012 18:15:10 +0200	[thread overview]
Message-ID: <5082CE0E.1010701@ladisch.de> (raw)
In-Reply-To: <1350743458.25322.16.camel@didier-laptop>

Didier 'Ptitjes' Villevalois wrote:
>                 .vendor_name = "Reloop",
>                 .product_name = "Play",

These aren't needed except when they are wrong in the descriptor.

>                                 .data = &(const struct audioformat) {
>                                         .formats = SNDRV_PCM_FMTBIT_S24_3LE,
>                                         .channels = 4,
>                                         .iface = 1,
>                                         .altsetting = 1,
>                                         .altset_idx = 1,
>                                         .attributes = UAC_EP_CS_ATTR_SAMPLE_RATE,
>                                         .endpoint = 0x01,

You might as well set ep_attr to USB_ENDPOINT_SYNC_ADAPTIVE.


Regards,
Clemens

  reply	other threads:[~2012-10-20 16:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-19 13:09 usb-audio: Reloop Play support (TI TUSB3200AC) Didier 'Ptitjes' Villevalois
2012-10-19 13:20 ` Daniel Mack
     [not found]   ` <1350654327.8310.4.camel@didier-laptop>
2012-10-19 13:53     ` Daniel Mack
2012-10-19 15:09       ` Didier 'Ptitjes' Villevalois
2012-10-19 18:02         ` Daniel Mack
2012-10-20 10:22           ` Didier 'Ptitjes' Villevalois
2012-10-20 12:49             ` Daniel Mack
2012-10-20 13:03               ` Didier 'Ptitjes' Villevalois
2012-10-20 13:06                 ` Daniel Mack
2012-10-20 13:11                   ` Didier 'Ptitjes' Villevalois
2013-08-23 15:58                     ` Ansgar Scheffold
2012-10-19 15:28       ` Didier 'Ptitjes' Villevalois
2012-10-19 18:06         ` Daniel Mack
2012-10-20 14:30 ` Didier 'Ptitjes' Villevalois
2012-10-20 16:15   ` Clemens Ladisch [this message]
2012-10-21 13:38     ` Didier 'Ptitjes' Villevalois
2012-10-21 14:11       ` Clemens Ladisch
     [not found] ` <1350743061.25322.15.camel@didier-laptop>
2012-10-20 15:00   ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5082CE0E.1010701@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=ptitjes@free.fr \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.