From: Sumit Semwal <sumit.semwal@linaro.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: tomi.valkeinen@ti.com, FlorianSchandinat@gmx.de,
yongjun_wei@trendmicro.com.cn, linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] OMAPDSS: HDMI: fix missing unlock on error in hdmi_dump_regs()
Date: Mon, 22 Oct 2012 06:14:36 +0000 [thread overview]
Message-ID: <5084E17C.1070403@linaro.org> (raw)
In-Reply-To: <CAPgLHd--5Y4cq3ieoRSueg-i0boqRa4JqRPL7+cJ0UfesunjoQ@mail.gmail.com>
On Sunday 21 October 2012 06:24 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing unlock on the error handling path in function
> hdmi_dump_regs().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Looks good to me; feel free to add:
Reviewed-by: Sumit Semwal <sumit.semwal@ti.com>
> ---
> no test
> ---
> drivers/video/omap2/dss/hdmi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
> index a48a7dd..8c9b8b3 100644
> --- a/drivers/video/omap2/dss/hdmi.c
> +++ b/drivers/video/omap2/dss/hdmi.c
> @@ -644,8 +644,10 @@ static void hdmi_dump_regs(struct seq_file *s)
> {
> mutex_lock(&hdmi.lock);
>
> - if (hdmi_runtime_get())
> + if (hdmi_runtime_get()) {
> + mutex_unlock(&hdmi.lock);
> return;
> + }
>
> hdmi.ip_data.ops->dump_wrapper(&hdmi.ip_data, s);
> hdmi.ip_data.ops->dump_pll(&hdmi.ip_data, s);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Semwal <sumit.semwal@linaro.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: tomi.valkeinen@ti.com, FlorianSchandinat@gmx.de,
yongjun_wei@trendmicro.com.cn, linux-omap@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] OMAPDSS: HDMI: fix missing unlock on error in hdmi_dump_regs()
Date: Mon, 22 Oct 2012 11:32:36 +0530 [thread overview]
Message-ID: <5084E17C.1070403@linaro.org> (raw)
In-Reply-To: <CAPgLHd--5Y4cq3ieoRSueg-i0boqRa4JqRPL7+cJ0UfesunjoQ@mail.gmail.com>
On Sunday 21 October 2012 06:24 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing unlock on the error handling path in function
> hdmi_dump_regs().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Looks good to me; feel free to add:
Reviewed-by: Sumit Semwal <sumit.semwal@ti.com>
> ---
> no test
> ---
> drivers/video/omap2/dss/hdmi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
> index a48a7dd..8c9b8b3 100644
> --- a/drivers/video/omap2/dss/hdmi.c
> +++ b/drivers/video/omap2/dss/hdmi.c
> @@ -644,8 +644,10 @@ static void hdmi_dump_regs(struct seq_file *s)
> {
> mutex_lock(&hdmi.lock);
>
> - if (hdmi_runtime_get())
> + if (hdmi_runtime_get()) {
> + mutex_unlock(&hdmi.lock);
> return;
> + }
>
> hdmi.ip_data.ops->dump_wrapper(&hdmi.ip_data, s);
> hdmi.ip_data.ops->dump_pll(&hdmi.ip_data, s);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-10-22 6:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-21 12:54 [PATCH] OMAPDSS: HDMI: fix missing unlock on error in hdmi_dump_regs() Wei Yongjun
2012-10-21 12:54 ` Wei Yongjun
2012-10-22 6:02 ` Sumit Semwal [this message]
2012-10-22 6:14 ` Sumit Semwal
2012-10-22 6:53 ` Tomi Valkeinen
2012-10-22 6:53 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5084E17C.1070403@linaro.org \
--to=sumit.semwal@linaro.org \
--cc=FlorianSchandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.