From: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mel Gorman <mgorman-l3A5Bk7waGM@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Pekka Enberg <penberg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org,
Pekka Enberg <penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org>,
Suleiman Souhlal
<suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v5 10/18] sl[au]b: always get the cache from its page in kfree
Date: Mon, 22 Oct 2012 14:13:40 +0400 [thread overview]
Message-ID: <50851C54.9080600@parallels.com> (raw)
In-Reply-To: <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
On 10/19/2012 11:44 PM, Christoph Lameter wrote:
> On Fri, 19 Oct 2012, Glauber Costa wrote:
>
>> struct page already have this information. If we start chaining
>> caches, this information will always be more trustworthy than
>> whatever is passed into the function
>
> Yes it does but the information is not standardized between the allocators
> yet. Coul you unify that? Come out with a struct page overlay that is as
> much the same as possible. Then kfree can also be unified because the
> lookup is always the same. That way you can move kfree into slab_common
> and avoid modifying multiple allocators.
>
Ok, this is yet another changelog mistake from mine. This function is
not about kfree, but kmem_cache_free.
But part of your comment still applies, the page lookup can still be
common. I will take a look at that.
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, Mel Gorman <mgorman@suse.de>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
kamezawa.hiroyu@jp.fujitsu.com,
David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>,
devel@openvz.org, Pekka Enberg <penberg@cs.helsinki.fi>,
Suleiman Souhlal <suleiman@google.com>
Subject: Re: [PATCH v5 10/18] sl[au]b: always get the cache from its page in kfree
Date: Mon, 22 Oct 2012 14:13:40 +0400 [thread overview]
Message-ID: <50851C54.9080600@parallels.com> (raw)
In-Reply-To: <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000@email.amazonses.com>
On 10/19/2012 11:44 PM, Christoph Lameter wrote:
> On Fri, 19 Oct 2012, Glauber Costa wrote:
>
>> struct page already have this information. If we start chaining
>> caches, this information will always be more trustworthy than
>> whatever is passed into the function
>
> Yes it does but the information is not standardized between the allocators
> yet. Coul you unify that? Come out with a struct page overlay that is as
> much the same as possible. Then kfree can also be unified because the
> lookup is always the same. That way you can move kfree into slab_common
> and avoid modifying multiple allocators.
>
Ok, this is yet another changelog mistake from mine. This function is
not about kfree, but kmem_cache_free.
But part of your comment still applies, the page lookup can still be
common. I will take a look at that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<cgroups@vger.kernel.org>, Mel Gorman <mgorman@suse.de>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
<kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>, <devel@openvz.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Suleiman Souhlal <suleiman@google.com>
Subject: Re: [PATCH v5 10/18] sl[au]b: always get the cache from its page in kfree
Date: Mon, 22 Oct 2012 14:13:40 +0400 [thread overview]
Message-ID: <50851C54.9080600@parallels.com> (raw)
In-Reply-To: <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000@email.amazonses.com>
On 10/19/2012 11:44 PM, Christoph Lameter wrote:
> On Fri, 19 Oct 2012, Glauber Costa wrote:
>
>> struct page already have this information. If we start chaining
>> caches, this information will always be more trustworthy than
>> whatever is passed into the function
>
> Yes it does but the information is not standardized between the allocators
> yet. Coul you unify that? Come out with a struct page overlay that is as
> much the same as possible. Then kfree can also be unified because the
> lookup is always the same. That way you can move kfree into slab_common
> and avoid modifying multiple allocators.
>
Ok, this is yet another changelog mistake from mine. This function is
not about kfree, but kmem_cache_free.
But part of your comment still applies, the page lookup can still be
common. I will take a look at that.
next prev parent reply other threads:[~2012-10-22 10:13 UTC|newest]
Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 14:20 [PATCH v5 00/18] slab accounting for memcg Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
[not found] ` <1350656442-1523-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-19 14:20 ` [PATCH v5 01/18] move slabinfo processing to slab_common.c Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
[not found] ` <1350656442-1523-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-24 6:43 ` Pekka Enberg
2012-10-24 6:43 ` Pekka Enberg
2012-10-24 6:43 ` Pekka Enberg
2012-10-19 14:20 ` [PATCH v5 02/18] move print_slabinfo_header " Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 03/18] sl[au]b: process slabinfo_show in common code Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 04/18] slab: don't preemptively remove element from list in cache destroy Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
[not found] ` <1350656442-1523-5-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-19 19:34 ` Christoph Lameter
2012-10-19 19:34 ` Christoph Lameter
2012-10-19 19:34 ` Christoph Lameter
[not found] ` <0000013a7a84cb28-334eab12-33c4-4a92-bd9c-e5ad938f83d0-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-10-22 8:40 ` Glauber Costa
2012-10-22 8:40 ` Glauber Costa
2012-10-22 8:40 ` Glauber Costa
[not found] ` <5085068E.5080304-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-24 6:54 ` Pekka Enberg
2012-10-24 6:54 ` Pekka Enberg
2012-10-24 6:54 ` Pekka Enberg
2012-10-24 16:19 ` Glauber Costa
2012-10-24 16:19 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 05/18] slab/slub: struct memcg_params Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
[not found] ` <1350656442-1523-6-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-23 17:25 ` JoonSoo Kim
2012-10-23 17:25 ` JoonSoo Kim
2012-10-23 17:25 ` JoonSoo Kim
2012-10-24 8:42 ` Glauber Costa
2012-10-24 8:42 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 06/18] consider a memcg parameter in kmem_create_cache Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
[not found] ` <1350656442-1523-7-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-23 17:50 ` JoonSoo Kim
2012-10-23 17:50 ` JoonSoo Kim
2012-10-23 17:50 ` JoonSoo Kim
[not found] ` <CAAmzW4OJGSpEO2_p3v1MZJrh6G=+NSS5UoGqFDvxeaQ0qryvpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-24 8:42 ` Glauber Costa
2012-10-24 8:42 ` Glauber Costa
2012-10-24 8:42 ` Glauber Costa
2012-10-25 13:42 ` Glauber Costa
2012-10-25 13:42 ` Glauber Costa
2012-10-25 13:42 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 07/18] Allocate memory for memcg caches whenever a new memcg appears Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 08/18] memcg: infrastructure to match an allocation to the right cache Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-24 18:10 ` JoonSoo Kim
2012-10-24 18:10 ` JoonSoo Kim
[not found] ` <CAAmzW4N40MedsCfcj+eiM-i6cU65n3z7uy08YFyknXbBKj7Z-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-25 11:05 ` Glauber Costa
2012-10-25 11:05 ` Glauber Costa
2012-10-25 11:05 ` Glauber Costa
[not found] ` <50891CF2.3030400-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-25 18:06 ` Tejun Heo
2012-10-25 18:06 ` Tejun Heo
2012-10-25 18:06 ` Tejun Heo
2012-10-25 18:08 ` Tejun Heo
2012-10-25 18:08 ` Tejun Heo
2012-10-19 14:20 ` [PATCH v5 09/18] memcg: skip memcg kmem allocations in specified code regions Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 10/18] sl[au]b: always get the cache from its page in kfree Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
[not found] ` <1350656442-1523-11-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-19 19:44 ` Christoph Lameter
2012-10-19 19:44 ` Christoph Lameter
2012-10-19 19:44 ` Christoph Lameter
[not found] ` <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-10-22 10:13 ` Glauber Costa [this message]
2012-10-22 10:13 ` Glauber Costa
2012-10-22 10:13 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 11/18] sl[au]b: Allocate objects from memcg cache Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
[not found] ` <1350656442-1523-12-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-19 19:46 ` Christoph Lameter
2012-10-19 19:46 ` Christoph Lameter
2012-10-19 19:46 ` Christoph Lameter
2012-10-29 15:14 ` JoonSoo Kim
2012-10-29 15:14 ` JoonSoo Kim
2012-10-29 15:14 ` JoonSoo Kim
[not found] ` <CAAmzW4M7SFF8t491mrHdXmdmCVA_=ma_XMCEyuOMo3TnqDVNxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 15:19 ` Glauber Costa
2012-10-29 15:19 ` Glauber Costa
2012-10-29 15:19 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 12/18] memcg: destroy memcg caches Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 13/18] memcg/sl[au]b Track all the memcg children of a kmem_cache Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
[not found] ` <1350656442-1523-14-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-29 15:26 ` JoonSoo Kim
2012-10-29 15:26 ` JoonSoo Kim
2012-10-29 15:26 ` JoonSoo Kim
[not found] ` <CAAmzW4MGdj-jL_FJ2Nkoa4Hx8KUDCeVK6HFidYQLauu_0vHhCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-30 11:31 ` Glauber Costa
2012-10-30 11:31 ` Glauber Costa
2012-10-30 11:31 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 14/18] memcg/sl[au]b: shrink dead caches Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
[not found] ` <1350656442-1523-15-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-19 19:47 ` Christoph Lameter
2012-10-19 19:47 ` Christoph Lameter
2012-10-19 19:47 ` Christoph Lameter
[not found] ` <0000013a7a9144d1-de184c46-2a7d-4e6c-8606-927cc1f48969-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-10-22 7:37 ` Glauber Costa
2012-10-22 7:37 ` Glauber Costa
2012-10-22 7:37 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 15/18] Aggregate memcg cache values in slabinfo Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 19:50 ` Christoph Lameter
2012-10-19 19:50 ` Christoph Lameter
2012-10-22 15:11 ` Glauber Costa
2012-10-22 15:11 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 16/18] slab: propagate tunables values Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 19:51 ` Christoph Lameter
2012-10-19 19:51 ` Christoph Lameter
2012-10-22 7:48 ` Glauber Costa
2012-10-22 7:48 ` Glauber Costa
2012-10-23 20:44 ` Christoph Lameter
2012-10-23 20:44 ` Christoph Lameter
2012-10-19 14:20 ` [PATCH v5 17/18] slub: slub-specific propagation changes Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` [PATCH v5 18/18] Add slab-specific documentation about the kmem controller Glauber Costa
2012-10-19 14:20 ` Glauber Costa
2012-10-19 14:20 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50851C54.9080600@parallels.com \
--to=glommer-bzqdu9zft3wakbo8gow8eq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mgorman-l3A5Bk7waGM@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=penberg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org \
--cc=rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.